[YARN-4002] make ResourceTrackerService.nodeHeartbeat more concurrent

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Hong Zhiguo
• Reporter: Hong Zhiguo
• Created: 31/Jul/15 02:24
• Updated: 11/May/17 22:10
• Resolved: 19/May/16 20:03

Description

We have multiple RPC threads to handle NodeHeartbeatRequest from NMs. By design the method ResourceTrackerService.nodeHeartbeat should be concurrent enough to scale for large clusters.
But we have a "BIG" lock in NodesListManager.isValidNode which I think it's unnecessary.
First, the fields "includes" and "excludes" of HostsFileReader are only updated on "refresh nodes". All RPC threads handling node heartbeats are only readers. So RWLock could be used to alow concurrent access by RPC threads.
Second, since he fields "includes" and "excludes" of HostsFileReader are always updated by "reference assignment", which is atomic in Java, the reader side lock could just be skipped.

Issue Links

• breaks: HADOOP-14412 HostsFileReader#getHostDetails is very expensive on large clusters