Hadoop YARN
  1. Hadoop YARN
  2. YARN-40

Provide support for missing yarn commands

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.3-alpha, 0.23.7
    • Component/s: client
    • Labels:
      None

      Description

      1. status <app-id>
      2. kill <app-id> (Already issue present with Id : MAPREDUCE-3793)
      3. list-apps [all]
      4. nodes-report

      1. YARN-40-20121008.txt
        28 kB
        Vinod Kumar Vavilapalli
      2. YARN-40-20120924.txt
        28 kB
        Vinod Kumar Vavilapalli
      3. YARN-40-20120917.1.txt
        28 kB
        Vinod Kumar Vavilapalli
      4. YARN-40-20120917.txt
        28 kB
        Vinod Kumar Vavilapalli
      5. YARN-40-1.patch
        27 kB
        Devaraj K
      6. YARN-40.patch
        28 kB
        Devaraj K
      7. MAPREDUCE-4155-1.patch
        32 kB
        Devaraj K
      8. MAPREDUCE-4155.patch
        29 kB
        Devaraj K

        Issue Links

          Activity

          Hide
          Devaraj K added a comment -

          I have attached patch for this. Please review and give your comments on this.

          Show
          Devaraj K added a comment - I have attached patch for this. Please review and give your comments on this.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12524439/MAPREDUCE-4155.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.yarn.server.TestContainerManagerSecurity
          org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens
          org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
          org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
          org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
          org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs
          org.apache.hadoop.mapred.TestClientRedirect
          org.apache.hadoop.mapreduce.TestYarnClientProtocolProvider
          org.apache.hadoop.mapreduce.security.TestJHSSecurity

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2315//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2315//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524439/MAPREDUCE-4155.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.TestContainerManagerSecurity org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs org.apache.hadoop.mapred.TestClientRedirect org.apache.hadoop.mapreduce.TestYarnClientProtocolProvider org.apache.hadoop.mapreduce.security.TestJHSSecurity +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2315//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2315//console This message is automatically generated.
          Hide
          Ahmed Radwan added a comment -

          Thanks Devaraj for this addition! +1, can you please add docs for these new commands (e.g. in YarnCommands.apt.vm).

          Show
          Ahmed Radwan added a comment - Thanks Devaraj for this addition! +1, can you please add docs for these new commands (e.g. in YarnCommands.apt.vm).
          Hide
          Robert Joseph Evans added a comment -

          I agree with Ahmed that we need better documentation on these commands. I would also like to see the tests updated so that instead of using mocks to verify how many times printf was called on stderr, I would prefer to see us compare the actual output to a string.

          I also would prefer to see us use commons CLI for the argument parsing like we do in other parts of the code, but this is very minor. I don't see it as a problem with the current code, I just have seen too many commands expand beyond what they initially had, and the command line parsing become very ugly.

          Show
          Robert Joseph Evans added a comment - I agree with Ahmed that we need better documentation on these commands. I would also like to see the tests updated so that instead of using mocks to verify how many times printf was called on stderr, I would prefer to see us compare the actual output to a string. I also would prefer to see us use commons CLI for the argument parsing like we do in other parts of the code, but this is very minor. I don't see it as a problem with the current code, I just have seen too many commands expand beyond what they initially had, and the command line parsing become very ugly.
          Hide
          Devaraj K added a comment -

          Thanks a lot Robert and Ahmed for reviewing the patch.

          I have updated the patch with the above changes.

          Show
          Devaraj K added a comment - Thanks a lot Robert and Ahmed for reviewing the patch. I have updated the patch with the above changes.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12525435/MAPREDUCE-4155-1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2352//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2352//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525435/MAPREDUCE-4155-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2352//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2352//console This message is automatically generated.
          Hide
          Devaraj K added a comment -

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          These javadoc errors are not because of this patch changes. Same errors were reported in other patches Hadoop QA reports also.

          Show
          Devaraj K added a comment - -1 javadoc. The javadoc tool appears to have generated 2 warning messages. These javadoc errors are not because of this patch changes. Same errors were reported in other patches Hadoop QA reports also.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Thanks for taking this up Devaraj.

          None of these tools should be in the resourcemanager module. We should have them in some kind of client module.

          I also see that we are duplicating (some) code for talking to RM via client API. In this light also, a yarn-client module will be useful so that clients of all frameworks can use/extend it. And that same module can be the destination for the command line tools.

          Will open a separate ticket for the above.

          Show
          Vinod Kumar Vavilapalli added a comment - Thanks for taking this up Devaraj. None of these tools should be in the resourcemanager module. We should have them in some kind of client module. I also see that we are duplicating (some) code for talking to RM via client API. In this light also, a yarn-client module will be useful so that clients of all frameworks can use/extend it. And that same module can be the destination for the command line tools. Will open a separate ticket for the above.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Devaraj, can you rebase the patch and modify it to use YarnClient now that YARN-29 is in? Tx.

          Show
          Vinod Kumar Vavilapalli added a comment - Devaraj, can you rebase the patch and modify it to use YarnClient now that YARN-29 is in? Tx.
          Hide
          Devaraj K added a comment -

          Thanks Vinod for looking into the patch. I will update the patch.

          Show
          Devaraj K added a comment - Thanks Vinod for looking into the patch. I will update the patch.
          Hide
          Devaraj K added a comment -

          I updated the patch to make use of YarnClient. Please review it.

          Show
          Devaraj K added a comment - I updated the patch to make use of YarnClient. Please review it.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Great, looking at the patch right now..

          Show
          Vinod Kumar Vavilapalli added a comment - Great, looking at the patch right now..
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Thanks, this looks a lot cleaner. Some comments:

          • Call "app" command as "application" everywhere?
          • Rename YarnCLI.STATUS ans YarnCLI.STATUS_CMD. Similarly others.
          • The speical handling of completed apps in killApplication() is not useful. Between the time a report is obtain from the RM and the subsequent kill request, an app can go to a final state. We should handle this as part of forceKillApplication() in RM itself. Can you open a separate ticket for that?
          • I think we should start making the lists simpler than what they were in MR1, which were unnecessarily bulky. We should only print basic information in the list command, and if somebody needs more information than that for an app/node, they can use "application -status" or "node -status". How about:
            • For application
              • Application-Id
              • Application-Name
              • User
              • Queue
              • State
              • Final-State
              • Tracking-URL
            • For node
              • Node-Id
              • Node-state
              • Node-http-address
              • Health-Status
              • Running-containers
          • Please remove all spaces in a single header. Like "Application-Id" instead of "Application Id"
          • Finally, we should format the columns and their headers properly - See org.apache.hadoop.mapreduce.tools.CLI 's headerPattern and dataPattern for example.
          Show
          Vinod Kumar Vavilapalli added a comment - Thanks, this looks a lot cleaner. Some comments: Call "app" command as "application" everywhere? Rename YarnCLI.STATUS ans YarnCLI.STATUS_CMD. Similarly others. The speical handling of completed apps in killApplication() is not useful. Between the time a report is obtain from the RM and the subsequent kill request, an app can go to a final state. We should handle this as part of forceKillApplication() in RM itself. Can you open a separate ticket for that? I think we should start making the lists simpler than what they were in MR1, which were unnecessarily bulky. We should only print basic information in the list command, and if somebody needs more information than that for an app/node, they can use "application -status" or "node -status". How about: For application Application-Id Application-Name User Queue State Final-State Tracking-URL For node Node-Id Node-state Node-http-address Health-Status Running-containers Please remove all spaces in a single header. Like "Application-Id" instead of "Application Id" Finally, we should format the columns and their headers properly - See org.apache.hadoop.mapreduce.tools.CLI 's headerPattern and dataPattern for example.
          Hide
          Devaraj K added a comment -

          Thanks a lot Vinod for the comments. I have updated the patch.

          The speical handling of completed apps in killApplication() is not useful. Between the time a report is obtain from the RM and the subsequent kill request, an app can go to a final state. We should handle this as part of forceKillApplication() in RM itself. Can you open a separate ticket for that?

          I have raised YARN-107 for handling this.

          Show
          Devaraj K added a comment - Thanks a lot Vinod for the comments. I have updated the patch. The speical handling of completed apps in killApplication() is not useful. Between the time a report is obtain from the RM and the subsequent kill request, an app can go to a final state. We should handle this as part of forceKillApplication() in RM itself. Can you open a separate ticket for that? I have raised YARN-107 for handling this.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          This has a bug in "node -status" in case there are multiple nodes. Fixing this myself..

          Show
          Vinod Kumar Vavilapalli added a comment - This has a bug in "node -status" in case there are multiple nodes. Fixing this myself..
          Hide
          Vinod Kumar Vavilapalli added a comment -

          This should fix the bug. Will commit it once Jenkins blesses the patch.

          Show
          Vinod Kumar Vavilapalli added a comment - This should fix the bug. Will commit it once Jenkins blesses the patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12545457/YARN-40-20120917.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site:

          org.apache.hadoop.yarn.client.cli.TestYarnCLI

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/39//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/39//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545457/YARN-40-20120917.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site: org.apache.hadoop.yarn.client.cli.TestYarnCLI +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/39//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/39//console This message is automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          This should fix it.

          Show
          Vinod Kumar Vavilapalli added a comment - This should fix it.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12545519/YARN-40-20120917.1.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site:

          org.apache.hadoop.yarn.client.cli.TestYarnCLI

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/43//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/43//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545519/YARN-40-20120917.1.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site: org.apache.hadoop.yarn.client.cli.TestYarnCLI +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/43//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/43//console This message is automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Fixed more typos, and the test-failure. Hopefully the last iteration.

          Show
          Vinod Kumar Vavilapalli added a comment - Fixed more typos, and the test-failure. Hopefully the last iteration.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546438/YARN-40-20120924.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/50//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/50//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546438/YARN-40-20120924.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/50//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/50//console This message is automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Been a while, will rekick Jenkins and commit this.

          Show
          Vinod Kumar Vavilapalli added a comment - Been a while, will rekick Jenkins and commit this.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546438/YARN-40-20120924.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site:

          org.apache.hadoop.yarn.client.TestYarnClient

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/65//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/65//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546438/YARN-40-20120924.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site: org.apache.hadoop.yarn.client.TestYarnClient +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/65//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/65//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          Looks like you need to change Configuration to YarnConfiguration in TestYarnClient.java

          --- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestYarnClient.java  (revision 1393118)
          +++ hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestYarnClient.java  (working copy)
          @@ -18,7 +18,7 @@
           
           package org.apache.hadoop.yarn.client;
           
          -import org.apache.hadoop.conf.Configuration;
          +import org.apache.hadoop.yarn.conf.YarnConfiguration;
           import org.apache.hadoop.yarn.client.YarnClient;
           import org.apache.hadoop.yarn.client.YarnClientImpl;
           import org.apache.hadoop.yarn.server.resourcemanager.ResourceManager;
          @@ -33,7 +33,7 @@
           
             @Test
             public void testClientStop() {
          -    Configuration conf = new Configuration();
          +    YarnConfiguration conf = new YarnConfiguration();
               ResourceManager rm = new ResourceManager(null);
               rm.init(conf);
               rm.start();
          

          Also the patch is in Windows Format so before it is checked in they should be converted to unix format.
          After that I am a +1 on the patch too.

          Show
          Robert Joseph Evans added a comment - Looks like you need to change Configuration to YarnConfiguration in TestYarnClient.java --- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestYarnClient.java (revision 1393118) +++ hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestYarnClient.java (working copy) @@ -18,7 +18,7 @@ package org.apache.hadoop.yarn.client; - import org.apache.hadoop.conf.Configuration; + import org.apache.hadoop.yarn.conf.YarnConfiguration; import org.apache.hadoop.yarn.client.YarnClient; import org.apache.hadoop.yarn.client.YarnClientImpl; import org.apache.hadoop.yarn.server.resourcemanager.ResourceManager; @@ -33,7 +33,7 @@ @Test public void testClientStop() { - Configuration conf = new Configuration(); + YarnConfiguration conf = new YarnConfiguration(); ResourceManager rm = new ResourceManager( null ); rm.init(conf); rm.start(); Also the patch is in Windows Format so before it is checked in they should be converted to unix format. After that I am a +1 on the patch too.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Thanks for the review Bobby.

          I just filed YARN-148 for the test/capacity-scheduler issue.

          Show
          Vinod Kumar Vavilapalli added a comment - Thanks for the review Bobby. I just filed YARN-148 for the test/capacity-scheduler issue.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Patch getting rid of extraneous ^M chars.

          Show
          Vinod Kumar Vavilapalli added a comment - Patch getting rid of extraneous ^M chars.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12548301/YARN-40-20121008.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site:

          org.apache.hadoop.yarn.client.TestYarnClient

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/75//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/75//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12548301/YARN-40-20121008.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site: org.apache.hadoop.yarn.client.TestYarnClient +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/75//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/75//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2889 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2889/)
          YARN-40. Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2889 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2889/ ) YARN-40 . Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2827 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2827/)
          YARN-40. Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2827 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2827/ ) YARN-40 . Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Hide
          Vinod Kumar Vavilapalli added a comment -

          I just committed this to trunk and branch-2. Thanks Devaraj for the patches!

          Show
          Vinod Kumar Vavilapalli added a comment - I just committed this to trunk and branch-2. Thanks Devaraj for the patches!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2890 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2890/)
          YARN-40. Fixed CHANGES.txt from previous commit. (Revision 1395799)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2890 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2890/ ) YARN-40 . Fixed CHANGES.txt from previous commit. (Revision 1395799) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2828 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2828/)
          YARN-40. Fixed CHANGES.txt from previous commit. (Revision 1395799)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2828 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2828/ ) YARN-40 . Fixed CHANGES.txt from previous commit. (Revision 1395799) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2851 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2851/)
          YARN-40. Fixed CHANGES.txt from previous commit. (Revision 1395799)
          YARN-40. Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793)

          Result = FAILURE
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2851 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2851/ ) YARN-40 . Fixed CHANGES.txt from previous commit. (Revision 1395799) YARN-40 . Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1190/)
          YARN-40. Fixed CHANGES.txt from previous commit. (Revision 1395799)
          YARN-40. Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1190/ ) YARN-40 . Fixed CHANGES.txt from previous commit. (Revision 1395799) YARN-40 . Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1221 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1221/)
          YARN-40. Fixed CHANGES.txt from previous commit. (Revision 1395799)
          YARN-40. Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793)

          Result = SUCCESS
          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1221 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1221/ ) YARN-40 . Fixed CHANGES.txt from previous commit. (Revision 1395799) YARN-40 . Provided support for missing YARN commands Contributed by Devaraj K and Vinod Kumar Vavilapalli. (Revision 1395793) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395799 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395793 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/YarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Hide
          Junping Du added a comment -

          Do we have plan to backport this to branch-1?

          Show
          Junping Du added a comment - Do we have plan to backport this to branch-1?
          Hide
          Harsh J added a comment -

          Junping,

          Do you mean an equivalent for the "yarn node" command for MRv1 tasktrackers? I guess it could be done if there is value in it (personally I've not seen people interested in monitoring a single TT's state of maps/reduces via the CLI). Other than that, the commands seem to be YARN specific?

          Show
          Harsh J added a comment - Junping, Do you mean an equivalent for the "yarn node" command for MRv1 tasktrackers? I guess it could be done if there is value in it (personally I've not seen people interested in monitoring a single TT's state of maps/reduces via the CLI). Other than that, the commands seem to be YARN specific?
          Hide
          Junping Du added a comment -

          Hi Harsh, there is requirement to dynamic configure resource/slot for hadoop nodes for YARN or MRV1 in a mix workload environment (like mix HBase and MR). So that admin can dynamically set the slot number to change QoS of MR as requirement. I have filed JIRAs (YARN-291, MAPREDUCE-4900) to track this, so list TT status (at least slot number) is still useful? Anyway, I saw Binglin create MAPREDUCE-4944 to backport this jira.

          Show
          Junping Du added a comment - Hi Harsh, there is requirement to dynamic configure resource/slot for hadoop nodes for YARN or MRV1 in a mix workload environment (like mix HBase and MR). So that admin can dynamically set the slot number to change QoS of MR as requirement. I have filed JIRAs ( YARN-291 , MAPREDUCE-4900 ) to track this, so list TT status (at least slot number) is still useful? Anyway, I saw Binglin create MAPREDUCE-4944 to backport this jira.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #518 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/518/)
          YARN-40. Provide support for missing yarn commands (Devaraj K via tgraves) (Revision 1443119)

          Result = SUCCESS
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443119
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/bin/yarn
          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #518 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/518/ ) YARN-40 . Provide support for missing yarn commands (Devaraj K via tgraves) (Revision 1443119) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443119 Files : /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/bin/yarn /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/YarnCommands.apt.vm

            People

            • Assignee:
              Devaraj K
              Reporter:
              Devaraj K
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development