Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3882

AggregatedLogFormat should close aclScanner and ownerScanner after create them.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nodemanager
    • Labels:
      None

      Description

      AggregatedLogFormat should close aclScanner and ownerScanner after create them. aclScanner and ownerScanner are created by createScanner in getApplicationAcls and getApplicationOwner and are never closed. TFile.Reader.Scanner implement java.io.Closeable. We should close them after use them.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2193 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2193/)
        YARN-3882. AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2193 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2193/ ) YARN-3882 . AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #245 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/245/)
        YARN-3882. AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #245 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/245/ ) YARN-3882 . AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #235 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/235/)
        YARN-3882. AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #235 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/235/ ) YARN-3882 . AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2174 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2174/)
        YARN-3882. AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2174 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2174/ ) YARN-3882 . AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #247 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/247/)
        YARN-3882. AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #247 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/247/ ) YARN-3882 . AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #977 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/977/)
        YARN-3882. AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #977 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/977/ ) YARN-3882 . AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java hadoop-yarn-project/CHANGES.txt
        Hide
        zxu zhihai xu added a comment -

        thanks Xuan Gong for the review and committing the patch!

        Show
        zxu zhihai xu added a comment - thanks Xuan Gong for the review and committing the patch!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8113 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8113/)
        YARN-3882. AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8113 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8113/ ) YARN-3882 . AggregatedLogFormat should close aclScanner and ownerScanner (xgong: rev 688617d6d7e6377a37682b5676b805cc6e8cf3f0) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java hadoop-yarn-project/CHANGES.txt
        Hide
        xgong Xuan Gong added a comment -

        Committed to trunk/branch-2. Thanks, zhihai

        Show
        xgong Xuan Gong added a comment - Committed to trunk/branch-2. Thanks, zhihai
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 41s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 44s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 52s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common.
            40m 59s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743423/YARN-3882.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2eae130
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8420/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8420/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8420/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 41s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 52s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common.     40m 59s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743423/YARN-3882.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2eae130 hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8420/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8420/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8420/console This message was automatically generated.
        Hide
        xgong Xuan Gong added a comment -

        +1 LGTM. Pending Jenkins

        Show
        xgong Xuan Gong added a comment - +1 LGTM. Pending Jenkins

          People

          • Assignee:
            zxu zhihai xu
            Reporter:
            zxu zhihai xu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development