Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3875

FSSchedulerNode#reserveResource() doesn't print Application Id properly in log

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      FSSchedulerNode#reserveResource()

            LOG.info("Updated reserved container " + 
                container.getContainer().getId() + " on node " + 
                this + " for application " + application);
          } else {
            LOG.info("Reserved container " + container.getContainer().getId() + 
                " on node " + this + " for application " + application);
          }
      

      update to application.getApplicationId()

      1. 0001-YARN-3875.patch
        1 kB
        Bibin A Chundatt
      2. 0002-YARN-3875.patch
        2 kB
        Bibin A Chundatt

        Activity

        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Currently logs are shown as below

        Reserved container container_e08_1435660809935_0008_01_000670 on node host: host-10-19-92-117:64318 #containers=6 available=<memory:0, vCores:10> used=<memory:3072, vCores:6> for application org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt@1c1a7108
        

        Patch uploaded please review

        Show
        bibinchundatt Bibin A Chundatt added a comment - Currently logs are shown as below Reserved container container_e08_1435660809935_0008_01_000670 on node host: host-10-19-92-117:64318 #containers=6 available=<memory:0, vCores:10> used=<memory:3072, vCores:6> for application org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt@1c1a7108 Patch uploaded please review
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 0s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 36s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 44s The applied patch generated 2 new checkstyle issues (total was 2, now 4).
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 50m 49s Tests passed in hadoop-yarn-server-resourcemanager.
            88m 46s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743029/0001-YARN-3875.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7405c59
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8402/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8402/artifact/patchprocess/whitespace.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8402/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8402/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8402/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 44s The applied patch generated 2 new checkstyle issues (total was 2, now 4). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 50m 49s Tests passed in hadoop-yarn-server-resourcemanager.     88m 46s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743029/0001-YARN-3875.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7405c59 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8402/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8402/artifact/patchprocess/whitespace.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8402/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8402/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8402/console This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Update patch after formating

        Show
        bibinchundatt Bibin A Chundatt added a comment - Update patch after formating
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 12s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 56s There were no new javac warning messages.
        +1 javadoc 10m 4s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 47s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 51m 16s Tests failed in hadoop-yarn-server-resourcemanager.
            91m 18s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743057/0002-YARN-3875.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7405c59
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8406/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8406/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8406/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 12s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 56s There were no new javac warning messages. +1 javadoc 10m 4s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 47s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 51m 16s Tests failed in hadoop-yarn-server-resourcemanager.     91m 18s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743057/0002-YARN-3875.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7405c59 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8406/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8406/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8406/console This message was automatically generated.
        Hide
        devaraj.k Devaraj K added a comment -

        The failed test doesn't seem to be related to the patch.

        +1 for the trivial change.

        Show
        devaraj.k Devaraj K added a comment - The failed test doesn't seem to be related to the patch. +1 for the trivial change.
        Hide
        devaraj.k Devaraj K added a comment -

        Committing it.

        Show
        devaraj.k Devaraj K added a comment - Committing it.
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Bibin A Chundatt.

        Committed to trunk and branch-2.

        Show
        devaraj.k Devaraj K added a comment - Thanks Bibin A Chundatt . Committed to trunk and branch-2.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Thanks Devaraj K for review and committing patch.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Thanks Devaraj K for review and committing patch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8111 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8111/)
        YARN-3875. FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8111 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8111/ ) YARN-3875 . FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/246/)
        YARN-3875. FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/246/ ) YARN-3875 . FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #976 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/976/)
        YARN-3875. FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #976 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/976/ ) YARN-3875 . FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #244 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/244/)
        YARN-3875. FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #244 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/244/ ) YARN-3875 . FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #234 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/234/)
        YARN-3875. FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #234 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/234/ ) YARN-3875 . FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2173 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2173/)
        YARN-3875. FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2173 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2173/ ) YARN-3875 . FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2192 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2192/)
        YARN-3875. FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2192 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2192/ ) YARN-3875 . FSSchedulerNode#reserveResource() doesn't print Application Id (devaraj: rev 37d7395773b5bb24aa522db38a2602df9a5ac184) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java hadoop-yarn-project/CHANGES.txt

          People

          • Assignee:
            bibinchundatt Bibin A Chundatt
            Reporter:
            bibinchundatt Bibin A Chundatt
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development