Hadoop YARN
  1. Hadoop YARN
  2. YARN-385

ResourceRequestPBImpl's toString() is missing location and # containers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.1.0-beta
    • Component/s: api
    • Labels:
      None

      Description

      ResourceRequestPBImpl's toString method includes priority and resource capability, but omits location and number of containers.

      1. YARN-385.patch
        0.9 kB
        Sandy Ryza

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1338 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1338/)
        YARN-385. Add missing fields - location and #containers to ResourceRequestPBImpl's toString(). Contributed by Sandy Ryza. (Revision 1443702)

        Result = FAILURE
        sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443702
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1338 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1338/ ) YARN-385 . Add missing fields - location and #containers to ResourceRequestPBImpl's toString(). Contributed by Sandy Ryza. (Revision 1443702) Result = FAILURE sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443702 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1310 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1310/)
        YARN-385. Add missing fields - location and #containers to ResourceRequestPBImpl's toString(). Contributed by Sandy Ryza. (Revision 1443702)

        Result = FAILURE
        sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443702
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1310 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1310/ ) YARN-385 . Add missing fields - location and #containers to ResourceRequestPBImpl's toString(). Contributed by Sandy Ryza. (Revision 1443702) Result = FAILURE sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443702 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #121 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/121/)
        YARN-385. Add missing fields - location and #containers to ResourceRequestPBImpl's toString(). Contributed by Sandy Ryza. (Revision 1443702)

        Result = SUCCESS
        sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443702
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #121 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/121/ ) YARN-385 . Add missing fields - location and #containers to ResourceRequestPBImpl's toString(). Contributed by Sandy Ryza. (Revision 1443702) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443702 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3340 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3340/)
        YARN-385. Add missing fields - location and #containers to ResourceRequestPBImpl's toString(). Contributed by Sandy Ryza. (Revision 1443702)

        Result = SUCCESS
        sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443702
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3340 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3340/ ) YARN-385 . Add missing fields - location and #containers to ResourceRequestPBImpl's toString(). Contributed by Sandy Ryza. (Revision 1443702) Result = SUCCESS sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443702 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
        Siddharth Seth made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 2.0.4-beta [ 12324029 ]
        Resolution Fixed [ 1 ]
        Hide
        Siddharth Seth added a comment -

        Committed to trunk and branch-2. Thanks Sandy

        Show
        Siddharth Seth added a comment - Committed to trunk and branch-2. Thanks Sandy
        Hide
        Siddharth Seth added a comment -

        +1. Trivial change, doesn't require a unit test. Committing...

        Show
        Siddharth Seth added a comment - +1. Trivial change, doesn't require a unit test. Committing...
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12568331/YARN-385.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/390//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/390//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568331/YARN-385.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/390//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/390//console This message is automatically generated.
        Sandy Ryza made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Sandy Ryza made changes -
        Field Original Value New Value
        Attachment YARN-385.patch [ 12568331 ]
        Sandy Ryza created issue -

          People

          • Assignee:
            Sandy Ryza
            Reporter:
            Sandy Ryza
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development