Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: yarn
    • Labels:

      Description

      Click on root queue will show the complete applications
      But click on the leaf queue is not filtering the application related to the the clicked queue.

      The regular expression seems to be wrong

      q = '^' + q.substr(q.lastIndexOf(':') + 2) + '$';",
      

      For example
      1. Suppose queue name is b
      them the above expression will try to substr at index 1
      q.lastIndexOf(':') = -1
      -1+2= 1
      which is wrong. its should look at the 0 index.

      2. if queue name is ab.x
      then it will parse it to .x
      but it should be x

      1. scheduler queue issue.png
        259 kB
        Mohammad Shahid Khan
      2. scheduler queue positive behavior.png
        269 kB
        Mohammad Shahid Khan
      3. YARN-3846.patch
        1 kB
        Mohammad Shahid Khan

        Activity

        Hide
        leftnoteasy Wangda Tan added a comment -

        Mohammad Shahid Khan,
        Could you try https://issues.apache.org/jira/browse/YARN-2238 to see if this problem is already resolved?

        Show
        leftnoteasy Wangda Tan added a comment - Mohammad Shahid Khan , Could you try https://issues.apache.org/jira/browse/YARN-2238 to see if this problem is already resolved?
        Hide
        mohdshahidkhan Mohammad Shahid Khan added a comment -

        https://issues.apache.org/jira/browse/YARN-2238 is for different fix.
        The label "Queue :" was added before the queue name in https://issues.apache.org/jira/browse/YARN-3362. After the search was not working and the same has been handled in the https://issues.apache.org/jira/browse/YARN-3707.
        The fix is OK for the for the first child of the queue
        but will not work for the second child
        for example Queue: b.x

        Queue: root
        Queue: a For queue a it will work fine
        Queue: b
        Queue: b.x But for queue x and y this will not work
        Queue: b.y

        *My question: *
        What is the significance of adding Label "Queue:" before the queue name?

        Show
        mohdshahidkhan Mohammad Shahid Khan added a comment - https://issues.apache.org/jira/browse/YARN-2238 is for different fix. The label "Queue :" was added before the queue name in https://issues.apache.org/jira/browse/YARN-3362 . After the search was not working and the same has been handled in the https://issues.apache.org/jira/browse/YARN-3707 . The fix is OK for the for the first child of the queue but will not work for the second child for example Queue: b.x Queue: root Queue: a For queue a it will work fine Queue: b Queue: b.x But for queue x and y this will not work Queue: b.y *My question: * What is the significance of adding Label "Queue:" before the queue name?
        Hide
        mohdshahidkhan Mohammad Shahid Khan added a comment -

        Please confirm whether we have to keep the Label "Queue: " or not.
        Then will submit the patch accordingly.

        Show
        mohdshahidkhan Mohammad Shahid Khan added a comment - Please confirm whether we have to keep the Label "Queue: " or not. Then will submit the patch accordingly.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.1 into 2.7.2.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.1 into 2.7.2.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Mohammad Shahid Khan,
        I tried to reproduce this in 2.7, it should work.

        I created a queue root.b.b1, and submits job to that queue, the filter works.

        And the code in 2.7 doesn't contain change of "Queue:" before queue's name. Could you use branch-2.7 to see if the problem still exists.

        Show
        leftnoteasy Wangda Tan added a comment - Mohammad Shahid Khan , I tried to reproduce this in 2.7, it should work. I created a queue root.b.b1, and submits job to that queue, the filter works. And the code in 2.7 doesn't contain change of "Queue:" before queue's name. Could you use branch-2.7 to see if the problem still exists.
        Hide
        mohdshahidkhan Mohammad Shahid Khan added a comment -

        you are right 2.7 is not having the issue.
        My mistake i have raised in the wrong branch.
        Affected version should be changed.

        The issue is there in trunk.
        The trunk is having the "Queue: " change. This change only has induced the filter issue and even you only have handled https://issues.apache.org/jira/browse/YARN-3707.
        But if we have to keep the lbel "Queue: " the current issue should be fixed in the trunk.

        Show
        mohdshahidkhan Mohammad Shahid Khan added a comment - you are right 2.7 is not having the issue. My mistake i have raised in the wrong branch. Affected version should be changed. The issue is there in trunk. The trunk is having the "Queue: " change. This change only has induced the filter issue and even you only have handled https://issues.apache.org/jira/browse/YARN-3707 . But if we have to keep the lbel "Queue: " the current issue should be fixed in the trunk.
        Hide
        mohdshahidkhan Mohammad Shahid Khan added a comment -

        also in branch-2

        Show
        mohdshahidkhan Mohammad Shahid Khan added a comment - also in branch-2
        Hide
        mohdshahidkhan Mohammad Shahid Khan added a comment -

        have changed the affected and target version.

        Show
        mohdshahidkhan Mohammad Shahid Khan added a comment - have changed the affected and target version.
        Hide
        mohdshahidkhan Mohammad Shahid Khan added a comment -

        Please review attached patch

        Show
        mohdshahidkhan Mohammad Shahid Khan added a comment - Please review attached patch
        Hide
        mohdshahidkhan Mohammad Shahid Khan added a comment -

        Not adding any test case
        Change is only js code.

        Show
        mohdshahidkhan Mohammad Shahid Khan added a comment - Not adding any test case Change is only js code.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 10s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 43s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 47s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 51m 6s Tests passed in hadoop-yarn-server-resourcemanager.
            89m 8s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743307/YARN-3846.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a431ed9
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8529/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8529/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8529/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 10s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 47s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 51m 6s Tests passed in hadoop-yarn-server-resourcemanager.     89m 8s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743307/YARN-3846.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a431ed9 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8529/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8529/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8529/console This message was automatically generated.
        Hide
        jianhe Jian He added a comment -

        patch looks good to me , committing

        Show
        jianhe Jian He added a comment - patch looks good to me , committing
        Hide
        jianhe Jian He added a comment -

        committed to trunk and branch-2, thanks Mohammad Shahid Khan !

        Show
        jianhe Jian He added a comment - committed to trunk and branch-2, thanks Mohammad Shahid Khan !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8229 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8229/)
        YARN-3846. RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8229 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8229/ ) YARN-3846 . RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #270 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/270/)
        YARN-3846. RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #270 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/270/ ) YARN-3846 . RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1000 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1000/)
        YARN-3846. RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1000 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1000/ ) YARN-3846 . RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2197 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2197/)
        YARN-3846. RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2197 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2197/ ) YARN-3846 . RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #259 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/259/)
        YARN-3846. RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #259 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/259/ ) YARN-3846 . RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #267 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/267/)
        YARN-3846. RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #267 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/267/ ) YARN-3846 . RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2216/)
        YARN-3846. RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2216/ ) YARN-3846 . RM Web UI queue filter is not working for sub queue. Contributed by Mohammad Shahid Khan (jianhe: rev 3572ebd738aa5fa8b0906d75fb12cc6cbb991573) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
        Hide
        leftnoteasy Wangda Tan added a comment -

        We should back port this issue to branch-2.6/branch-2.7, list apps for nested queues is broken for branch-2.6/2.6.

        Show
        leftnoteasy Wangda Tan added a comment - We should back port this issue to branch-2.6/branch-2.7, list apps for nested queues is broken for branch-2.6/2.6.

          People

          • Assignee:
            mohdshahidkhan Mohammad Shahid Khan
            Reporter:
            mohdshahidkhan Mohammad Shahid Khan
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development