Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3780

Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition to avoid unnecessary NodeResourceUpdateSchedulerEvent.
      The current code use != to compare Resource totalCapability, which will compare reference not the real value in Resource. So we should use equals to compare Resource.

        Activity

        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Makse sense,
        +1 lgtm (non-binding)

        Show
        rohithsharma Rohith Sharma K S added a comment - Makse sense, +1 lgtm (non-binding)
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 7s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 49s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 50m 18s Tests passed in hadoop-yarn-server-resourcemanager.
            88m 25s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738285/YARN-3780.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a6cb489
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8213/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8213/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8213/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 49s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 50m 18s Tests passed in hadoop-yarn-server-resourcemanager.     88m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738285/YARN-3780.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a6cb489 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8213/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8213/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8213/console This message was automatically generated.
        Hide
        devaraj.k Devaraj K added a comment -

        +1, Looks good to me, will commit it shortly.

        Show
        devaraj.k Devaraj K added a comment - +1, Looks good to me, will commit it shortly.
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks zhihai xu for the patch and Rohith Sharma K S for review.

        Committed to trunk and branch-2.

        Show
        devaraj.k Devaraj K added a comment - Thanks zhihai xu for the patch and Rohith Sharma K S for review. Committed to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7986 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7986/)
        YARN-3780. Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7986 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7986/ ) YARN-3780 . Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/222/)
        YARN-3780. Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/222/ ) YARN-3780 . Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #952 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/952/)
        YARN-3780. Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #952 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/952/ ) YARN-3780 . Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2150 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2150/)
        YARN-3780. Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2150 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2150/ ) YARN-3780 . Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/211/)
        YARN-3780. Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/211/ ) YARN-3780 . Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2168 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2168/)
        YARN-3780. Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2168 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2168/ ) YARN-3780 . Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/220/)
        YARN-3780. Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/220/ ) YARN-3780 . Should use equals when compare Resource in (devaraj: rev c7ee6c151c5771043a6de3b8a951cea13f59dd7b) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        zxu zhihai xu added a comment -

        thanks Rohith Sharma K S for the review and thanks Devaraj K for the review and committing the patch.

        Show
        zxu zhihai xu added a comment - thanks Rohith Sharma K S for the review and thanks Devaraj K for the review and committing the patch.
        Hide
        jlowe Jason Lowe added a comment -

        I committed this to branch-2.7 and branch-2.6 as well.

        Show
        jlowe Jason Lowe added a comment - I committed this to branch-2.7 and branch-2.6 as well.

          People

          • Assignee:
            zxu zhihai xu
            Reporter:
            zxu zhihai xu
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development