[YARN-3765] Fix findbugs the warning in YARN-2928 branch, TimelineMetric

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Assignee: Li Lu
• Reporter: Li Lu
• Created: 03/Jun/15 20:39
• Updated: 03/Jun/15 22:16
• Resolved: 03/Jun/15 22:16

Description

There is one warning about reversing the return value of comparisons in YARN-2928 branch. This is a valid warning. Quoting the findbugs warning message:

RV_NEGATING_RESULT_OF_COMPARETO: Negating the result of compareTo()/compare()

This code negatives the return value of a compareTo or compare method. This is a questionable or bad programming practice, since if the return value is Integer.MIN_VALUE, negating the return value won't negate the sign of the result. You can achieve the same intended result by reversing the order of the operands rather than by negating the results.

Issue Links

• blocks: YARN-3276 Refactor and fix null casting in some map cast for TimelineEntity (old and new) and fix findbug warnings
• duplicates: YARN-3276 Refactor and fix null casting in some map cast for TimelineEntity (old and new) and fix findbug warnings