Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3747

TestLocalDirsHandlerService should delete the created test directory logDir2

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      During a code review of hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java I noted that logDir2 is never deleted while logDir1 is deleted twice. This is not in keeping with the rest of the function and appears to be a bug.

      I will be submitting a patch shortly.

        Activity

        Hide
        grajagandev David Moore added a comment -

        Please review this patch -
        Thank you

        ********************************************************************************
        Copyright 2015 David Moore

        Licensed under the Apache License, Version 2.0 (the "License");
        you may not use this file except in compliance with the License.
        You may obtain a copy of the License at

        http://www.apache.org/licenses/LICENSE-2.0

        Unless required by applicable law or agreed to in writing, software
        distributed under the License is distributed on an "AS IS" BASIS,
        WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        See the License for the specific language governing permissions and
        limitations under the License.

        Show
        grajagandev David Moore added a comment - Please review this patch - Thank you ******************************************************************************** Copyright 2015 David Moore Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 6m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 52s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 29s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 12s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 6m 29s Tests failed in hadoop-yarn-server-nodemanager.
            25m 7s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.nodemanager.TestDockerContainerExecutor



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736555/YARN-3747.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 63e3fee
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8149/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8149/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8149/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 52s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 29s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 12s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 6m 29s Tests failed in hadoop-yarn-server-nodemanager.     25m 7s   Reason Tests Failed unit tests hadoop.yarn.server.nodemanager.TestDockerContainerExecutor Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736555/YARN-3747.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 63e3fee hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8149/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8149/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8149/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 6m 21s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 40s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 36s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 1m 11s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 6m 4s Tests passed in hadoop-yarn-server-nodemanager.
            24m 19s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736555/YARN-3747.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / c7ee6c1
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8215/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8215/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8215/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 21s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 36s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 1m 11s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 4s Tests passed in hadoop-yarn-server-nodemanager.     24m 19s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736555/YARN-3747.patch Optional Tests javac unit findbugs checkstyle git revision trunk / c7ee6c1 hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8215/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8215/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8215/console This message was automatically generated.
        Hide
        devaraj.k Devaraj K added a comment -

        +1, looks good to me, will commit it shortly.

        Show
        devaraj.k Devaraj K added a comment - +1, looks good to me, will commit it shortly.
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks David Moore for your contribution.

        Committed to trunk and branch-2.

        Show
        devaraj.k Devaraj K added a comment - Thanks David Moore for your contribution. Committed to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7987 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7987/)
        YARN-3747. TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7987 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7987/ ) YARN-3747 . TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/222/)
        YARN-3747. TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/222/ ) YARN-3747 . TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #952 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/952/)
        YARN-3747. TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #952 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/952/ ) YARN-3747 . TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2150 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2150/)
        YARN-3747. TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2150 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2150/ ) YARN-3747 . TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/211/)
        YARN-3747. TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/211/ ) YARN-3747 . TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2168 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2168/)
        YARN-3747. TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2168 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2168/ ) YARN-3747 . TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/220/)
        YARN-3747. TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/220/ ) YARN-3747 . TestLocalDirsHandlerService should delete the created test (devaraj: rev 126321eded7dc38c1eef2cfde9365404c924a5cb) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLocalDirsHandlerService.java

          People

          • Assignee:
            grajagandev David Moore
            Reporter:
            grajagandev David Moore
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development