Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3732

Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Interface classes has been changed to Abstract class to maintain consistency across all other protos.

      Description

      All the other protocol record classes are abstract classes. Change NodeHeartbeatResponse.java and RegisterNodeManagerResponse.java as abstract classes to make it consistent with other protocol record classes.

      1. YARN-3732.patch
        20 kB
        Devaraj K
      2. YARN-3732-1.patch
        20 kB
        Devaraj K
      3. YARN-3732-2.patch
        12 kB
        Devaraj K

        Activity

        Hide
        devaraj.k Devaraj K added a comment -

        Attaching a patch to fix this issue, and also it fixes the check-style issues in RegisterNodeManagerResponsePBImpl and NodeHeartbeatResponsePBImpl.

        Show
        devaraj.k Devaraj K added a comment - Attaching a patch to fix this issue, and also it fixes the check-style issues in RegisterNodeManagerResponsePBImpl and NodeHeartbeatResponsePBImpl.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 59s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 4s There were no new javac warning messages.
        +1 javadoc 9m 50s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 33s There were no new checkstyle issues.
        -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 0m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.
            37m 18s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735838/YARN-3732.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7e509f5
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8112/artifact/patchprocess/whitespace.txt
        hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8112/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8112/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8112/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 4s There were no new javac warning messages. +1 javadoc 9m 50s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 33s There were no new checkstyle issues. -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 0m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.     37m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735838/YARN-3732.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7e509f5 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8112/artifact/patchprocess/whitespace.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8112/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8112/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8112/console This message was automatically generated.
        Hide
        devaraj.k Devaraj K added a comment -

        I didn't get these whitespace errors locally for previous patch, uploading a new patch with whitespaces fix.

        Show
        devaraj.k Devaraj K added a comment - I didn't get these whitespace errors locally for previous patch, uploading a new patch with whitespaces fix.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 46s There were no new javac warning messages.
        +1 javadoc 9m 57s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 30s There were no new checkstyle issues.
        +1 whitespace 0m 2s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 0m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.
            37m 11s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735852/YARN-3732-1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7e509f5
        hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8113/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8113/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8113/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 9m 57s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 30s There were no new checkstyle issues. +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.     37m 11s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735852/YARN-3732-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7e509f5 hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8113/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8113/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8113/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1 for changing it to abstract. Cancelling patch as it was one year old. Devaraj K would you rebase the patch?

        Show
        rohithsharma Rohith Sharma K S added a comment - +1 for changing it to abstract. Cancelling patch as it was one year old. Devaraj K would you rebase the patch?
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        One risk I see is rolling upgrade might fail, so I would prefer to go for trunk.

        Show
        rohithsharma Rohith Sharma K S added a comment - One risk I see is rolling upgrade might fail, so I would prefer to go for trunk.
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Rohith Sharma K S for checking this, will update the patch for the trunk.

        Show
        devaraj.k Devaraj K added a comment - Thanks Rohith Sharma K S for checking this, will update the patch for the trunk.
        Hide
        devaraj.k Devaraj K added a comment -

        Updated the patch against trunk.

        Show
        devaraj.k Devaraj K added a comment - Updated the patch against trunk.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 57s trunk passed
        +1 compile 0m 21s trunk passed
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 22s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 40s trunk passed
        +1 javadoc 0m 17s trunk passed
        +1 mvninstall 0m 21s the patch passed
        +1 compile 0m 20s the patch passed
        +1 javac 0m 20s the patch passed
        +1 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 0 new + 34 unchanged - 13 fixed = 34 total (was 47)
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 49s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 0m 28s hadoop-yarn-server-common in the patch passed.
        -1 asflicense 15m 5s The patch generated 4 ASF License warnings.
        29m 39s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-3732
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835704/YARN-3732-2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f16cbb7889e5 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 28660f5
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13620/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/13620/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13620/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 57s trunk passed +1 compile 0m 21s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 40s trunk passed +1 javadoc 0m 17s trunk passed +1 mvninstall 0m 21s the patch passed +1 compile 0m 20s the patch passed +1 javac 0m 20s the patch passed +1 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 0 new + 34 unchanged - 13 fixed = 34 total (was 47) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 49s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 28s hadoop-yarn-server-common in the patch passed. -1 asflicense 15m 5s The patch generated 4 ASF License warnings. 29m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-3732 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835704/YARN-3732-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f16cbb7889e5 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28660f5 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13620/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/13620/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/13620/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        devaraj.k Devaraj K added a comment -

        ASF License warnings are not related to the patch.

        Show
        devaraj.k Devaraj K added a comment - ASF License warnings are not related to the patch.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committed to trunk.. thanks Devaraj K for contributions.

        Show
        rohithsharma Rohith Sharma K S added a comment - committed to trunk.. thanks Devaraj K for contributions.
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Rohith Sharma K S for the review and commit.

        Show
        devaraj.k Devaraj K added a comment - Thanks Rohith Sharma K S for the review and commit.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10742 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10742/)
        YARN-3732. Change NodeHeartbeatResponse.java and (rohithsharmaks: rev 9d0c2ad5a5e3a93c8c48f66ab9b21756d42b645a)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RegisterNodeManagerResponse.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/NodeHeartbeatResponse.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/RegisterNodeManagerResponsePBImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10742 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10742/ ) YARN-3732 . Change NodeHeartbeatResponse.java and (rohithsharmaks: rev 9d0c2ad5a5e3a93c8c48f66ab9b21756d42b645a) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RegisterNodeManagerResponse.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/NodeHeartbeatResponse.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/RegisterNodeManagerResponsePBImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java

          People

          • Assignee:
            devaraj.k Devaraj K
            Reporter:
            devaraj.k Devaraj K
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development