Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3701

Isolating the error of generating a single app report when getting all apps from generic history service

    Details

    • Target Version/s:

      Description

      Nowadays, if some error of generating a single app report when getting the application list from generic history service, it will throw the exception. Therefore, even if it just 1 out of 100 apps has something wrong, the whole app list is screwed. The worst impact is making the default page (app list) of GHS web UI crash, wile REST API /applicationhistory/apps will also break.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2152 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2152/)
          YARN-3701. Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2152 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2152/ ) YARN-3701 . Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #204 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/204/)
          YARN-3701. Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #204 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/204/ ) YARN-3701 . Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/194/)
          YARN-3701. Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/194/ ) YARN-3701 . Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2134 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2134/)
          YARN-3701. Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2134 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2134/ ) YARN-3701 . Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #936 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/936/)
          YARN-3701. Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #936 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/936/ ) YARN-3701 . Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #205 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/205/)
          YARN-3701. Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #205 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/205/ ) YARN-3701 . Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7896 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7896/)
          YARN-3701. Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7896 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7896/ ) YARN-3701 . Isolating the error of generating a single app report when (xgong: rev 455b3acf0e82b214e06bd7b538968252945cd3c4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
          Hide
          xgong Xuan Gong added a comment -

          Committed into trunk/branch-2/branch-2.7. Thanks, zhijie

          Show
          xgong Xuan Gong added a comment - Committed into trunk/branch-2/branch-2.7. Thanks, zhijie
          Hide
          xgong Xuan Gong added a comment -

          Make sense. For getAttempts and get Containers, probably, instead of throwing the exception, we could create a blank page and say "the attempt/container does not exist". We could do it separately. The patch for this ticket is good enough.

          +1. Will commit shortly

          Show
          xgong Xuan Gong added a comment - Make sense. For getAttempts and get Containers, probably, instead of throwing the exception, we could create a blank page and say "the attempt/container does not exist". We could do it separately. The patch for this ticket is good enough. +1. Will commit shortly
          Hide
          zjshen Zhijie Shen added a comment -

          Can we do the same thing for getAppAttempts and getContainers ?

          That's a good question. It depends on the isolation granularity. My opinion is that we set the isolation at the app level, such that app1's error doesn't affect that I access app2, app3 and so on. But anything error inside app1, such as corruption of one container and one attempt, should let user know. Thoughts?

          Show
          zjshen Zhijie Shen added a comment - Can we do the same thing for getAppAttempts and getContainers ? That's a good question. It depends on the isolation granularity. My opinion is that we set the isolation at the app level, such that app1's error doesn't affect that I access app2, app3 and so on. But anything error inside app1, such as corruption of one container and one attempt, should let user know. Thoughts?
          Hide
          xgong Xuan Gong added a comment -

          Thanks for working this. Zhijie Shen.
          The patch looks good over.
          One comment: Can we do the same thing for getAppAttempts and getContainers ?

          Show
          xgong Xuan Gong added a comment - Thanks for working this. Zhijie Shen . The patch looks good over. One comment: Can we do the same thing for getAppAttempts and getContainers ?
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 8s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 47s There were no new javac warning messages.
          +1 javadoc 9m 53s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 31s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 0m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 3m 6s Tests passed in hadoop-yarn-server-applicationhistoryservice.
              39m 53s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12734673/YARN-3701.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 53fafcf
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8051/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8051/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8051/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 8s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 9m 53s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 31s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 3m 6s Tests passed in hadoop-yarn-server-applicationhistoryservice.     39m 53s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734673/YARN-3701.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 53fafcf hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8051/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8051/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8051/console This message was automatically generated.
          Hide
          zjshen Zhijie Shen added a comment -

          Create a patch to swallow the exception on generating the individual app report. In addition, fix another problem in this patch too: getting rid of doing access check multiple times when generating an app report and getting AM container.

          Show
          zjshen Zhijie Shen added a comment - Create a patch to swallow the exception on generating the individual app report. In addition, fix another problem in this patch too: getting rid of doing access check multiple times when generating an app report and getting AM container.

            People

            • Assignee:
              zjshen Zhijie Shen
              Reporter:
              zjshen Zhijie Shen
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development