Details

    • Type: Sub-task
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      The UIs provided by each RM, provide a correct "local" view of what is running in a sub-cluster. In the context of federation we need new
      UIs that can track load, jobs, users across sub-clusters.

      1. YARN-3661-000.patch
        55 kB
        Íñigo Goiri
      2. YARN-3661-001.patch
        53 kB
        Íñigo Goiri
      3. YARN-3661-002.patch
        53 kB
        Íñigo Goiri
      4. YARN-3661-003.patch
        51 kB
        Íñigo Goiri
      5. YARN-3661-004.patch
        43 kB
        Íñigo Goiri
      6. YARN-3661-005.patch
        47 kB
        Íñigo Goiri
      7. YARN-3661-006.patch
        47 kB
        Íñigo Goiri
      8. YARN-3661-007.patch
        49 kB
        Íñigo Goiri
      9. YARN-3661-008.patch
        44 kB
        Íñigo Goiri
      10. YARN-3661-009.patch
        43 kB
        Íñigo Goiri
      11. YARN-3661-010.patch
        43 kB
        Íñigo Goiri
      12. YARN-3661-011.patch
        43 kB
        Íñigo Goiri
      13. YARN-3661-012.patch
        43 kB
        Íñigo Goiri
      14. YARN-3661-013.patch
        101 kB
        Íñigo Goiri
      15. YARN-3661-014.patch
        67 kB
        Íñigo Goiri
      16. YARN-3661-015.patch
        44 kB
        Íñigo Goiri
      17. YARN-3661-branch-2.001.patch
        44 kB
        Íñigo Goiri
      18. YARN-3661-branch-2.002.patch
        46 kB
        Íñigo Goiri

        Issue Links

          Activity

          Hide
          subru Subru Krishnan added a comment -

          Íñigo Goiri, thanks for backporting the patch and Giovanni Matteo Fumarola for the guidance.

          Is this fix part of YARN-7276 or is it only for branch-2? If it's the latter, fine to include it here.

          Show
          subru Subru Krishnan added a comment - Íñigo Goiri , thanks for backporting the patch and Giovanni Matteo Fumarola for the guidance. Is this fix part of YARN-7276 or is it only for branch-2? If it's the latter, fine to include it here.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Thank you Giovanni Matteo Fumarola, your guidance showed me the way for successful unit tests.
          My guess is that the backport to branch-2 had some issues and this was introduced there.
          I add the fix in 002 in TestRouterWebServicesREST.
          Carlo Curino, Subru Krishnan, is it fine to include this fix here?

          Show
          elgoiri Íñigo Goiri added a comment - Thank you Giovanni Matteo Fumarola , your guidance showed me the way for successful unit tests. My guess is that the backport to branch-2 had some issues and this was introduced there. I add the fix in 002 in TestRouterWebServicesREST . Carlo Curino , Subru Krishnan , is it fine to include this fix here?
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Íñigo Goiri for the patch.

          Please fix the STATUS_BADREQUEST with NO_CONTENT. In trunk there are more check fro Scheduler logs call. These checks are not in branch-2 and Yarn RM returns NO_CONTENT.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Íñigo Goiri for the patch. Please fix the STATUS_BADREQUEST with NO_CONTENT . In trunk there are more check fro Scheduler logs call. These checks are not in branch-2 and Yarn RM returns NO_CONTENT .
          Hide
          elgoiri Íñigo Goiri added a comment - - edited

          Giovanni Matteo Fumarola, what is the situation with the timeout in branch-2?
          I'm also getting the error with:

              ClientResponse response =
                  performCall(RMWSConsts.RM_WEB_SERVICE_PATH + RMWSConsts.SCHEDULER_LOGS,
                      RMWSConsts.TIME, "1", null, HTTPMethods.POST);
          

          As it does not return STATUS_BADREQUEST.

          Not sure this has anything to do with the patch.
          Do you mind double checking?

          The test seems to fail in branch-2 too.

          Show
          elgoiri Íñigo Goiri added a comment - - edited Giovanni Matteo Fumarola , what is the situation with the timeout in branch-2? I'm also getting the error with: ClientResponse response = performCall(RMWSConsts.RM_WEB_SERVICE_PATH + RMWSConsts.SCHEDULER_LOGS, RMWSConsts.TIME, "1" , null , HTTPMethods.POST); As it does not return STATUS_BADREQUEST . Not sure this has anything to do with the patch. Do you mind double checking? The test seems to fail in branch-2 too.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 51s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-2 Compile Tests
          0 mvndep 0m 32s Maven dependency ordering for branch
          +1 mvninstall 8m 9s branch-2 passed
          +1 compile 2m 44s branch-2 passed
          +1 checkstyle 0m 48s branch-2 passed
          +1 mvnsite 0m 41s branch-2 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 37s branch-2 passed
          +1 javadoc 0m 28s branch-2 passed
                Patch Compile Tests
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 0m 28s the patch passed
          +1 compile 2m 42s the patch passed
          +1 javac 2m 42s the patch passed
          +1 checkstyle 0m 46s the patch passed
          +1 mvnsite 0m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 48s the patch passed
          +1 javadoc 0m 26s the patch passed
                Other Tests
          -1 unit 1m 8s hadoop-yarn-server-router in the patch failed.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          42m 11s



          Reason Tests
          Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:eaf5c66
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891138/YARN-3661-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 68b4c4ab53cb 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 6cdc677
          Default Java 1.7.0_151
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17828/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17828/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17828/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 51s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-2 Compile Tests 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 8m 9s branch-2 passed +1 compile 2m 44s branch-2 passed +1 checkstyle 0m 48s branch-2 passed +1 mvnsite 0m 41s branch-2 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 37s branch-2 passed +1 javadoc 0m 28s branch-2 passed       Patch Compile Tests 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 0m 28s the patch passed +1 compile 2m 42s the patch passed +1 javac 2m 42s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvnsite 0m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 48s the patch passed +1 javadoc 0m 26s the patch passed       Other Tests -1 unit 1m 8s hadoop-yarn-server-router in the patch failed. +1 unit 0m 9s hadoop-yarn-site in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 42m 11s Reason Tests Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST Subsystem Report/Notes Docker Image:yetus/hadoop:eaf5c66 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891138/YARN-3661-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 68b4c4ab53cb 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 6cdc677 Default Java 1.7.0_151 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/17828/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17828/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17828/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 17m 21s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-2 Compile Tests
          0 mvndep 0m 28s Maven dependency ordering for branch
          +1 mvninstall 7m 33s branch-2 passed
          +1 compile 2m 32s branch-2 passed
          +1 checkstyle 0m 42s branch-2 passed
          +1 mvnsite 0m 40s branch-2 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 34s branch-2 passed
          +1 javadoc 0m 25s branch-2 passed
                Patch Compile Tests
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 0m 29s the patch passed
          +1 compile 2m 32s the patch passed
          +1 javac 2m 32s the patch passed
          +1 checkstyle 0m 43s the patch passed
          +1 mvnsite 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 43s the patch passed
          +1 javadoc 0m 24s the patch passed
                Other Tests
          -1 unit 1m 1s hadoop-yarn-server-router in the patch failed.
          +1 unit 0m 10s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          44m 47s



          Reason Tests
          Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:eaf5c66
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891138/YARN-3661-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux b69ffa531afe 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 6cdc677
          Default Java 1.7.0_151
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17827/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17827/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 17m 21s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-2 Compile Tests 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 7m 33s branch-2 passed +1 compile 2m 32s branch-2 passed +1 checkstyle 0m 42s branch-2 passed +1 mvnsite 0m 40s branch-2 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 34s branch-2 passed +1 javadoc 0m 25s branch-2 passed       Patch Compile Tests 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 0m 29s the patch passed +1 compile 2m 32s the patch passed +1 javac 2m 32s the patch passed +1 checkstyle 0m 43s the patch passed +1 mvnsite 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 43s the patch passed +1 javadoc 0m 24s the patch passed       Other Tests -1 unit 1m 1s hadoop-yarn-server-router in the patch failed. +1 unit 0m 10s hadoop-yarn-site in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 44m 47s Reason Tests Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST Subsystem Report/Notes Docker Image:yetus/hadoop:eaf5c66 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891138/YARN-3661-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux b69ffa531afe 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 6cdc677 Default Java 1.7.0_151 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/17827/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17827/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17827/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13004 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13004/)
          YARN-3661. Basic Federation UI. (Contributed by Inigo Goiri via curino) (carlo curino: rev ceca9694f9a0c78d07cab2c382036f175183e67b)

          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NavBlock.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationBlock.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodesBlock.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterView.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebApp.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AppsBlock.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterController.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodesPage.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AboutPage.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AppsPage.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AboutBlock.java
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationPage.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13004 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13004/ ) YARN-3661 . Basic Federation UI. (Contributed by Inigo Goiri via curino) (carlo curino: rev ceca9694f9a0c78d07cab2c382036f175183e67b) (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NavBlock.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationBlock.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodesBlock.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterView.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebApp.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AppsBlock.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterController.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodesPage.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AboutPage.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AppsPage.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AboutBlock.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationPage.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md
          Hide
          curino Carlo Curino added a comment -

          Thanks Íñigo Goiri and Giovanni Matteo Fumarola for code and reviews! Thanks Subru Krishnan for reviews as well.
          LGTM, I committed this to trunk.

          Please provide an updated patch for branch-2 and re-open the issue if you want this version of the UI in branch-2 as well.

          Show
          curino Carlo Curino added a comment - Thanks Íñigo Goiri and Giovanni Matteo Fumarola for code and reviews! Thanks Subru Krishnan for reviews as well. LGTM, I committed this to trunk. Please provide an updated patch for branch-2 and re-open the issue if you want this version of the UI in branch-2 as well.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Íñigo Goiri for the patch.
          LGTM +1.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Íñigo Goiri for the patch. LGTM +1.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          0 mvndep 0m 40s Maven dependency ordering for branch
          +1 mvninstall 12m 29s trunk passed
          +1 compile 9m 18s trunk passed
          +1 checkstyle 0m 50s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 shadedclient 9m 48s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 28s trunk passed
                Patch Compile Tests
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 24s the patch passed
          +1 compile 5m 39s the patch passed
          +1 javac 5m 39s the patch passed
          +1 checkstyle 0m 51s the patch passed
          +1 mvnsite 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 9m 4s patch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 35s the patch passed
          +1 javadoc 0m 28s the patch passed
                Other Tests
          +1 unit 1m 3s hadoop-yarn-server-router in the patch passed.
          +1 unit 0m 11s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          59m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889817/YARN-3661-015.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux e2f2b91da49e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 66c4171
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17720/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17720/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests 0 mvndep 0m 40s Maven dependency ordering for branch +1 mvninstall 12m 29s trunk passed +1 compile 9m 18s trunk passed +1 checkstyle 0m 50s trunk passed +1 mvnsite 0m 37s trunk passed +1 shadedclient 9m 48s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 27s trunk passed +1 javadoc 0m 28s trunk passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 24s the patch passed +1 compile 5m 39s the patch passed +1 javac 5m 39s the patch passed +1 checkstyle 0m 51s the patch passed +1 mvnsite 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 9m 4s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 35s the patch passed +1 javadoc 0m 28s the patch passed       Other Tests +1 unit 1m 3s hadoop-yarn-server-router in the patch passed. +1 unit 0m 11s hadoop-yarn-site in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 59m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889817/YARN-3661-015.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux e2f2b91da49e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 66c4171 Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17720/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17720/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 44s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 42s Maven dependency ordering for branch
          +1 mvninstall 13m 5s trunk passed
          +1 compile 9m 6s trunk passed
          +1 checkstyle 0m 48s trunk passed
          +1 mvnsite 0m 35s trunk passed
          +1 shadedclient 9m 58s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 26s trunk passed
                Patch Compile Tests
          0 mvndep 0m 10s Maven dependency ordering for patch
          -1 mvninstall 0m 13s hadoop-yarn-server-router in the patch failed.
          -1 compile 2m 41s hadoop-yarn in the patch failed.
          -1 javac 2m 41s hadoop-yarn in the patch failed.
          -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0)
          -1 mvnsite 0m 17s hadoop-yarn-server-router in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 9m 9s patch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          -1 findbugs 0m 14s hadoop-yarn-server-router in the patch failed.
          +1 javadoc 0m 20s the patch passed
                Other Tests
          -1 unit 0m 16s hadoop-yarn-server-router in the patch failed.
          +1 unit 0m 8s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          55m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889804/YARN-3661-014.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux a3692ab313e6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ec2ae30
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17718/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17718/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 44s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 42s Maven dependency ordering for branch +1 mvninstall 13m 5s trunk passed +1 compile 9m 6s trunk passed +1 checkstyle 0m 48s trunk passed +1 mvnsite 0m 35s trunk passed +1 shadedclient 9m 58s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 27s trunk passed +1 javadoc 0m 26s trunk passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch -1 mvninstall 0m 13s hadoop-yarn-server-router in the patch failed. -1 compile 2m 41s hadoop-yarn in the patch failed. -1 javac 2m 41s hadoop-yarn in the patch failed. -0 checkstyle 0m 44s hadoop-yarn-project/hadoop-yarn: The patch generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0) -1 mvnsite 0m 17s hadoop-yarn-server-router in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 9m 9s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site -1 findbugs 0m 14s hadoop-yarn-server-router in the patch failed. +1 javadoc 0m 20s the patch passed       Other Tests -1 unit 0m 16s hadoop-yarn-server-router in the patch failed. +1 unit 0m 8s hadoop-yarn-site in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 55m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889804/YARN-3661-014.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux a3692ab313e6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ec2ae30 Default Java 1.8.0_144 findbugs v3.1.0-RC1 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17718/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17718/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17718/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 49s Maven dependency ordering for branch
          +1 mvninstall 14m 10s trunk passed
          +1 compile 10m 4s trunk passed
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 shadedclient 11m 55s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 32s trunk passed
          +1 javadoc 0m 38s trunk passed
                Patch Compile Tests
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 28s the patch passed
          +1 compile 6m 14s the patch passed
          +1 javac 6m 14s the patch passed
          -0 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 31 new + 4 unchanged - 0 fixed = 35 total (was 4)
          +1 mvnsite 0m 46s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 10m 13s patch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 40s the patch passed
          -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
                Other Tests
          +1 unit 1m 10s hadoop-yarn-server-router in the patch passed.
          +1 unit 0m 17s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          67m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889795/YARN-3661-013.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 7f01e4e03b3e 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ec2ae30
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17717/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17717/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17717/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17717/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 49s Maven dependency ordering for branch +1 mvninstall 14m 10s trunk passed +1 compile 10m 4s trunk passed +1 checkstyle 1m 5s trunk passed +1 mvnsite 0m 51s trunk passed +1 shadedclient 11m 55s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 32s trunk passed +1 javadoc 0m 38s trunk passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 28s the patch passed +1 compile 6m 14s the patch passed +1 javac 6m 14s the patch passed -0 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 31 new + 4 unchanged - 0 fixed = 35 total (was 4) +1 mvnsite 0m 46s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 10m 13s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 40s the patch passed -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)       Other Tests +1 unit 1m 10s hadoop-yarn-server-router in the patch passed. +1 unit 0m 17s hadoop-yarn-site in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 67m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12889795/YARN-3661-013.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 7f01e4e03b3e 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ec2ae30 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17717/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17717/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17717/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17717/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Thanks Subru Krishnan, I created YARN-7276 to track that part.
          I'll remove those from this patch.

          Show
          elgoiri Íñigo Goiri added a comment - Thanks Subru Krishnan , I created YARN-7276 to track that part. I'll remove those from this patch.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Íñigo Goiri for the updated patch. Can you work with Giovanni Matteo Fumarola and open a separate bug for the Federation REST interface as it needs to be tracked seperately?

          Show
          subru Subru Krishnan added a comment - Thanks Íñigo Goiri for the updated patch. Can you work with Giovanni Matteo Fumarola and open a separate bug for the Federation REST interface as it needs to be tracked seperately?
          Hide
          elgoiri Íñigo Goiri added a comment -

          Tackled comments but I had to fix a couple things in the REST interface.
          Not sure if you guys want to open a new JIRA for that.

          Show
          elgoiri Íñigo Goiri added a comment - Tackled comments but I had to fix a couple things in the REST interface. Not sure if you guys want to open a new JIRA for that.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          0 mvndep 0m 52s Maven dependency ordering for branch
          +1 mvninstall 14m 30s trunk passed
          +1 compile 11m 55s trunk passed
          +1 checkstyle 1m 12s trunk passed
          +1 mvnsite 1m 0s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 47s trunk passed
          +1 javadoc 0m 47s trunk passed
                Patch Compile Tests
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 0m 30s the patch passed
          +1 compile 8m 23s the patch passed
          +1 javac 8m 23s the patch passed
          +1 checkstyle 1m 3s the patch passed
          +1 mvnsite 0m 52s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 47s the patch passed
          +1 javadoc 0m 45s the patch passed
                Other Tests
          +1 unit 1m 20s hadoop-yarn-server-router in the patch passed.
          +1 unit 0m 18s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          55m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888530/YARN-3661-012.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4b1041059459 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 08fca50
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17592/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17592/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests 0 mvndep 0m 52s Maven dependency ordering for branch +1 mvninstall 14m 30s trunk passed +1 compile 11m 55s trunk passed +1 checkstyle 1m 12s trunk passed +1 mvnsite 1m 0s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 47s trunk passed +1 javadoc 0m 47s trunk passed       Patch Compile Tests 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 0m 30s the patch passed +1 compile 8m 23s the patch passed +1 javac 8m 23s the patch passed +1 checkstyle 1m 3s the patch passed +1 mvnsite 0m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 47s the patch passed +1 javadoc 0m 45s the patch passed       Other Tests +1 unit 1m 20s hadoop-yarn-server-router in the patch passed. +1 unit 0m 18s hadoop-yarn-site in the patch passed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 55m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888530/YARN-3661-012.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4b1041059459 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 08fca50 Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17592/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17592/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Íñigo Goiri for the patch. Each test in TestRouterWebServicesREST has a timeout of 1 second, the failed test did run in more than 1 second. I will open a Jira to increase the timeouts.

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Íñigo Goiri for the patch. Each test in TestRouterWebServicesREST has a timeout of 1 second, the failed test did run in more than 1 second. I will open a Jira to increase the timeouts.
          Hide
          elgoiri Íñigo Goiri added a comment -
          1. YETUS came somewhat clean, Giovanni Matteo Fumarola, does the test seem related?
          2. I fixed the footnote.
          3. Regarding the state, that comes from the CSS, so if you have a different version, it won't work. I'll try to test in branch-2.
          Show
          elgoiri Íñigo Goiri added a comment - YETUS came somewhat clean, Giovanni Matteo Fumarola , does the test seem related? I fixed the footnote. Regarding the state, that comes from the CSS, so if you have a different version, it won't work. I'll try to test in branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          0 mvndep 0m 24s Maven dependency ordering for branch
          +1 mvninstall 12m 41s trunk passed
          +1 compile 8m 51s trunk passed
          +1 checkstyle 0m 56s trunk passed
          +1 mvnsite 0m 51s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 33s trunk passed
          +1 javadoc 0m 43s trunk passed
                Patch Compile Tests
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 27s the patch passed
          +1 compile 5m 41s the patch passed
          +1 javac 5m 41s the patch passed
          +1 checkstyle 0m 55s the patch passed
          +1 mvnsite 0m 50s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 42s the patch passed
          +1 javadoc 0m 41s the patch passed
                Other Tests
          -1 unit 1m 11s hadoop-yarn-server-router in the patch failed.
          +1 unit 0m 18s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          45m 52s



          Reason Tests
          Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888412/YARN-3661-011.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b8ada91ea802 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bfd1a72
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17583/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17583/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17583/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 12m 41s trunk passed +1 compile 8m 51s trunk passed +1 checkstyle 0m 56s trunk passed +1 mvnsite 0m 51s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 33s trunk passed +1 javadoc 0m 43s trunk passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 27s the patch passed +1 compile 5m 41s the patch passed +1 javac 5m 41s the patch passed +1 checkstyle 0m 55s the patch passed +1 mvnsite 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 42s the patch passed +1 javadoc 0m 41s the patch passed       Other Tests -1 unit 1m 11s hadoop-yarn-server-router in the patch failed. +1 unit 0m 18s hadoop-yarn-site in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 45m 52s Reason Tests Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888412/YARN-3661-011.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b8ada91ea802 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bfd1a72 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/17583/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17583/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17583/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          curino Carlo Curino added a comment - - edited

          Thanks Íñigo Goiri

          +1 pending:

          1. YETUS,
          2. One "*" missing for Application Submitted
          3. application "STATE" which in my test cluster still shows up as scrambled
          Show
          curino Carlo Curino added a comment - - edited Thanks Íñigo Goiri +1 pending: YETUS, One "*" missing for Application Submitted application "STATE" which in my test cluster still shows up as scrambled
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          0 mvndep 0m 51s Maven dependency ordering for branch
          +1 mvninstall 14m 34s trunk passed
          +1 compile 12m 29s trunk passed
          +1 checkstyle 1m 14s trunk passed
          +1 mvnsite 0m 57s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 43s trunk passed
          +1 javadoc 0m 38s trunk passed
                Patch Compile Tests
          0 mvndep 0m 12s Maven dependency ordering for patch
          -1 mvninstall 0m 18s hadoop-yarn-server-router in the patch failed.
          -1 compile 3m 57s hadoop-yarn in the patch failed.
          -1 javac 3m 57s hadoop-yarn in the patch failed.
          +1 checkstyle 1m 12s the patch passed
          -1 mvnsite 0m 22s hadoop-yarn-server-router in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          -1 findbugs 0m 18s hadoop-yarn-server-router in the patch failed.
          -1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
                Other Tests
          -1 unit 0m 18s hadoop-yarn-server-router in the patch failed.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          48m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888405/YARN-3661-010.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 919c5c2ba5bf 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bfd1a72
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17582/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17582/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests 0 mvndep 0m 51s Maven dependency ordering for branch +1 mvninstall 14m 34s trunk passed +1 compile 12m 29s trunk passed +1 checkstyle 1m 14s trunk passed +1 mvnsite 0m 57s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 43s trunk passed +1 javadoc 0m 38s trunk passed       Patch Compile Tests 0 mvndep 0m 12s Maven dependency ordering for patch -1 mvninstall 0m 18s hadoop-yarn-server-router in the patch failed. -1 compile 3m 57s hadoop-yarn in the patch failed. -1 javac 3m 57s hadoop-yarn in the patch failed. +1 checkstyle 1m 12s the patch passed -1 mvnsite 0m 22s hadoop-yarn-server-router in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site -1 findbugs 0m 18s hadoop-yarn-server-router in the patch failed. -1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)       Other Tests -1 unit 0m 18s hadoop-yarn-server-router in the patch failed. +1 unit 0m 9s hadoop-yarn-site in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 48m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888405/YARN-3661-010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 919c5c2ba5bf 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bfd1a72 Default Java 1.8.0_144 findbugs v3.1.0-RC1 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17582/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17582/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17582/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Thanks Carlo Curino for the comments. I uploaded a new version of the patch tackling them.

          Show
          elgoiri Íñigo Goiri added a comment - Thanks Carlo Curino for the comments. I uploaded a new version of the patch tackling them.
          Hide
          curino Carlo Curino added a comment -

          Íñigo Goiri and Giovanni Matteo Fumarola for the contribution/reviews. A few more nits trying this in a test cluster:

          1. The columns in "federation" tab for applications could be confusing because their sum would double-count. Please add a * comment that warns the user that the counts are "local" to each RM and should not be added.
          2. For the about page I would put a N/A (until we improve the REST endpoint to support unique app counts)
          3. Links in Application is busted, "State" is busted
          Show
          curino Carlo Curino added a comment - Íñigo Goiri and Giovanni Matteo Fumarola for the contribution/reviews. A few more nits trying this in a test cluster: The columns in "federation" tab for applications could be confusing because their sum would double-count. Please add a * comment that warns the user that the counts are "local" to each RM and should not be added. For the about page I would put a N/A (until we improve the REST endpoint to support unique app counts) Links in Application is busted, "State" is busted
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          0 mvndep 0m 45s Maven dependency ordering for branch
          +1 mvninstall 13m 0s trunk passed
          +1 compile 9m 32s trunk passed
          +1 checkstyle 0m 58s trunk passed
          +1 mvnsite 0m 48s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 33s trunk passed
          +1 javadoc 0m 34s trunk passed
                Patch Compile Tests
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 26s the patch passed
          +1 compile 5m 45s the patch passed
          +1 javac 5m 45s the patch passed
          +1 checkstyle 0m 48s the patch passed
          +1 mvnsite 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 42s the patch passed
          +1 javadoc 0m 40s the patch passed
                Other Tests
          +1 unit 1m 11s hadoop-yarn-server-router in the patch passed.
          +1 unit 0m 18s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          46m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887751/YARN-3661-008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 07c17757c413 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7c73292
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17502/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17502/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 13m 0s trunk passed +1 compile 9m 32s trunk passed +1 checkstyle 0m 58s trunk passed +1 mvnsite 0m 48s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 33s trunk passed +1 javadoc 0m 34s trunk passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 26s the patch passed +1 compile 5m 45s the patch passed +1 javac 5m 45s the patch passed +1 checkstyle 0m 48s the patch passed +1 mvnsite 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 42s the patch passed +1 javadoc 0m 40s the patch passed       Other Tests +1 unit 1m 11s hadoop-yarn-server-router in the patch passed. +1 unit 0m 18s hadoop-yarn-site in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 46m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887751/YARN-3661-008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 07c17757c413 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7c73292 Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17502/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17502/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 9s Maven dependency ordering for branch
          +1 mvninstall 15m 37s trunk passed
          +1 compile 11m 15s trunk passed
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 0m 51s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 36s trunk passed
          +1 javadoc 0m 33s trunk passed
                Patch Compile Tests
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 29s the patch passed
          +1 compile 7m 20s the patch passed
          +1 javac 7m 20s the patch passed
          +1 checkstyle 1m 0s the patch passed
          +1 mvnsite 0m 48s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 51s the patch passed
          +1 javadoc 0m 38s the patch passed
                Other Tests
          -1 unit 1m 23s hadoop-yarn-server-router in the patch failed.
          +1 unit 0m 19s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          53m 39s



          Reason Tests
          Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887381/YARN-3661-007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 4817f51fd65a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2d2d97f
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17478/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17478/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17478/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 1m 9s Maven dependency ordering for branch +1 mvninstall 15m 37s trunk passed +1 compile 11m 15s trunk passed +1 checkstyle 1m 5s trunk passed +1 mvnsite 0m 51s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 36s trunk passed +1 javadoc 0m 33s trunk passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 29s the patch passed +1 compile 7m 20s the patch passed +1 javac 7m 20s the patch passed +1 checkstyle 1m 0s the patch passed +1 mvnsite 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 51s the patch passed +1 javadoc 0m 38s the patch passed       Other Tests -1 unit 1m 23s hadoop-yarn-server-router in the patch failed. +1 unit 0m 19s hadoop-yarn-site in the patch passed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 53m 39s Reason Tests Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887381/YARN-3661-007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 4817f51fd65a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2d2d97f Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/17478/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17478/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17478/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          The code looks good to me. I had an offline meeting with Íñigo Goiri in which he showed the new UI from Router. It has 4 views:

          • The current status of all the SubClusters. If Federation is not enabled, the page is not enabled.
          • The aggregations of all the Metrics.
          • All the applications in the entire Federated cluster.
          • All the nodes in the entire Federated cluster.
          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - The code looks good to me. I had an offline meeting with Íñigo Goiri in which he showed the new UI from Router. It has 4 views: The current status of all the SubClusters. If Federation is not enabled, the page is not enabled. The aggregations of all the Metrics. All the applications in the entire Federated cluster. All the nodes in the entire Federated cluster.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 54s Maven dependency ordering for branch
          +1 mvninstall 16m 34s trunk passed
          +1 compile 10m 49s trunk passed
          +1 checkstyle 1m 1s trunk passed
          +1 mvnsite 0m 47s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 36s trunk passed
          +1 javadoc 0m 36s trunk passed
                Patch Compile Tests
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 27s the patch passed
          +1 compile 6m 53s the patch passed
          +1 javac 6m 53s the patch passed
          +1 checkstyle 1m 2s the patch passed
          +1 mvnsite 0m 46s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 46s the patch passed
          +1 javadoc 0m 36s the patch passed
                Other Tests
          +1 unit 1m 15s hadoop-yarn-server-router in the patch passed.
          +1 unit 0m 15s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          53m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887009/YARN-3661-006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 0c2e10a3e8d3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e0b3c64
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17449/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17449/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 0m 54s Maven dependency ordering for branch +1 mvninstall 16m 34s trunk passed +1 compile 10m 49s trunk passed +1 checkstyle 1m 1s trunk passed +1 mvnsite 0m 47s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 36s trunk passed +1 javadoc 0m 36s trunk passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 27s the patch passed +1 compile 6m 53s the patch passed +1 javac 6m 53s the patch passed +1 checkstyle 1m 2s the patch passed +1 mvnsite 0m 46s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 46s the patch passed +1 javadoc 0m 36s the patch passed       Other Tests +1 unit 1m 15s hadoop-yarn-server-router in the patch passed. +1 unit 0m 15s hadoop-yarn-site in the patch passed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 53m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887009/YARN-3661-006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 0c2e10a3e8d3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e0b3c64 Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17449/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17449/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 39s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 8s Maven dependency ordering for branch
          +1 mvninstall 13m 36s trunk passed
          +1 compile 9m 10s trunk passed
          +1 checkstyle 0m 58s trunk passed
          +1 mvnsite 0m 50s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 35s trunk passed
          +1 javadoc 0m 42s trunk passed
                Patch Compile Tests
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 27s the patch passed
          +1 compile 5m 33s the patch passed
          +1 javac 5m 33s the patch passed
          -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 mvnsite 0m 49s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 0m 41s the patch passed
          +1 javadoc 0m 41s the patch passed
                Other Tests
          -1 unit 1m 13s hadoop-yarn-server-router in the patch failed.
          +1 unit 0m 19s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          48m 19s



          Reason Tests
          Failed junit tests hadoop.yarn.server.router.webapp.TestNodesPage



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886993/YARN-3661-005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 3cd1fd1fdcf7 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 73aed34
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17445/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17445/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17445/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17445/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 39s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 1m 8s Maven dependency ordering for branch +1 mvninstall 13m 36s trunk passed +1 compile 9m 10s trunk passed +1 checkstyle 0m 58s trunk passed +1 mvnsite 0m 50s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 35s trunk passed +1 javadoc 0m 42s trunk passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 27s the patch passed +1 compile 5m 33s the patch passed +1 javac 5m 33s the patch passed -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 mvnsite 0m 49s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 0m 41s the patch passed +1 javadoc 0m 41s the patch passed       Other Tests -1 unit 1m 13s hadoop-yarn-server-router in the patch failed. +1 unit 0m 19s hadoop-yarn-site in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 48m 19s Reason Tests Failed junit tests hadoop.yarn.server.router.webapp.TestNodesPage Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886993/YARN-3661-005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 3cd1fd1fdcf7 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 73aed34 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17445/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17445/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17445/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17445/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 1s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 12m 48s trunk passed
          +1 compile 0m 17s trunk passed
          +1 checkstyle 0m 10s trunk passed
          +1 mvnsite 0m 18s trunk passed
          +1 findbugs 0m 24s trunk passed
          +1 javadoc 0m 12s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 15s the patch passed
          +1 compile 0m 14s the patch passed
          +1 javac 0m 14s the patch passed
          -0 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
          +1 mvnsite 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 30s the patch passed
          +1 javadoc 0m 11s the patch passed
                Other Tests
          +1 unit 0m 59s hadoop-yarn-server-router in the patch passed.
          +1 asflicense 0m 11s The patch does not generate ASF License warnings.
          18m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885959/YARN-3661-004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 91853316091f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3b3be35
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17346/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17346/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17346/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 12m 48s trunk passed +1 compile 0m 17s trunk passed +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 18s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 12s trunk passed       Patch Compile Tests +1 mvninstall 0m 15s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed -0 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) +1 mvnsite 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 0m 59s hadoop-yarn-server-router in the patch passed. +1 asflicense 0m 11s The patch does not generate ASF License warnings. 18m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885959/YARN-3661-004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 91853316091f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3b3be35 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17346/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17346/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router Console output https://builds.apache.org/job/PreCommit-YARN-Build/17346/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 12m 28s trunk passed
          +1 compile 0m 17s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 findbugs 0m 26s trunk passed
          +1 javadoc 0m 14s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 15s the patch passed
          +1 compile 0m 14s the patch passed
          +1 javac 0m 14s the patch passed
          -0 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
          +1 mvnsite 0m 17s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 29s the patch passed
          +1 javadoc 0m 9s the patch passed
                Other Tests
          +1 unit 0m 59s hadoop-yarn-server-router in the patch passed.
          +1 asflicense 0m 11s The patch does not generate ASF License warnings.
          18m 16s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885951/YARN-3661-003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1275b56b066e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b0b535d
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17344/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17344/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17344/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 12m 28s trunk passed +1 compile 0m 17s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 19s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 15s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed -0 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0) +1 mvnsite 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 9s the patch passed       Other Tests +1 unit 0m 59s hadoop-yarn-server-router in the patch passed. +1 asflicense 0m 11s The patch does not generate ASF License warnings. 18m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885951/YARN-3661-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1275b56b066e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b0b535d Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17344/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17344/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router Console output https://builds.apache.org/job/PreCommit-YARN-Build/17344/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 32s trunk passed
          +1 compile 0m 18s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 20s trunk passed
          +1 findbugs 0m 25s trunk passed
          +1 javadoc 0m 13s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 16s the patch passed
          +1 compile 0m 15s the patch passed
          +1 javac 0m 15s the patch passed
          -0 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: The patch generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0)
          +1 mvnsite 0m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 31s the patch passed
          +1 javadoc 0m 11s the patch passed
                Other Tests
          +1 unit 0m 58s hadoop-yarn-server-router in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          20m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883032/YARN-3661-002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9644f74df369 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b6bfb2f
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17053/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17053/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17053/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 32s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 20s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 13s trunk passed       Patch Compile Tests +1 mvninstall 0m 16s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed -0 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: The patch generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) +1 mvnsite 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 0m 58s hadoop-yarn-server-router in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 20m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883032/YARN-3661-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9644f74df369 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b6bfb2f Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17053/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17053/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router Console output https://builds.apache.org/job/PreCommit-YARN-Build/17053/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 14m 37s trunk passed
          +1 compile 14m 48s trunk passed
          +1 checkstyle 2m 0s trunk passed
          +1 mvnsite 1m 59s trunk passed
          +1 findbugs 2m 31s trunk passed
          +1 javadoc 1m 19s trunk passed
                Patch Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 1m 22s the patch passed
          +1 compile 14m 11s the patch passed
          +1 javac 14m 11s the patch passed
          -0 checkstyle 2m 10s root: The patch generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0)
          +1 mvnsite 2m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 8s the patch passed
          -1 javadoc 0m 29s hadoop-yarn-server-router in the patch failed.
                Other Tests
          +1 unit 9m 54s hadoop-common in the patch passed.
          -1 unit 1m 21s hadoop-yarn-server-router in the patch failed.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          96m 54s



          Reason Tests
          Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882988/YARN-3661-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 370c624998f6 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b6bfb2f
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17043/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17043/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/17043/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17043/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/17043/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 14m 37s trunk passed +1 compile 14m 48s trunk passed +1 checkstyle 2m 0s trunk passed +1 mvnsite 1m 59s trunk passed +1 findbugs 2m 31s trunk passed +1 javadoc 1m 19s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 14m 11s the patch passed +1 javac 14m 11s the patch passed -0 checkstyle 2m 10s root: The patch generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0) +1 mvnsite 2m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 8s the patch passed -1 javadoc 0m 29s hadoop-yarn-server-router in the patch failed.       Other Tests +1 unit 9m 54s hadoop-common in the patch passed. -1 unit 1m 21s hadoop-yarn-server-router in the patch failed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 96m 54s Reason Tests Failed junit tests hadoop.yarn.server.router.webapp.TestRouterWebServicesREST Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882988/YARN-3661-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 370c624998f6 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b6bfb2f Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17043/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17043/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17043/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17043/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/17043/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - - edited

          Thanks Íñigo Goiri.
          Few additional feedback about the edited classes:

          • Why do we need the changes in hadoop-common-project/hadoop-common/pom.xml?
          • In Router we don't need to create getFederationFacade since we can use directly the singleton instance everywhere.
          • In RouterWebServiceUtil I have already created invokeRMWebService you just need to adapt your calls to the new method.
          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - - edited Thanks Íñigo Goiri . Few additional feedback about the edited classes: Why do we need the changes in hadoop-common-project/hadoop-common/pom.xml ? In Router we don't need to create getFederationFacade since we can use directly the singleton instance everywhere. In RouterWebServiceUtil I have already created invokeRMWebService you just need to adapt your calls to the new method.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Tackled some comments from Giovanni Matteo Fumarola.

          Show
          elgoiri Íñigo Goiri added a comment - Tackled some comments from Giovanni Matteo Fumarola .
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Thanks Íñigo Goiri for the patch. Some starting feedback:

          • Push some screenshots of the webapp.
          • I have already created RouterWebUtils. Move the code in RouterUtil inside it.
          • I don't see the use of routerContext. Please remove it.
            There are some yetus warnings in the report.
          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Íñigo Goiri for the patch. Some starting feedback: Push some screenshots of the webapp. I have already created RouterWebUtils . Move the code in RouterUtil inside it. I don't see the use of routerContext . Please remove it. There are some yetus warnings in the report.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 15m 6s trunk passed
          +1 compile 0m 18s trunk passed
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 20s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 14s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 16s the patch passed
          +1 compile 0m 19s the patch passed
          +1 javac 0m 19s the patch passed
          -0 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: The patch generated 44 new + 0 unchanged - 0 fixed = 44 total (was 0)
          +1 mvnsite 0m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 39s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
          -1 javadoc 0m 11s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0)
                Other Tests
          +1 unit 0m 59s hadoop-yarn-server-router in the patch passed.
          +1 asflicense 0m 13s The patch does not generate ASF License warnings.
          21m 26s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
            Possible null pointer dereference of rmApps in org.apache.hadoop.yarn.server.router.webapp.AppsBlock.initAppsInfo() Dereferenced at AppsBlock.java:rmApps in org.apache.hadoop.yarn.server.router.webapp.AppsBlock.initAppsInfo() Dereferenced at AppsBlock.java:[line 169]
            Possible null pointer dereference of rmNodes in org.apache.hadoop.yarn.server.router.webapp.NodesBlock.initNodesInfo() Dereferenced at NodesBlock.java:rmNodes in org.apache.hadoop.yarn.server.router.webapp.NodesBlock.initNodesInfo() Dereferenced at NodesBlock.java:[line 132]
            Exception is caught when Exception is not thrown in org.apache.hadoop.yarn.server.router.webapp.ResourceManagersBlock.render(HtmlBlock$Block) At ResourceManagersBlock.java:is not thrown in org.apache.hadoop.yarn.server.router.webapp.ResourceManagersBlock.render(HtmlBlock$Block) At ResourceManagersBlock.java:[line 90]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-3661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882246/YARN-3661-000.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a803111b5f92 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ab051bd
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16948/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16948/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16948/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16948/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16948/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 6s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 20s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 16s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed -0 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: The patch generated 44 new + 0 unchanged - 0 fixed = 44 total (was 0) +1 mvnsite 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 39s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) -1 javadoc 0m 11s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0)       Other Tests +1 unit 0m 59s hadoop-yarn-server-router in the patch passed. +1 asflicense 0m 13s The patch does not generate ASF License warnings. 21m 26s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router   Possible null pointer dereference of rmApps in org.apache.hadoop.yarn.server.router.webapp.AppsBlock.initAppsInfo() Dereferenced at AppsBlock.java:rmApps in org.apache.hadoop.yarn.server.router.webapp.AppsBlock.initAppsInfo() Dereferenced at AppsBlock.java: [line 169]   Possible null pointer dereference of rmNodes in org.apache.hadoop.yarn.server.router.webapp.NodesBlock.initNodesInfo() Dereferenced at NodesBlock.java:rmNodes in org.apache.hadoop.yarn.server.router.webapp.NodesBlock.initNodesInfo() Dereferenced at NodesBlock.java: [line 132]   Exception is caught when Exception is not thrown in org.apache.hadoop.yarn.server.router.webapp.ResourceManagersBlock.render(HtmlBlock$Block) At ResourceManagersBlock.java:is not thrown in org.apache.hadoop.yarn.server.router.webapp.ResourceManagersBlock.render(HtmlBlock$Block) At ResourceManagersBlock.java: [line 90] Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-3661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882246/YARN-3661-000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a803111b5f92 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ab051bd Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16948/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16948/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16948/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16948/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router Console output https://builds.apache.org/job/PreCommit-YARN-Build/16948/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          First proposal for the patch.

          Show
          elgoiri Íñigo Goiri added a comment - First proposal for the patch.

            People

            • Assignee:
              elgoiri Íñigo Goiri
              Reporter:
              giovanni.fumarola Giovanni Matteo Fumarola
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:

                Development