Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3654

ContainerLogsPage web UI should not have meta-refresh

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Currently, When we try to find the container logs for the finished application, it will re-direct to the url which we re-configured for yarn.log.server.url in yarn-site.xml. But in ContainerLogsPage, we are using meta-refresh:

              set(TITLE, join("Redirecting to log server for ", $(CONTAINER_ID)));
              html.meta_http("refresh", "1; url=" + redirectUrl);
      

      which is not good for some browsers which need to enable the meta-refresh in their security setting, especially for IE which meta-refresh is considered a security hole.

      1. YARN-3654.2.patch
        11 kB
        Xuan Gong
      2. YARN-3654.1.patch
        11 kB
        Xuan Gong

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2150/)
          YARN-3654. ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2150/ ) YARN-3654 . ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/192/)
          YARN-3654. ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/192/ ) YARN-3654 . ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/202/)
          YARN-3654. ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/202/ ) YARN-3654 . ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2132 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2132/)
          YARN-3654. ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2132 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2132/ ) YARN-3654 . ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/203/)
          YARN-3654. ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/203/ ) YARN-3654 . ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #934 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/934/)
          YARN-3654. ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #934 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/934/ ) YARN-3654 . ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7877 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7877/)
          YARN-3654. ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7877 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7877/ ) YARN-3654 . ContainerLogsPage web UI should not have meta-refresh. Contributed by Xuan Gong (jianhe: rev 6329bd00fa1f17cc9555efa496ea7607ad93e0ce) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMController.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          Hide
          jianhe Jian He added a comment -

          Committed to trunk and branch-2 , thanks Xuan !

          Show
          jianhe Jian He added a comment - Committed to trunk and branch-2 , thanks Xuan !
          Hide
          jianhe Jian He added a comment -

          looks good, +1

          Show
          jianhe Jian He added a comment - looks good, +1
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 41s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 34s There were no new javac warning messages.
          +1 javadoc 9m 38s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 36s The applied patch generated 2 new checkstyle issues (total was 12, now 13).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 6m 6s Tests passed in hadoop-yarn-server-nodemanager.
              42m 14s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733729/YARN-3654.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0790275
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7991/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7991/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7991/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7991/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 41s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 36s The applied patch generated 2 new checkstyle issues (total was 12, now 13). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 6s Tests passed in hadoop-yarn-server-nodemanager.     42m 14s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733729/YARN-3654.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0790275 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7991/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7991/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7991/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7991/console This message was automatically generated.
          Hide
          xgong Xuan Gong added a comment -

          fix -1 on findbugs

          Show
          xgong Xuan Gong added a comment - fix -1 on findbugs
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 14s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 51s There were no new javac warning messages.
          +1 javadoc 9m 56s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 40s The applied patch generated 2 new checkstyle issues (total was 12, now 13).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 1m 7s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 6m 4s Tests passed in hadoop-yarn-server-nodemanager.
              43m 25s  



          Reason Tests
          FindBugs module:hadoop-yarn-server-nodemanager
            Class org.apache.hadoop.yarn.server.nodemanager.webapp.NMWebAppFilter defines non-transient non-serializable instance field nmConf In NMWebAppFilter.java:instance field nmConf In NMWebAppFilter.java



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733248/YARN-3654.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 03a293a
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7953/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7953/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7953/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7953/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7953/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 14s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 9m 56s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 40s The applied patch generated 2 new checkstyle issues (total was 12, now 13). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 1m 7s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 yarn tests 6m 4s Tests passed in hadoop-yarn-server-nodemanager.     43m 25s   Reason Tests FindBugs module:hadoop-yarn-server-nodemanager   Class org.apache.hadoop.yarn.server.nodemanager.webapp.NMWebAppFilter defines non-transient non-serializable instance field nmConf In NMWebAppFilter.java:instance field nmConf In NMWebAppFilter.java Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733248/YARN-3654.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 03a293a checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7953/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7953/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7953/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7953/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7953/console This message was automatically generated.
          Hide
          xgong Xuan Gong added a comment -

          Create a patch based on my proposal.
          Tested the patch in a single node cluster.

          • use firefox (chrome and safari can not be used to do the test), in Preferences--> Advanced -->General, mark "Warn me when websites try to redirect or reload the page"
          • start a historyserver, and configure yarn.log.server.url and point to historyserver log (such as http://localhost:19888/jobhistory/logs)
          • Run a mapreduce job, and wait for the job finishes
          • go to application web ui and click the log url in attempts table
          • without the patch, the firefox browser will block the redirect and ask for the permission whether the redirection is allowed
          • with this patch, it will directly redirect to the url that we re-configured in yarn-site.xml
          Show
          xgong Xuan Gong added a comment - Create a patch based on my proposal. Tested the patch in a single node cluster. use firefox (chrome and safari can not be used to do the test), in Preferences--> Advanced -->General, mark "Warn me when websites try to redirect or reload the page" start a historyserver, and configure yarn.log.server.url and point to historyserver log (such as http://localhost:19888/jobhistory/logs ) Run a mapreduce job, and wait for the job finishes go to application web ui and click the log url in attempts table without the patch, the firefox browser will block the redirect and ask for the permission whether the redirection is allowed with this patch, it will directly redirect to the url that we re-configured in yarn-site.xml
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Makes sense.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Makes sense.
          Hide
          xgong Xuan Gong added a comment -

          My proposal:
          do similar things as YARN-2605, we need to create a NMWebAppFilter, and instead of simply adding the meta-refresh in html, we need to set 307 as response code, add Location which includes the redirect-url in response header and let the browser to handle the re-direction by itself.

          Show
          xgong Xuan Gong added a comment - My proposal: do similar things as YARN-2605 , we need to create a NMWebAppFilter, and instead of simply adding the meta-refresh in html, we need to set 307 as response code, add Location which includes the redirect-url in response header and let the browser to handle the re-direction by itself.

            People

            • Assignee:
              xgong Xuan Gong
              Reporter:
              xgong Xuan Gong
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development