Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3629

NodeID is always printed as "null" in node manager initialization log.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In Node manager log during startup the following logs is printed

      2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for null : physical-memory=4096 virtual-memory=8602 virtual-cores=8

      This line is printed from NodeStatusUpdaterImpl.serviceInit.
      But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart

        protected void serviceStart() throws Exception {
      
          // NodeManager is the last service to start, so NodeId is available.
          this.nodeId = this.context.getNodeId();
      

      Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart.

      The log can be moved to service start to give right information to user.

        Activity

        Hide
        nijel nijel added a comment -

        Moving the logs message is bit tricky since it logs some parameters which is not available in serviceStart. So keeping this log as it is
        Adding a new log message to print the nodeid for information purpose

        Any different thought ?

        Show
        nijel nijel added a comment - Moving the logs message is bit tricky since it logs some parameters which is not available in serviceStart. So keeping this log as it is Adding a new log message to print the nodeid for information purpose Any different thought ?
        Hide
        nijel nijel added a comment -

        Please review

        Show
        nijel nijel added a comment - Please review
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 43s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 38s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 2s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 6m 0s Tests passed in hadoop-yarn-server-nodemanager.
            42m 9s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12732192/YARN-3629-1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 360dff5
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7881/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7881/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7881/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 38s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 2s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 6m 0s Tests passed in hadoop-yarn-server-nodemanager.     42m 9s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732192/YARN-3629-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 360dff5 hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7881/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7881/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7881/console This message was automatically generated.
        Hide
        nijel nijel added a comment -

        -1 tests included

        This is a log message change. So tests are not required

        Show
        nijel nijel added a comment - -1 tests included This is a log message change. So tests are not required
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks nijel for your contribution.

        +1, patch looks good to me.

        Show
        devaraj.k Devaraj K added a comment - Thanks nijel for your contribution. +1, patch looks good to me.
        Hide
        devaraj.k Devaraj K added a comment -

        Committed to trunk and branch-2

        Thanks nijel.

        Show
        devaraj.k Devaraj K added a comment - Committed to trunk and branch-2 Thanks nijel .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7807 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7807/)
        YARN-3629. NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7807 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7807/ ) YARN-3629 . NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Hide
        nijel nijel added a comment -

        Thanks Devaraj K for the reviewing and committing the patch

        Show
        nijel nijel added a comment - Thanks Devaraj K for the reviewing and committing the patch
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/195/)
        YARN-3629. NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/195/ ) YARN-3629 . NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #926 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/926/)
        YARN-3629. NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #926 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/926/ ) YARN-3629 . NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2124 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2124/)
        YARN-3629. NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2124 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2124/ ) YARN-3629 . NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/184/)
        YARN-3629. NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/184/ ) YARN-3629 . NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/)
        YARN-3629. NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/ ) YARN-3629 . NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/)
        YARN-3629. NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/ ) YARN-3629 . NodeID is always printed as "null" in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/CHANGES.txt

          People

          • Assignee:
            nijel nijel
            Reporter:
            nijel nijel
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development