Hadoop YARN
  1. Hadoop YARN
  2. YARN-362

Unexpected extra results when using webUI table search

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 0.23.5
    • Fix Version/s: 0.23.7, 2.1.0-beta
    • Component/s: None
    • Labels:
      None

      Description

      When using the search box on the web UI to search for a specific task number (e.g.: "0831"), sometimes unexpected extra results are shown. Using the web browser's built-in search-within-page does not show any hits, so these look like completely spurious results.

      It looks like the raw timestamp value for time columns, which is not shown in the table, is also being searched with the search box.

      1. MAPREDUCE-4960.patch
        2 kB
        Ravi Prakash
      2. YARN-362.branch-0.23.patch
        20 kB
        Ravi Prakash
      3. YARN-362.patch
        3 kB
        Ravi Prakash
      4. YARN-362.patch
        19 kB
        Ravi Prakash

        Issue Links

          Activity

          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue is depended upon by MAPREDUCE-4989 [ MAPREDUCE-4989 ]
          Gavin made changes -
          Link This issue blocks MAPREDUCE-4989 [ MAPREDUCE-4989 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1339 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1339/)
          YARN-362. Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444085)

          Result = SUCCESS
          jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444085
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1339 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1339/ ) YARN-362 . Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444085) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444085 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1311 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1311/)
          YARN-362. Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444085)

          Result = FAILURE
          jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444085
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1311 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1311/ ) YARN-362 . Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444085) Result = FAILURE jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444085 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #520 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/520/)
          svn merge -c 1444085 FIXES: YARN-362. Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444090)

          Result = SUCCESS
          jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444090
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #520 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/520/ ) svn merge -c 1444085 FIXES: YARN-362 . Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444090) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444090 Files : /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #122 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/122/)
          YARN-362. Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444085)

          Result = SUCCESS
          jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444085
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #122 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/122/ ) YARN-362 . Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444085) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444085 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Jason Lowe made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.23.7 [ 12323953 ]
          Fix Version/s 2.0.4-beta [ 12324029 ]
          Resolution Fixed [ 1 ]
          Hide
          Jason Lowe added a comment -

          Thanks, Ravi! I committed this to trunk, branch-2, and branch-0.23.

          Show
          Jason Lowe added a comment - Thanks, Ravi! I committed this to trunk, branch-2, and branch-0.23.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3345/)
          YARN-362. Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444085)

          Result = SUCCESS
          jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444085
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3345/ ) YARN-362 . Unexpected extra results when using webUI table search. Contributed by Ravi Prakash (Revision 1444085) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444085 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js
          Jason Lowe made changes -
          Summary Unexpected extra results when using the task attempt table search Unexpected extra results when using webUI table search
          Hide
          Jason Lowe added a comment -

          Thanks for separating out the patch into YARN and MAPREDUCE patches, Ravi. +1 on the latest patch to update the .js file.

          Show
          Jason Lowe added a comment - Thanks for separating out the patch into YARN and MAPREDUCE patches, Ravi. +1 on the latest patch to update the .js file.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12568494/YARN-362.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/395//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/395//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568494/YARN-362.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/395//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/395//console This message is automatically generated.
          Ravi Prakash made changes -
          Attachment YARN-362.patch [ 12568494 ]
          Hide
          Ravi Prakash added a comment -

          Small patch for fixing the yarn.dt.plugins.js file

          Show
          Ravi Prakash added a comment - Small patch for fixing the yarn.dt.plugins.js file
          Ravi Prakash made changes -
          Link This issue blocks MAPREDUCE-4989 [ MAPREDUCE-4989 ]
          Hide
          Ravi Prakash added a comment -

          I manually tested the patch. Looks good to me. +1

          Show
          Ravi Prakash added a comment - I manually tested the patch. Looks good to me. +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12568368/YARN-362.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/391//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/391//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568368/YARN-362.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/391//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/391//console This message is automatically generated.
          Ravi Prakash made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Ravi Prakash made changes -
          Attachment YARN-362.patch [ 12568368 ]
          Hide
          Ravi Prakash added a comment -

          The patch ported to trunk

          Show
          Ravi Prakash added a comment - The patch ported to trunk
          Ravi Prakash made changes -
          Attachment YARN-362.branch-0.23.patch [ 12568367 ]
          Hide
          Ravi Prakash added a comment -

          Thanks for the review Jason! I hadn't realized that I hadn't jsonified the attempts table. I'm doing so in this patch. I've also fixed the pollution of search results, along with some minor code improvements.

          Show
          Ravi Prakash added a comment - Thanks for the review Jason! I hadn't realized that I hadn't jsonified the attempts table. I'm doing so in this patch. I've also fixed the pollution of search results, along with some minor code improvements.
          Jason Lowe made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jason Lowe added a comment -

          Tried the patch locally, but it's not solving the problem for me. I ran a MR job, went to the successful map attempts page, and I still get hits that are not found if searching via the browser's search-within-page function when searching for strings that are in the "title" attribute text of table entries.

          Show
          Jason Lowe added a comment - Tried the patch locally, but it's not solving the problem for me. I ran a MR job, went to the successful map attempts page, and I still get hits that are not found if searching via the browser's search-within-page function when searching for strings that are in the "title" attribute text of table entries.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12566456/MAPREDUCE-4960.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/374//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/374//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566456/MAPREDUCE-4960.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/374//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/374//console This message is automatically generated.
          Hide
          Jason Lowe added a comment -

          Moved to the YARN project since that's where the fix needs to be applied.

          Show
          Jason Lowe added a comment - Moved to the YARN project since that's where the fix needs to be applied.
          Jason Lowe made changes -
          Project Hadoop Map/Reduce [ 12310941 ] Hadoop YARN [ 12313722 ]
          Key MAPREDUCE-4960 YARN-362
          Affects Version/s 0.23.5 [ 12323311 ]
          Affects Version/s 2.0.3-alpha [ 12323272 ]
          Affects Version/s 2.0.3-alpha [ 12323275 ]
          Affects Version/s 0.23.5 [ 12323312 ]
          Component/s webapps [ 12316700 ]
          Hide
          Ravi Prakash added a comment -

          I manually tested that substrings of the JSON array elements (which are rendered differently) do not show up now in the search results. Only the strings which are displayed are searched.

          Show
          Ravi Prakash added a comment - I manually tested that substrings of the JSON array elements (which are rendered differently) do not show up now in the search results. Only the strings which are displayed are searched.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12566456/MAPREDUCE-4960.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3272//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3272//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566456/MAPREDUCE-4960.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3272//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3272//console This message is automatically generated.
          Ravi Prakash made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Ravi Prakash made changes -
          Attachment MAPREDUCE-4960.patch [ 12566456 ]
          Hide
          Ravi Prakash added a comment -

          Short and sweet! Simple patch to fix this issue

          Show
          Ravi Prakash added a comment - Short and sweet! Simple patch to fix this issue
          Ravi Prakash made changes -
          Field Original Value New Value
          Assignee Ravi Prakash [ raviprak ]
          Jason Lowe created issue -

            People

            • Assignee:
              Ravi Prakash
              Reporter:
              Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development