Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3617

Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning always -1

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Environment:

      Windows 7 x64 SP1

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In the class 'WindowsResourceCalculatorPlugin.java' of the YARN project, there is an unused variable for CPU frequency.

      " /**

      {@inheritDoc}

      */
      @Override
      public long getCpuFrequency()

      { refreshIfNeeded(); return -1; }

      "

      Please change '-1' to use 'cpuFrequencyKhz'.

      org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java

        Issue Links

          Activity

          Hide
          andreina J.Andreina added a comment -

          Thanks Georg Berendt for reporting this issue. If you have already started working on this, please reassign to you.

          Show
          andreina J.Andreina added a comment - Thanks Georg Berendt for reporting this issue. If you have already started working on this, please reassign to you.
          Hide
          andreina J.Andreina added a comment -

          Attached an initial patch.
          Please review.

          Show
          andreina J.Andreina added a comment - Attached an initial patch. Please review.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 8s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 41s There were no new javac warning messages.
          +1 javadoc 10m 1s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 52s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 24s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common.
              39m 35s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732542/YARN-3617.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 065d8f2
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7917/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7917/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7917/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 8s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 10m 1s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 52s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 24s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common.     39m 35s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732542/YARN-3617.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 065d8f2 hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7917/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7917/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7917/console This message was automatically generated.
          Hide
          xafero Georg Berendt added a comment -

          Thanks J.Andreina

          Show
          xafero Georg Berendt added a comment - Thanks J.Andreina
          Hide
          devaraj.k Devaraj K added a comment -

          This issue doesn't seem to be fixed/committed, reopening it.

          Georg Berendt, Please note that committers will review and mark the issue as fixed once they commit the changes to repository.

          Show
          devaraj.k Devaraj K added a comment - This issue doesn't seem to be fixed/committed, reopening it. Georg Berendt , Please note that committers will review and mark the issue as fixed once they commit the changes to repository.
          Hide
          devaraj.k Devaraj K added a comment -

          +1, will commit it shortly.

          Show
          devaraj.k Devaraj K added a comment - +1, will commit it shortly.
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks J.Andreina for the patch and Georg Berendt for reporting.

          Committed to trunk and branch-2.

          Show
          devaraj.k Devaraj K added a comment - Thanks J.Andreina for the patch and Georg Berendt for reporting. Committed to trunk and branch-2.
          Hide
          andreina J.Andreina added a comment -

          Thanks Devaraj K for the commit

          Show
          andreina J.Andreina added a comment - Thanks Devaraj K for the commit
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8033 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8033/)
          YARN-3617. Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8033 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8033/ ) YARN-3617 . Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #961 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/961/)
          YARN-3617. Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #961 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/961/ ) YARN-3617 . Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/231/)
          YARN-3617. Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/231/ ) YARN-3617 . Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/220/)
          YARN-3617. Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/220/ ) YARN-3617 . Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/229/)
          YARN-3617. Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/229/ ) YARN-3617 . Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2177 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2177/)
          YARN-3617. Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2177 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2177/ ) YARN-3617 . Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2159 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2159/)
          YARN-3617. Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2159 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2159/ ) YARN-3617 . Fix WindowsResourceCalculatorPlugin.getCpuFrequency() returning (devaraj: rev 318d2cde7cb5c05a5f87c4ee967446bb60d28ae4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsResourceCalculatorPlugin.java hadoop-yarn-project/CHANGES.txt

            People

            • Assignee:
              andreina J.Andreina
              Reporter:
              xafero Georg Berendt
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development