Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3613

TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In TestContainerManagerSecurity, individual tests init and start Yarn cluster. This duplication can be avoided by moving that to setup.

      Further, one could merge the two @Test methods to avoid bringing up another mini-cluster.

      1. YARN-3613-1.patch
        3 kB
        nijel
      2. yarn-3613-2.patch
        3 kB
        Karthik Kambatla

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/)
        YARN-3613. TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/ ) YARN-3613 . TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/)
        YARN-3613. TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/ ) YARN-3613 . TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/184/)
        YARN-3613. TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/184/ ) YARN-3613 . TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2124 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2124/)
        YARN-3613. TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2124 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2124/ ) YARN-3613 . TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #926 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/926/)
        YARN-3613. TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #926 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/926/ ) YARN-3613 . TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/195/)
        YARN-3613. TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/195/ ) YARN-3613 . TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        Hide
        nijel nijel added a comment -

        Thanks Karthik Kambatla for reviewing and committing the patch

        Show
        nijel nijel added a comment - Thanks Karthik Kambatla for reviewing and committing the patch
        Hide
        kasha Karthik Kambatla added a comment -

        Thanks for working on this, nijel. Just committed this to trunk and branch-2.

        Show
        kasha Karthik Kambatla added a comment - Thanks for working on this, nijel. Just committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7808 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7808/)
        YARN-3613. TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7808 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7808/ ) YARN-3613 . TestContainerManagerSecurity should init and start Yarn cluster in setup instead of individual methods. (nijel via kasha) (kasha: rev fe0df596271340788095cb43a1944e19ac4c2cf7) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestContainerManagerSecurity.java
        Hide
        kasha Karthik Kambatla added a comment -

        At commit time, modified the comment that precedes call to testContainerTokenWithEpoch. Attaching the updated diff here.

        Show
        kasha Karthik Kambatla added a comment - At commit time, modified the comment that precedes call to testContainerTokenWithEpoch . Attaching the updated diff here.
        Hide
        kasha Karthik Kambatla added a comment -

        +1. Checking this in.

        Show
        kasha Karthik Kambatla added a comment - +1. Checking this in.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 12s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 22s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 0m 35s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 1m 51s Tests passed in hadoop-yarn-server-tests.
            18m 3s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12732121/YARN-3613-1.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 3d28611
        hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/7875/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7875/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7875/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 12s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 22s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 0m 35s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 1m 51s Tests passed in hadoop-yarn-server-tests.     18m 3s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732121/YARN-3613-1.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 3d28611 hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/7875/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7875/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7875/console This message was automatically generated.
        Hide
        nijel nijel added a comment -

        Please review the patch.
        Removed 2 unused imports.
        Test time reduced from ~130 to ~80 sec

        Show
        nijel nijel added a comment - Please review the patch. Removed 2 unused imports. Test time reduced from ~130 to ~80 sec
        Hide
        nijel nijel added a comment -

        i will update the patch.

        Show
        nijel nijel added a comment - i will update the patch.

          People

          • Assignee:
            nijel nijel
            Reporter:
            kasha Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development