Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3594

WintuilsProcessStubExecutor.startStreamReader leaks streams

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Trivial
        • Resolution: Fixed
        • Affects Version/s: 3.0.0-alpha1
        • Fix Version/s: 2.8.0, 3.0.0-alpha1
        • Component/s: nodemanager
        • Labels:
        • Target Version/s:
        • Hadoop Flags:
          Reviewed

          Description

          while looking at the file, my IDE highlights that the thread runnables started by
          WintuilsProcessStubExecutor.startStreamReader() don't close their streams as they exit.

          a java7 try-with-resources would trivially fix this

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            lars_francke Lars Francke added a comment -

            Changes the try statement to an extended try-with-resources.

            I can't assign JIRAs to myself yet.

            Show
            lars_francke Lars Francke added a comment - Changes the try statement to an extended try-with-resources. I can't assign JIRAs to myself yet.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -



            -1 overall



            Vote Subsystem Runtime Comment
            0 pre-patch 14m 42s Pre-patch trunk compilation is healthy.
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
            +1 javac 7m 34s There were no new javac warning messages.
            +1 javadoc 9m 32s There were no new javadoc warning messages.
            +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
            +1 checkstyle 0m 38s There were no new checkstyle issues.
            +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            +1 install 1m 34s mvn install still works.
            +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
            +1 findbugs 1m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
            +1 yarn tests 6m 31s Tests passed in hadoop-yarn-server-nodemanager.
                42m 31s  



            Subsystem Report/Notes
            Patch URL http://issues.apache.org/jira/secure/attachment/12734617/YARN-3594.1.patch
            Optional Tests javadoc javac unit findbugs checkstyle
            git revision trunk / 05e04f3
            hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8046/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
            Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8046/testReport/
            Java 1.7.0_55
            uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Console output https://builds.apache.org/job/PreCommit-YARN-Build/8046/console

            This message was automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 38s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 31s Tests passed in hadoop-yarn-server-nodemanager.     42m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734617/YARN-3594.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 05e04f3 hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8046/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8046/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8046/console This message was automatically generated.
            Hide
            Permalink
            lars_francke Lars Francke added a comment -

            I don't think an additional test is needed as it should already be covered by existing tests.

            Show
            lars_francke Lars Francke added a comment - I don't think an additional test is needed as it should already be covered by existing tests.
            Hide
            Permalink
            djp Junping Du added a comment -

            +1. Patch LGTM. Committing this in.

            Show
            djp Junping Du added a comment - +1. Patch LGTM. Committing this in.
            Hide
            Permalink
            djp Junping Du added a comment -

            I have commit the patch to trunk and branch-2. Thanks Lars Francke for contributing the patch and Steve Loughran for reporting the issue!

            Show
            djp Junping Du added a comment - I have commit the patch to trunk and branch-2. Thanks Lars Francke for contributing the patch and Steve Loughran for reporting the issue!
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-trunk-Commit #7892 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7892/)
            YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd)

            • hadoop-yarn-project/CHANGES.txt
            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7892 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7892/ ) YARN-3594 . WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Yarn-trunk #935 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/935/)
            YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd)

            • hadoop-yarn-project/CHANGES.txt
            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #935 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/935/ ) YARN-3594 . WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #204 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/204/)
            YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd)

            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #204 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/204/ ) YARN-3594 . WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk #2133 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2133/)
            YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd)

            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2133 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2133/ ) YARN-3594 . WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/193/)
            YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd)

            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/193/ ) YARN-3594 . WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/203/)
            YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd)

            • hadoop-yarn-project/CHANGES.txt
            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/203/ ) YARN-3594 . WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2151 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2151/)
            YARN-3594. WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd)

            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java
            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2151 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2151/ ) YARN-3594 . WintuilsProcessStubExecutor.startStreamReader leaks streams. Contributed by Lars Francke. (junping_du: rev 132d909d4a6509af9e63e24cbb719be10006b6cd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java hadoop-yarn-project/CHANGES.txt

              People

              • Assignee:
                lars_francke Lars Francke
                Reporter:
                stevel@apache.org Steve Loughran
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development