Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2492 (Clone of YARN-796) Allow for (admin) labels on nodes and resource-requests
  3. YARN-3593

Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page

        Details

        • Type: Sub-task
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.6.0, 2.7.0
        • Fix Version/s: 2.8.0, 3.0.0-alpha1
        • Component/s: webapp
        • Labels:
          None
        • Target Version/s:

          Description

          Need to support displaying the label type in Node Labels page and also instead of <NO_LABEL> we need to show as <DEFAULT_PARTITION>

          1. PNG File
            NodeLabelsPageModifications.png
            171 kB
            Naganarasimha G R
          2. Text File
            YARN-3593.20150507-1.patch
            2 kB
            Naganarasimha G R

            Issue Links

            is related to

            Bug - A problem which impairs or prevents the functions of the product. YARN-5427 Labeled apps cant use <DEFAULT_PARTITION> resources in 2.8

            • Major - Major loss of function.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Naganarasimha Naganarasimha G R added a comment -

              attaching initial patch and the snapshot for modifications

              Show
              Naganarasimha Naganarasimha G R added a comment - attaching initial patch and the snapshot for modifications
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -



              -1 overall



              Vote Subsystem Runtime Comment
              0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 javac 7m 32s There were no new javac warning messages.
              +1 javadoc 9m 33s There were no new javadoc warning messages.
              +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
              +1 checkstyle 0m 45s There were no new checkstyle issues.
              +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              +1 install 1m 33s mvn install still works.
              +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
              +1 findbugs 1m 16s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
              +1 yarn tests 53m 40s Tests passed in hadoop-yarn-server-resourcemanager.
                  89m 57s  



              Subsystem Report/Notes
              Patch URL http://issues.apache.org/jira/secure/attachment/12731228/YARN-3593.20150507-1.patch
              Optional Tests javadoc javac unit findbugs checkstyle
              git revision trunk / daf3e4e
              hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7769/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
              Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7769/testReport/
              Java 1.7.0_55
              uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Console output https://builds.apache.org/job/PreCommit-YARN-Build/7769/console

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 45s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 16s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 53m 40s Tests passed in hadoop-yarn-server-resourcemanager.     89m 57s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731228/YARN-3593.20150507-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / daf3e4e hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7769/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7769/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7769/console This message was automatically generated.
              Hide
              Permalink
              Naganarasimha Naganarasimha G R added a comment -

              Hi Tan, Wangda,
              Can you please take a look @ this.

              Show
              Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , Can you please take a look @ this.
              Hide
              Permalink
              leftnoteasy Wangda Tan added a comment -

              Naganarasimha G R,
              Looks good generally,
              Do you think we should make RM Nodes page consistent with this? when a node has no label, it should be <DEFAULT_PARTITION> instead of empty when label is enabled?

              Show
              leftnoteasy Wangda Tan added a comment - Naganarasimha G R , Looks good generally, Do you think we should make RM Nodes page consistent with this? when a node has no label, it should be <DEFAULT_PARTITION> instead of empty when label is enabled?
              Hide
              Permalink
              Naganarasimha Naganarasimha G R added a comment -

              Hi Tan, Wangda
              Thanks for the review and good point but RMNodeImpl.getNodeLabels which is used to get labels for the node in the UI will return empty list when node doesn't have any label or when node label is disabled. So in that case <DEFAULT_PARTITION> will be displayed even when node label is disabled, is that fine ?

              Show
              Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda Thanks for the review and good point but RMNodeImpl.getNodeLabels which is used to get labels for the node in the UI will return empty list when node doesn't have any label or when node label is disabled. So in that case <DEFAULT_PARTITION> will be displayed even when node label is disabled, is that fine ?
              Hide
              Permalink
              leftnoteasy Wangda Tan added a comment -

              Hmm.. reconsidered this, it may be strange to show a node's label is <DEFAULT_PARTITION> if user doesn't add anything to the node. So let's keep it as is, we may not need to change RM node's page.

              Committing this ticket.

              Show
              leftnoteasy Wangda Tan added a comment - Hmm.. reconsidered this, it may be strange to show a node's label is <DEFAULT_PARTITION> if user doesn't add anything to the node. So let's keep it as is, we may not need to change RM node's page. Committing this ticket.
              Hide
              Permalink
              leftnoteasy Wangda Tan added a comment -

              Committed to branch-2/trunk.

              Thanks Naganarasimha G R!

              Show
              leftnoteasy Wangda Tan added a comment - Committed to branch-2/trunk. Thanks Naganarasimha G R !
              Hide
              Permalink
              Naganarasimha Naganarasimha G R added a comment -

              Thanks for reviewing and committing this patch Tan, Wangda

              Show
              Naganarasimha Naganarasimha G R added a comment - Thanks for reviewing and committing this patch Tan, Wangda
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-trunk-Commit #7778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7778/)
              YARN-3593. Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73)

              • hadoop-yarn-project/CHANGES.txt
              • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7778/ ) YARN-3593 . Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/)
              YARN-3593. Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73)

              • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              • hadoop-yarn-project/CHANGES.txt
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/ ) YARN-3593 . Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java hadoop-yarn-project/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/)
              YARN-3593. Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73)

              • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              • hadoop-yarn-project/CHANGES.txt
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/ ) YARN-3593 . Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java hadoop-yarn-project/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/)
              YARN-3593. Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73)

              • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              • hadoop-yarn-project/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/ ) YARN-3593 . Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java hadoop-yarn-project/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/)
              YARN-3593. Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73)

              • hadoop-yarn-project/CHANGES.txt
              • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/ ) YARN-3593 . Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/)
              YARN-3593. Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73)

              • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              • hadoop-yarn-project/CHANGES.txt
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/ ) YARN-3593 . Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java hadoop-yarn-project/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/)
              YARN-3593. Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73)

              • hadoop-yarn-project/CHANGES.txt
              • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/ ) YARN-3593 . Add label-type and Improve "DEFAULT_PARTITION" in Node Labels Page. (Naganarasimha G R via wangda) (wangda: rev f55d21d89448b81eba6ecbaa4d57bf535461ce73) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeLabelsPage.java

                People

                • Assignee:
                  Naganarasimha Naganarasimha G R
                  Reporter:
                  Naganarasimha Naganarasimha G R
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development