Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3589

RM and AH web UI display DOCTYPE wrongly

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      RM web app UI display <!DOCTYPE html PUBLIC "-\/\/W3C\/\/DTD HTML 4.01\/\/EN" "http:\/\/www.w3.org\/TR\/html4\/strict.dtd"> which is not necessary.

      This is because, content of html page is escaped which result browser cant not parse it. Any content which is escaped should be with the HTML block , but doc type is above html which browser can't parse it.

      1. YARN-3589.PNG
        97 kB
        Rohith Sharma K S
      2. 0001-YARN-3589.patch
        2 kB
        Rohith Sharma K S

        Issue Links

          Activity

          Hide
          rohithsharma Rohith Sharma K S added a comment -

          YARN-1993 escapes the content which are written with in the html block which is required for cross-site scripting. But the same logic is being used for content outside the html block which browser does not parse it and dispaly as it is.

          Show
          rohithsharma Rohith Sharma K S added a comment - YARN-1993 escapes the content which are written with in the html block which is required for cross-site scripting. But the same logic is being used for content outside the html block which browser does not parse it and dispaly as it is.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Attached the patch fixing the issue. Kindly review the patch

          Show
          rohithsharma Rohith Sharma K S added a comment - Attached the patch fixing the issue. Kindly review the patch
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 53s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 25s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common.
              38m 38s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731132/0001-YARN-3589.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 305e473
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7758/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7758/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7758/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 53s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 25s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common.     38m 38s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731132/0001-YARN-3589.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 305e473 hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7758/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7758/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7758/console This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          lgtm, thanks Rohith !

          Show
          jianhe Jian He added a comment - lgtm, thanks Rohith !
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          +1, committing this shortly.

          Show
          ozawa Tsuyoshi Ozawa added a comment - +1, committing this shortly.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Committed this to trunk and branch-2. Thanks Rohith Sharma K S for reporting and fixing this, and thanks Jian He for your review!

          Show
          ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Rohith Sharma K S for reporting and fixing this, and thanks Jian He for your review!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7772 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7772/)
          YARN-3589. RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7772 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7772/ ) YARN-3589 . RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/)
          YARN-3589. RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/ ) YARN-3589 . RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/)
          YARN-3589. RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/ ) YARN-3589 . RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/)
          YARN-3589. RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/ ) YARN-3589 . RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/)
          YARN-3589. RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/ ) YARN-3589 . RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/)
          YARN-3589. RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/ ) YARN-3589 . RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/)
          YARN-3589. RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/ ) YARN-3589 . RM and AH web UI display DOCTYPE wrongly. Contbituted by Rohith. (ozawa: rev f26700f2878f4374c68e97ee00205eda5a6d022c) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/TextView.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HtmlPage.java hadoop-yarn-project/CHANGES.txt

            People

            • Assignee:
              rohithsharma Rohith Sharma K S
              Reporter:
              rohithsharma Rohith Sharma K S
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development