Details
-
Bug
-
Status: Resolved
-
Trivial
-
Resolution: Fixed
-
2.8.0
-
Reviewed
Description
In the RMServerUtils, the default values are negative number which results in the displayiing the RM web UI also negative number.
public static final ApplicationResourceUsageReport DUMMY_APPLICATION_RESOURCE_USAGE_REPORT = BuilderUtils.newApplicationResourceUsageReport(-1, -1, Resources.createResource(-1, -1), Resources.createResource(-1, -1), Resources.createResource(-1, -1), 0, 0);
Attachments
Attachments
- yarn-3352.PNG
- 27 kB
- Rohith Sharma K S
- 0001-YARN-3552.patch
- 1 kB
- Rohith Sharma K S
- 0001-YARN-3552.patch
- 3 kB
- Rohith Sharma K S
- 0002-YARN-3552.patch
- 3 kB
- Rohith Sharma K S
Issue Links
Activity
I agree to the internal logic, but concern is when the Application is finished the WebUI displays as -1 which I feel this can be improved.
This also appears in the REST service, so this is an API not just what humans see (and possibly screen-scraped by those that should have been using the REST API). We could always translate the -1's into 'N/A' or "Unavailable' on the web UI, but changing the REST API is going to be trickier from a compatibility point of view.
I think for UI dispaly 'N/A' is resonable, and REST we should keep existing behavior since it affect compatibility.
I think this problem exists even FairScheduler.
FairSchedulerAppsBlock.java:
.append(appInfo.getRunningContainers()).append("\",\"")
My bad, missed it. Thanks for pointing out, will update patch for it
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | pre-patch | 14m 43s | Pre-patch trunk compilation is healthy. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
+1 | javac | 7m 33s | There were no new javac warning messages. |
+1 | javadoc | 9m 35s | There were no new javadoc warning messages. |
+1 | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. |
-1 | checkstyle | 7m 38s | The applied patch generated 1 additional checkstyle issues. |
+1 | install | 1m 32s | mvn install still works. |
+1 | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
+1 | findbugs | 1m 16s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
-1 | yarn tests | 62m 58s | Tests failed in hadoop-yarn-server-resourcemanager. |
106m 14s |
Reason | Tests |
---|---|
Failed unit tests | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation |
hadoop.yarn.server.resourcemanager.TestRMRestart | |
Timed out tests | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation |
Subsystem | Report/Notes |
---|---|
Patch URL | http://issues.apache.org/jira/secure/attachment/12729401/0001-YARN-3552.patch |
Optional Tests | javadoc javac unit findbugs checkstyle |
git revision | trunk / aa22450 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/7550/artifact/patchprocess/checkstyle-result-diff.txt |
hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7550/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7550/testReport/ |
Java | 1.7.0_55 |
uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7550/console |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | pre-patch | 15m 1s | Pre-patch trunk compilation is healthy. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
+1 | javac | 7m 42s | There were no new javac warning messages. |
+1 | javadoc | 9m 44s | There were no new javadoc warning messages. |
+1 | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. |
-1 | checkstyle | 3m 56s | The applied patch generated 2 additional checkstyle issues. |
+1 | install | 1m 32s | mvn install still works. |
+1 | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
+1 | findbugs | 1m 15s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
-1 | yarn tests | 52m 27s | Tests failed in hadoop-yarn-server-resourcemanager. |
92m 35s |
Reason | Tests |
---|---|
Failed unit tests | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation |
Subsystem | Report/Notes |
---|---|
Patch URL | http://issues.apache.org/jira/secure/attachment/12729420/0001-YARN-3552.patch |
Optional Tests | javadoc javac unit findbugs checkstyle |
git revision | trunk / f5b3847 |
checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/7552/artifact/patchprocess/checkstyle-result-diff.txt |
hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7552/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7552/testReport/ |
Java | 1.7.0_55 |
uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7552/console |
This message was automatically generated.
Thanks for the patch, Rohith. Just one nit with the indentation of the FairSchedulerAppsBlock change, as it doesn't match the surrounding code otherwise lgtm.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | pre-patch | 14m 35s | Pre-patch trunk compilation is healthy. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | javac | 7m 33s | There were no new javac warning messages. |
+1 | javadoc | 9m 35s | There were no new javadoc warning messages. |
+1 | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. |
+1 | checkstyle | 0m 46s | There were no new checkstyle issues. |
+1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
+1 | install | 1m 32s | mvn install still works. |
+1 | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. |
+1 | findbugs | 1m 14s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
+1 | yarn tests | 52m 44s | Tests passed in hadoop-yarn-server-resourcemanager. |
89m 0s |
Subsystem | Report/Notes |
---|---|
Patch URL | http://issues.apache.org/jira/secure/attachment/12730377/0002-YARN-3552.patch |
Optional Tests | javadoc javac unit findbugs checkstyle |
git revision | trunk / 318081c |
hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7704/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7704/testReport/ |
Java | 1.7.0_55 |
uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7704/console |
This message was automatically generated.
Thanks to Rohith for the contribution and to Ryu for additional review! I committed this to trunk and branch-2.
FAILURE: Integrated in Hadoop-trunk-Commit #7732 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7732/)
YARN-3552. RM Web UI shows -1 running containers for completed apps. Contributed by Rohith (jlowe: rev 9356cf8676fd18f78655e8a6f2e6c946997dbd40)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/185/)
YARN-3552. RM Web UI shows -1 running containers for completed apps. Contributed by Rohith (jlowe: rev 9356cf8676fd18f78655e8a6f2e6c946997dbd40)
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/)
YARN-3552. RM Web UI shows -1 running containers for completed apps. Contributed by Rohith (jlowe: rev 9356cf8676fd18f78655e8a6f2e6c946997dbd40)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/)
YARN-3552. RM Web UI shows -1 running containers for completed apps. Contributed by Rohith (jlowe: rev 9356cf8676fd18f78655e8a6f2e6c946997dbd40)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/)
YARN-3552. RM Web UI shows -1 running containers for completed apps. Contributed by Rohith (jlowe: rev 9356cf8676fd18f78655e8a6f2e6c946997dbd40)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/)
YARN-3552. RM Web UI shows -1 running containers for completed apps. Contributed by Rohith (jlowe: rev 9356cf8676fd18f78655e8a6f2e6c946997dbd40)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
- hadoop-yarn-project/CHANGES.txt
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/)
YARN-3552. RM Web UI shows -1 running containers for completed apps. Contributed by Rohith (jlowe: rev 9356cf8676fd18f78655e8a6f2e6c946997dbd40)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
- hadoop-yarn-project/CHANGES.txt
I believe the negative numbers were to indicate that the value is not available or cannot be reported due to lack of authorization. Changing these to zero changes the API and breaks anyone depending upon that behavior.