[YARN-3546] AbstractYarnScheduler.getApplicationAttempt seems misleading, and there're some misuse of it

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Component/s: resourcemanager
• Assignee: Unassigned
• Reporter: sandflee
• Created: 25/Apr/15 23:39
• Updated: 30/Apr/15 23:20
• Resolved: 30/Apr/15 23:20

Description

I'm not familiar with scheduler, with first eyes, I thought this func returns the schdulerAppAttempt info corresponding to appAttemptId, but actually it returns the current schdulerAppAttempt.
It seems misled others too, such as
TestWorkPreservingRMRestart.waitForNumContainersToRecover
MockRM.waitForSchedulerAppAttemptAdded
should I rename it to T getCurrentSchedulerApplicationAttempt(ApplicationId applicationid)
or returns null if current attempt id not equals to the request attempt id ?
comment preferred!