Not all exceptions in TimelineServer are uprated to web exceptions; only IOEs
Fix timeline client retry
YARN Timeline Service v.2: alpha 1
patch 001; all Exceptions are converted to web 500 exceptions, rather than handled in jersey itself, which is a lot less informative
This message was automatically generated.
No tests; would need a fair amount of mock pain to get coverage
Only RuntimeException will not be caught, and GenericExceptionHandler should map it to 500 and record a warn log, no?
May be it sounds slightly better if we handle RuntimeException in the same way as IOException here? At least, we add "Error putting domain" info.
It's a little bit surprising that this patch still applies after 18 months... I'm fine with catching general exceptions but not RuntimeExceptions since they're unchecked exceptions? +1 for the current patch.
Updating the patch based on the discussion.
Junping Du could you check the patch?
Sorry for slow response as in relocation... the v2 patch LGTM. +1. Will commit it tomorrow if no further comments!
I have commit the patch to trunk and branch-2. Thanks Steve Loughran and Tsuyoshi Ozawa for patch contribution and others for review and comments!
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10858 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10858/)
YARN-3538. TimelineWebService doesn't catch runtime exception. (junping_du: rev f05a9ceb4a9623517aa1c8d995805e26ae1bde5a)