Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3526

ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster

    Details

      Description

      On a QJM HA cluster, view RM web UI to track job status, it shows

      This is standby RM. Redirecting to the current active RM: http://<active-RM>:8088/proxy/application_1427338037905_0008/mapreduce

      it refreshes every 3 sec but never going to the correct tracking page.

      1. YARN-3526.002.patch
        2 kB
        Weiwei Yang
      2. YARN-3526.001.patch
        2 kB
        Weiwei Yang

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Pulled this into 2.6.1. Ran compilation and TestRMFailover before the push. Patch applied cleanly.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1. Ran compilation and TestRMFailover before the push. Patch applied cleanly.
          Hide
          l201514 Siqi Li added a comment -

          The latest patch can be applied to 2.6.0 branch cleanly

          Show
          l201514 Siqi Li added a comment - The latest patch can be applied to 2.6.0 branch cleanly
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks Xuan Gong

          Show
          cheersyang Weiwei Yang added a comment - Thanks Xuan Gong
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks Xuan Gong

          Show
          cheersyang Weiwei Yang added a comment - Thanks Xuan Gong
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2145 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2145/)
          YARN-3526. ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2145 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2145/ ) YARN-3526 . ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #197 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/197/)
          YARN-3526. ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #197 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/197/ ) YARN-3526 . ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/187/)
          YARN-3526. ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/187/ ) YARN-3526 . ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2127 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2127/)
          YARN-3526. ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2127 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2127/ ) YARN-3526 . ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #929 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/929/)
          YARN-3526. ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #929 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/929/ ) YARN-3526 . ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #198 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/198/)
          YARN-3526. ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #198 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/198/ ) YARN-3526 . ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7845 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7845/)
          YARN-3526. ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7845 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7845/ ) YARN-3526 . ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang (xgong: rev b0ad644083a0dfae3a39159ac88b6fc09d846371) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java
          Hide
          xgong Xuan Gong added a comment -

          Committed into trunk/branch-2/branch-2.7. Thanks, Weiwei Yang.

          Show
          xgong Xuan Gong added a comment - Committed into trunk/branch-2/branch-2.7. Thanks, Weiwei Yang .
          Hide
          xgong Xuan Gong added a comment -

          Thanks, Weiwei Yang

          +1 LGTM. Will commit it later today if nobody has any other comments

          Show
          xgong Xuan Gong added a comment - Thanks, Weiwei Yang +1 LGTM. Will commit it later today if nobody has any other comments
          Hide
          cheersyang Weiwei Yang added a comment -

          Any more suggestion to the patch ? I think it is ready for commit.

          Show
          cheersyang Weiwei Yang added a comment - Any more suggestion to the patch ? I think it is ready for commit.
          Hide
          cheersyang Weiwei Yang added a comment -

          BTW, the test case was successful if I reserved the changes that YARN-2605 made. The only thing left is fixing YARN-3601 to remove the ignore mark.

          Show
          cheersyang Weiwei Yang added a comment - BTW, the test case was successful if I reserved the changes that YARN-2605 made. The only thing left is fixing YARN-3601 to remove the ignore mark.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Vinod

          I added the test case in TestRMFailover.testRMWebAppRedirect as below

          + header = getHeader("Refresh", rm2Url + "/proxy/" + fakeAppId);
          + assertEquals(null, header);

          when I gave a fake app ID, it will not return me a redirect link, this tests the coverage of embedded proxy server. (Now it is ignored because YARN-3601 is not yet resolved). The standalone mode can be tested in testWebAppProxyInStandAloneMode, so not necessary to add more.

          Show
          cheersyang Weiwei Yang added a comment - Hello Vinod I added the test case in TestRMFailover.testRMWebAppRedirect as below + header = getHeader("Refresh", rm2Url + "/proxy/" + fakeAppId); + assertEquals(null, header); when I gave a fake app ID, it will not return me a redirect link, this tests the coverage of embedded proxy server. (Now it is ignored because YARN-3601 is not yet resolved). The standalone mode can be tested in testWebAppProxyInStandAloneMode, so not necessary to add more.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          I uploaded a new patch, I added test case into existing class TestRMFailover.testRMWebAppRedirect, where I believe that is the best place for it. However I found this method is marked as "Ignore" since YARN-2605 was committed.

          I tried to run the test case by reverting the changes YARN-2605 made, it works fine. But with the changes, I got NPEs. I created another issue to fix this unit test, need to discuss with Xuan Gong. The JIRA number is YARN-3601.

          Where is your test-case then? Can we add it here and let it be ignored till we have YARN-3601?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - I uploaded a new patch, I added test case into existing class TestRMFailover.testRMWebAppRedirect, where I believe that is the best place for it. However I found this method is marked as "Ignore" since YARN-2605 was committed. I tried to run the test case by reverting the changes YARN-2605 made, it works fine. But with the changes, I got NPEs. I created another issue to fix this unit test, need to discuss with Xuan Gong. The JIRA number is YARN-3601 . Where is your test-case then? Can we add it here and let it be ignored till we have YARN-3601 ?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Looks good to to me. Vinod?

          (ps: don't worry about whitespace in future. we just use git apply --whitespace fix when taking up the patch —let the machines to the work.

          Show
          stevel@apache.org Steve Loughran added a comment - Looks good to to me. Vinod? (ps: don't worry about whitespace in future. we just use git apply --whitespace fix when taking up the patch —let the machines to the work.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 42s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 36s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 15s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 58s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 6m 52s Tests passed in hadoop-yarn-client.
          +1 yarn tests 52m 11s Tests passed in hadoop-yarn-server-resourcemanager.
              96m 46s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732139/YARN-3526.002.patch
          Optional Tests javac unit findbugs checkstyle javadoc
          git revision trunk / 3d28611
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/7876/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7876/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7876/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7876/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 15s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 58s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 6m 52s Tests passed in hadoop-yarn-client. +1 yarn tests 52m 11s Tests passed in hadoop-yarn-server-resourcemanager.     96m 46s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732139/YARN-3526.002.patch Optional Tests javac unit findbugs checkstyle javadoc git revision trunk / 3d28611 hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/7876/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7876/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7876/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7876/console This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Fixed trailing white spaces

          Show
          cheersyang Weiwei Yang added a comment - Fixed trailing white spaces
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 4s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 27s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 14s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 0s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 7m 2s Tests passed in hadoop-yarn-client.
          -1 yarn tests 48m 17s Tests failed in hadoop-yarn-server-resourcemanager.
              93m 17s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731481/YARN-3526.001.patch
          Optional Tests javac unit findbugs checkstyle javadoc
          git revision trunk / cd6b26c
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7812/artifact/patchprocess/whitespace.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7812/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7812/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 14s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 0s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 7m 2s Tests passed in hadoop-yarn-client. -1 yarn tests 48m 17s Tests failed in hadoop-yarn-server-resourcemanager.     93m 17s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs   hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731481/YARN-3526.001.patch Optional Tests javac unit findbugs checkstyle javadoc git revision trunk / cd6b26c whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7812/artifact/patchprocess/whitespace.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7812/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7812/console This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Steve Loughran and Vinod Kumar Vavilapalli

          I uploaded a new patch, I added test case into existing class TestRMFailover.testRMWebAppRedirect, where I believe that is the best place for it. However I found this method is marked as "Ignore" since YARN-2605 was committed.

          I tried to run the test case by reverting the changes YARN-2605 made, it works fine. But with the changes, I got NPEs. I created another issue to fix this unit test, need to discuss with Xuan Gong. The JIRA number is YARN-3601.

          Show
          cheersyang Weiwei Yang added a comment - Hello Steve Loughran and Vinod Kumar Vavilapalli I uploaded a new patch, I added test case into existing class TestRMFailover.testRMWebAppRedirect, where I believe that is the best place for it. However I found this method is marked as "Ignore" since YARN-2605 was committed. I tried to run the test case by reverting the changes YARN-2605 made, it works fine. But with the changes, I got NPEs. I created another issue to fix this unit test, need to discuss with Xuan Gong . The JIRA number is YARN-3601 .
          Hide
          cheersyang Weiwei Yang added a comment -

          Hi Vinod

          Sure let me add a test case.

          Show
          cheersyang Weiwei Yang added a comment - Hi Vinod Sure let me add a test case.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Weiwei Yang, assigning this to you. Please consider writing a test-case..

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Weiwei Yang , assigning this to you. Please consider writing a test-case..
          Hide
          stevel@apache.org Steve Loughran added a comment -

          It seems to me that the way to do a test case would be to tease out the logic into its own class/method & test that, outside of a jetty. You can't do any live tests on a single machine which exhibit the problem, as all share the same IPAddr

          Show
          stevel@apache.org Steve Loughran added a comment - It seems to me that the way to do a test case would be to tease out the logic into its own class/method & test that, outside of a jetty. You can't do any live tests on a single machine which exhibit the problem, as all share the same IPAddr
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Is it possible for you to right a test-case? The thing we want to ensure is that the links work in both cases of embedded and non-embedded proxy-server.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Is it possible for you to right a test-case? The thing we want to ensure is that the links work in both cases of embedded and non-embedded proxy-server.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I see: it's the AM filter side of the proxy. Makes sense. I can see that both are needed

          Show
          stevel@apache.org Steve Loughran added a comment - I see: it's the AM filter side of the proxy. Makes sense. I can see that both are needed
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 50s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 44s There were no new javac warning messages.
          +1 javadoc 9m 46s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 5m 27s There were no new checkstyle issues.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 17s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 51m 37s Tests passed in hadoop-yarn-server-resourcemanager.
              93m 12s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727584/YARN-3526.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / baf8bc6
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7470/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7470/testReport/
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7470/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 5m 27s There were no new checkstyle issues. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 17s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 51m 37s Tests passed in hadoop-yarn-server-resourcemanager.     93m 12s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727584/YARN-3526.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / baf8bc6 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7470/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7470/testReport/ Console output https://builds.apache.org/job/PreCommit-YARN-Build/7470/console This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          By default, on a QJM cluster, application master proxy server runs on the RM specified in yarn.resourcemanager.webapp.address. If this RM happens to be the standby, the RMWebAppFilter will filter the request to active RM, this causes the infinite loop on the web page.
          The filter should not filter the requests to the proxy server because it is a different service than RM, and it could be a standalone service.

          Show
          cheersyang Weiwei Yang added a comment - By default, on a QJM cluster, application master proxy server runs on the RM specified in yarn.resourcemanager.webapp.address. If this RM happens to be the standby, the RMWebAppFilter will filter the request to active RM, this causes the infinite loop on the web page. The filter should not filter the requests to the proxy server because it is a different service than RM, and it could be a standalone service.
          Hide
          cheersyang Weiwei Yang added a comment -

          I don't think this is a duplicate of YARN-2605. YARN-2605 fixes the issues in REST API to avoid meta-refresh.
          But this JIRA is about the issue when application master proxy server runs on the standby RM, the traffic to the proxy server gets incorrectly redirected. I have attached a patch to fix this. Please help to review.

          Show
          cheersyang Weiwei Yang added a comment - I don't think this is a duplicate of YARN-2605 . YARN-2605 fixes the issues in REST API to avoid meta-refresh. But this JIRA is about the issue when application master proxy server runs on the standby RM, the traffic to the proxy server gets incorrectly redirected. I have attached a patch to fix this. Please help to review.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          looks like a duplicate of YARN-2605

          Show
          stevel@apache.org Steve Loughran added a comment - looks like a duplicate of YARN-2605

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              cheersyang Weiwei Yang
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development