Details

    • Target Version/s:

      Description

      In YARN-3413, yarn cluster CLI returns NodeLabel instead of String, we should make the same change in REST API side to make them consistency.

      1. 0001-YARN-3521.patch
        15 kB
        Sunil G
      2. 0002-YARN-3521.patch
        28 kB
        Sunil G
      3. 0003-YARN-3521.patch
        31 kB
        Sunil G
      4. 0004-YARN-3521.patch
        31 kB
        Sunil G
      5. 0005-YARN-3521.patch
        37 kB
        Sunil G
      6. 0006-YARN-3521.patch
        46 kB
        Sunil G
      7. 0007-YARN-3521.patch
        46 kB
        Sunil G

        Activity

        Hide
        sunilg Sunil G added a comment -

        Recently have done few work in Rest. I wud like to take over, pls reassign otherwise.

        Show
        sunilg Sunil G added a comment - Recently have done few work in Rest. I wud like to take over, pls reassign otherwise.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Sunil G, thanks for taking this, it's yours

        Show
        leftnoteasy Wangda Tan added a comment - Sunil G , thanks for taking this, it's yours
        Hide
        leftnoteasy Wangda Tan added a comment -

        To make REST API compatible with CLI as well as YarnClient, I suggest to make following changes:
        1) NodeLabelsInfo -> NodeLabelsName
        2) Create a new NodeLabelsInfo contains String name and boolean exclusivity, potentially more fields in the future.
        3) Only change add/getClusterNodeLabels to use the new NodeLabelsInfo, and other uses NodeLabelsName.

        Thoughts?

        Show
        leftnoteasy Wangda Tan added a comment - To make REST API compatible with CLI as well as YarnClient, I suggest to make following changes: 1) NodeLabelsInfo -> NodeLabelsName 2) Create a new NodeLabelsInfo contains String name and boolean exclusivity, potentially more fields in the future. 3) Only change add/getClusterNodeLabels to use the new NodeLabelsInfo, and other uses NodeLabelsName. Thoughts?
        Hide
        sunilg Sunil G added a comment -

        Yes. Wangda Tan
        This change suggestion looks fine for me. I will update patch on same.

        Also i will rename the Ticket name based on the last update.

        Show
        sunilg Sunil G added a comment - Yes. Wangda Tan This change suggestion looks fine for me. I will update patch on same. Also i will rename the Ticket name based on the last update.
        Hide
        sunilg Sunil G added a comment -

        Attaching an initial version. Wangda Tan pls check the same as I have the changed the method interface of getClusterNodeLabels and addToClusterNodeLabels to pass argument to List<NodeLabelInfo>.

        Show
        sunilg Sunil G added a comment - Attaching an initial version. Wangda Tan pls check the same as I have the changed the method interface of getClusterNodeLabels and addToClusterNodeLabels to pass argument to List<NodeLabelInfo> .
        Hide
        leftnoteasy Wangda Tan added a comment -

        Hi Sunil,
        Thanks for working on this, some comments:

        NodelabelsInfo: (It should be NodeLabelInfo, right?)

        • nodeLabelName: don't need call new String() since it will be always initialized, and I prefer to call it "name"
        • nodeLabelExclusivity -> exclusivity
        • Also getter
        • Setters are not used by anybody, could be removed
        • I'm not sure if you need add an empty constructure to make // JAXB needs this like other infos?
        • Could add a constructor of NodeLabelsInfo receives NodeLabel which will be used by RMWebServices
        • We may need to add a separated NodeLabelsInfo and it contains ArrayList of NodeLabelInfo

        NodeToLabelsInfo -> NodeToLabelNames

        addToClusterNodeLabels now receives Set as parameter, I'm not sure if it works, could you add test to verify add/get node labels? Now TestRMWebServicesNodeLabels will fail

        Show
        leftnoteasy Wangda Tan added a comment - Hi Sunil, Thanks for working on this, some comments: NodelabelsInfo: (It should be NodeLabelInfo, right?) nodeLabelName: don't need call new String() since it will be always initialized, and I prefer to call it "name" nodeLabelExclusivity -> exclusivity Also getter Setters are not used by anybody, could be removed I'm not sure if you need add an empty constructure to make // JAXB needs this like other infos? Could add a constructor of NodeLabelsInfo receives NodeLabel which will be used by RMWebServices We may need to add a separated NodeLabelsInfo and it contains ArrayList of NodeLabelInfo NodeToLabelsInfo -> NodeToLabelNames addToClusterNodeLabels now receives Set as parameter, I'm not sure if it works, could you add test to verify add/get node labels? Now TestRMWebServicesNodeLabels will fail
        Hide
        sunilg Sunil G added a comment -

        Thank you Wangda Tan for sharing the comments.
        Pls find an updated patch addressing comments.

        Pls check the same and let me know your thoughts.

        Show
        sunilg Sunil G added a comment - Thank you Wangda Tan for sharing the comments. Pls find an updated patch addressing comments. Pls check the same and let me know your thoughts.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Kick Jenkins

        Show
        leftnoteasy Wangda Tan added a comment - Kick Jenkins
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        -1 whitespace 0m 0s The patch has 19 line(s) that end in whitespace.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 5m 29s The applied patch generated 3 additional checkstyle issues.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        -1 yarn tests 63m 37s Tests failed in hadoop-yarn-server-resourcemanager.
            104m 45s  



        Reason Tests
        Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729530/0002-YARN-3521.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / e2e8f77
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7557/artifact/patchprocess/whitespace.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7557/artifact/patchprocess/checkstyle-result-diff.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7557/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7557/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7557/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 whitespace 0m 0s The patch has 19 line(s) that end in whitespace. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 29s The applied patch generated 3 additional checkstyle issues. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 yarn tests 63m 37s Tests failed in hadoop-yarn-server-resourcemanager.     104m 45s   Reason Tests Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729530/0002-YARN-3521.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e2e8f77 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7557/artifact/patchprocess/whitespace.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7557/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7557/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7557/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7557/console This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Sunil G, Thanks for updating, just tried it locally, some comments:
        1) it seems the structure of REST response is not correct for NodeLabelsInfo:

        <nodeLabelsInfo>
        <nodeLabelsInfo>
        <name>x</name>
        <exclusity>true</exclusity>
        </nodeLabelsInfo>
        <nodeLabelsInfo>
        <name>y</name>
        <exclusity>true</exclusity>
        </nodeLabelsInfo>
        </nodeLabelsInfo>
        

        It should be nodeLabelInfo instead of nodeLabelsInfo, could you solve this issue?

        2) It's better to add a test for specifying exclusivity when adding node labels. (Verify exclusivity added to NodeLabelsManager).

        Show
        leftnoteasy Wangda Tan added a comment - Sunil G , Thanks for updating, just tried it locally, some comments: 1) it seems the structure of REST response is not correct for NodeLabelsInfo: <nodeLabelsInfo> <nodeLabelsInfo> <name>x</name> <exclusity> true </exclusity> </nodeLabelsInfo> <nodeLabelsInfo> <name>y</name> <exclusity> true </exclusity> </nodeLabelsInfo> </nodeLabelsInfo> It should be nodeLabelInfo instead of nodeLabelsInfo , could you solve this issue? 2) It's better to add a test for specifying exclusivity when adding node labels. (Verify exclusivity added to NodeLabelsManager).
        Hide
        sunilg Sunil G added a comment -

        Thank you Wangda Tan for the comments.

        I am uploading now an interim patch which has the new test case. However some more change is needed to correct xml structure, for that i ll upload another patch.

        Show
        sunilg Sunil G added a comment - Thank you Wangda Tan for the comments. I am uploading now an interim patch which has the new test case. However some more change is needed to correct xml structure, for that i ll upload another patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 49s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 44s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 46s The applied patch generated 42 new checkstyle issues (total was 320, now 348).
        -1 whitespace 0m 2s The patch has 15 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 13s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 52m 18s Tests passed in hadoop-yarn-server-resourcemanager.
            88m 58s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729744/0003-YARN-3521.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1b3b9e5
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7570/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7570/artifact/patchprocess/whitespace.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7570/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7570/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7570/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 49s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 46s The applied patch generated 42 new checkstyle issues (total was 320, now 348). -1 whitespace 0m 2s The patch has 15 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 13s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 52m 18s Tests passed in hadoop-yarn-server-resourcemanager.     88m 58s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729744/0003-YARN-3521.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1b3b9e5 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7570/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7570/artifact/patchprocess/whitespace.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7570/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7570/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7570/console This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks for update, Sunil G,
        Latest patch LGTM, one minor thing is changes of TestNodeLabelContainerAllocation could be reverted, I can do this while committing.

        +1, will wait for few days to see if there's any other comments.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks for update, Sunil G , Latest patch LGTM, one minor thing is changes of TestNodeLabelContainerAllocation could be reverted, I can do this while committing. +1, will wait for few days to see if there's any other comments.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Typo in NodeLabelInfo.exclusity. Should be exclusivity.

        Why are we not dropping the name-only records (NodeLabelsName, NodeToLabelsName) and instead use objects in the get APIs? Except for removeFromCluserNodeLabels/replaceLabelsOnNode operations, where we can simply take in a list/set of names?

        Did we ever call these APIs stable? If not, we should simply change them to use objects.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Typo in NodeLabelInfo.exclusity. Should be exclusivity. Why are we not dropping the name-only records (NodeLabelsName, NodeToLabelsName) and instead use objects in the get APIs? Except for removeFromCluserNodeLabels/replaceLabelsOnNode operations, where we can simply take in a list/set of names? Did we ever call these APIs stable? If not, we should simply change them to use objects.
        Hide
        sunilg Sunil G added a comment -

        1.

        Should be exclusivity.

        Yes. I updated the same

        2.

        Did we ever call these APIs stable?

        No. I have changed to a NodeLabelsInfo object and added new getter which can supply list/set of string names.

        3.
        Why are we not dropping the name-only records?
        I have removed NodeLabelsName. And instead use NodeLabelsInfo, also added a new getter which can give back String of label names. NodeToLabelsName is renamed as NodeToLabelsInfo and internally it also uses NodeLabelInfo.

        Show
        sunilg Sunil G added a comment - 1. Should be exclusivity. Yes. I updated the same 2. Did we ever call these APIs stable? No. I have changed to a NodeLabelsInfo object and added new getter which can supply list/set of string names. 3. Why are we not dropping the name-only records? I have removed NodeLabelsName . And instead use NodeLabelsInfo , also added a new getter which can give back String of label names. NodeToLabelsName is renamed as NodeToLabelsInfo and internally it also uses NodeLabelInfo.
        Hide
        sunilg Sunil G added a comment -

        Vinod Kumar Vavilapalli and Wangda Tan
        Pls share your thoughts on this updated patch.

        IMO I also feel that NodeLabelManager apis can use Object rather than Strings. Admin interface can take this conversion logic.

        Show
        sunilg Sunil G added a comment - Vinod Kumar Vavilapalli and Wangda Tan Pls share your thoughts on this updated patch. IMO I also feel that NodeLabelManager apis can use Object rather than Strings. Admin interface can take this conversion logic.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Sunil G, Make sense to me,

        IMO I also feel that NodeLabelManager apis can use Object rather than Strings. Admin interface can take this conversion logic.

        Sorry I didn't get this, currently addToCluserNodeLabels is already takes object instead of String and you're using it in your patch.

        Show
        leftnoteasy Wangda Tan added a comment - Sunil G , Make sense to me, IMO I also feel that NodeLabelManager apis can use Object rather than Strings. Admin interface can take this conversion logic. Sorry I didn't get this, currently addToCluserNodeLabels is already takes object instead of String and you're using it in your patch.
        Hide
        sunilg Sunil G added a comment -

        Wangda Tan Yes, Its not a valid point. replaceLabelsOnNode and removeFromClusterNodeLabels doesn't need node label object, name is enough. Pls discard my earlier comment.

        Show
        sunilg Sunil G added a comment - Wangda Tan Yes, Its not a valid point. replaceLabelsOnNode and removeFromClusterNodeLabels doesn't need node label object, name is enough. Pls discard my earlier comment.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Sunil G,
        Thanks for updating, I have a offline sync with Vinod about using object or string in API, some suggestions:

        • addToClusterNodeLabel should be object, (you've done this in your patch)
        • getLabelsOnNode, getNodeToLabels, getLabelsToNodes should use object, this will make user can easily understand attributes of labels on nodes without calling getClusterNodeLabels. (You have done some of them, but getLabelsToNodes should be updated as well)
        • replace/remove should use list of label name only, label name is unique key of node labels, using NodeLabelInfo object here is unnecessary.
        • I found in your patch, when calling getNodeToLabels, it returns NodeLabelInfo with default attributes, we can fix this in separated patch (we need make changes to NodeLabelsManager too)
        • RPC API should be consistent with this, should be addressed in a separated JIRA.

        I'm fine with dropping NodeLabelNames as well, if it can keep the REST returned structure clean .

        Show
        leftnoteasy Wangda Tan added a comment - Sunil G , Thanks for updating, I have a offline sync with Vinod about using object or string in API, some suggestions: addToClusterNodeLabel should be object, (you've done this in your patch) getLabelsOnNode, getNodeToLabels, getLabelsToNodes should use object, this will make user can easily understand attributes of labels on nodes without calling getClusterNodeLabels. (You have done some of them, but getLabelsToNodes should be updated as well) replace/remove should use list of label name only, label name is unique key of node labels, using NodeLabelInfo object here is unnecessary. I found in your patch, when calling getNodeToLabels, it returns NodeLabelInfo with default attributes, we can fix this in separated patch (we need make changes to NodeLabelsManager too) RPC API should be consistent with this, should be addressed in a separated JIRA. I'm fine with dropping NodeLabelNames as well, if it can keep the REST returned structure clean .
        Hide
        sunilg Sunil G added a comment -

        Thank You Wangda Tan for the detailed comments.

        I have updated patch as per same.

        Few notes:
        1. NodeLabelsName and NodeToLabelsName classes are needed for replace and remove apis. Else as you mentioned, REST apis wont be clean enough. I hope this is fine.
        2.

        getLabelsToNodes should use object

        >> Done
        3.

        replace/remove should use list of label name only

        >> Done

        Show
        sunilg Sunil G added a comment - Thank You Wangda Tan for the detailed comments. I have updated patch as per same. Few notes: 1. NodeLabelsName and NodeToLabelsName classes are needed for replace and remove apis. Else as you mentioned, REST apis wont be clean enough. I hope this is fine. 2. getLabelsToNodes should use object >> Done 3. replace/remove should use list of label name only >> Done
        Hide
        sunilg Sunil G added a comment -

        Kicking Jenkins.

        Show
        sunilg Sunil G added a comment - Kicking Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 0s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 41s There were no new javac warning messages.
        +1 javadoc 9m 51s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 47s The applied patch generated 14 new checkstyle issues (total was 58, now 69).
        -1 whitespace 0m 3s The patch has 19 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 17s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 57m 30s Tests passed in hadoop-yarn-server-resourcemanager.
            94m 47s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730808/0005-YARN-3521.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a583a40
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7734/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7734/artifact/patchprocess/whitespace.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7734/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7734/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7734/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 51s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 47s The applied patch generated 14 new checkstyle issues (total was 58, now 69). -1 whitespace 0m 3s The patch has 19 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 17s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 57m 30s Tests passed in hadoop-yarn-server-resourcemanager.     94m 47s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730808/0005-YARN-3521.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a583a40 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7734/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7734/artifact/patchprocess/whitespace.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7734/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7734/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7734/console This message was automatically generated.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        I'm fine with dropping NodeLabelNames as well, if it can keep the REST returned structure clean

        1. NodeLabelsName and NodeToLabelsName classes are needed for replace and remove apis. Else as you mentioned, REST apis wont be clean enough. I hope this is fine.

        We can directly pass a String or a set of Strings as arguments? See getLabelsToNodes() web-service for example.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - I'm fine with dropping NodeLabelNames as well, if it can keep the REST returned structure clean 1. NodeLabelsName and NodeToLabelsName classes are needed for replace and remove apis. Else as you mentioned, REST apis wont be clean enough. I hope this is fine. We can directly pass a String or a set of Strings as arguments? See getLabelsToNodes() web-service for example.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Vinod Kumar Vavilapalli, I just checked, we still need NodeLabelsName/NodeToLabelsName, since JAXB doesn't support nested Java data structure, for example: Map<String, List<String>> is not supported. Instead, you have to use Map<String, WrappedList>, NodeLabelsName is the WrappedList here.

        Show
        leftnoteasy Wangda Tan added a comment - Vinod Kumar Vavilapalli , I just checked, we still need NodeLabelsName/NodeToLabelsName, since JAXB doesn't support nested Java data structure, for example: Map<String, List<String>> is not supported. Instead, you have to use Map<String, WrappedList>, NodeLabelsName is the WrappedList here.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Just tried to deploy and see the REST API result, some comments:

        1. label-mappings

        <entry>
        <key>
        <name>y</name>
        <exclusivity>true</exclusivity>
        </key>
        <value>
        <nodeIDsList>host2:0</nodeIDsList>
        </value>
        </entry>
        

        I think it's better to rename nodeIDsList to node, so the result will be

        ...
        <value>
        	<node>host1:1234</node>
        	<node>host2:5678</node>
        </value>
        

        2. nodeLabelsInfo:
        Now it is:

        <nodeLabelsInfo>
        <nodeLabels>
        <name>x</name>
        <exclusivity>true</exclusivity>
        </nodeLabels>
        <nodeLabels>
        <name>y</name>
        <exclusivity>true</exclusivity>
        </nodeLabels>
        </nodeLabelsInfo>
        

        I suggest to change

          @XmlElement(name = "nodeLabelsInfo")
          protected ArrayList<NodeLabelInfo> nodeLabelsInfo =
              new ArrayList<NodeLabelInfo>();
        

        To
        name="nodeLabelInfo"

        So the result will be:

        <nodeLabelsInfo>
            <nodeLabelInfo>
                <name>x</name>
                <exclusivity>true</exclusivity>
            </nodeLabelInfo>
            <nodeLabelInfo>
                <name>y</name>
                <exclusivity>true</exclusivity>
            </nodeLabelInfo>
        </nodeLabelsInfo>
        

        3. nodeToLabelsName:
        I suggest to add a @XmlRootElement(name = "nodeLabelName") to NodeLabelsName.nodeLabels to make the result to be:

        <nodeToLabelsName>
            <nodeToLabels>
                <entry>
                    <key>node1</key>
                    <value>
                        <nodeLabelName>x</nodeLabelName>
                    </value>
                </entry>
                <entry>
                    <key>node2</key>
                    <value>
                        <nodeLabelName>y</nodeLabelName>
                    </value>
                </entry>
                <entry>
                    <key>node3</key>
                    <value>
                        <nodeLabelName>y</nodeLabelName>
                        <nodeLabelName>z</nodeLabelName>
                    </value>
                </entry>
            </nodeToLabels>
        </nodeToLabelsName>
        
        Show
        leftnoteasy Wangda Tan added a comment - Just tried to deploy and see the REST API result, some comments: 1. label-mappings <entry> <key> <name>y</name> <exclusivity> true </exclusivity> </key> <value> <nodeIDsList>host2:0</nodeIDsList> </value> </entry> I think it's better to rename nodeIDsList to node , so the result will be ... <value> <node>host1:1234</node> <node>host2:5678</node> </value> 2. nodeLabelsInfo: Now it is: <nodeLabelsInfo> <nodeLabels> <name>x</name> <exclusivity> true </exclusivity> </nodeLabels> <nodeLabels> <name>y</name> <exclusivity> true </exclusivity> </nodeLabels> </nodeLabelsInfo> I suggest to change @XmlElement(name = "nodeLabelsInfo" ) protected ArrayList<NodeLabelInfo> nodeLabelsInfo = new ArrayList<NodeLabelInfo>(); To name="nodeLabelInfo" So the result will be: <nodeLabelsInfo> <nodeLabelInfo> <name>x</name> <exclusivity> true </exclusivity> </nodeLabelInfo> <nodeLabelInfo> <name>y</name> <exclusivity> true </exclusivity> </nodeLabelInfo> </nodeLabelsInfo> 3. nodeToLabelsName: I suggest to add a @XmlRootElement(name = "nodeLabelName") to NodeLabelsName.nodeLabels to make the result to be: <nodeToLabelsName> <nodeToLabels> <entry> <key>node1</key> <value> <nodeLabelName>x</nodeLabelName> </value> </entry> <entry> <key>node2</key> <value> <nodeLabelName>y</nodeLabelName> </value> </entry> <entry> <key>node3</key> <value> <nodeLabelName>y</nodeLabelName> <nodeLabelName>z</nodeLabelName> </value> </entry> </nodeToLabels> </nodeToLabelsName>
        Hide
        leftnoteasy Wangda Tan added a comment -

        Some more comments:

        • NodeLabelsName is not necessary for removeFromCluserNodeLabels/replaceLabelsOnNode, use ArrayList seems enough and clean to me
        • replaceLabelsOnNodes can take List of NodeToLabelsEntry, which contains String nodeId and ArrayList<String> labels, this will be simpler than maintaining two objects: NodeToLabelsName and NodeLabelsName to me.

        Sounds good? Sunil G/Vinod Kumar Vavilapalli?

        Show
        leftnoteasy Wangda Tan added a comment - Some more comments: NodeLabelsName is not necessary for removeFromCluserNodeLabels/replaceLabelsOnNode, use ArrayList seems enough and clean to me replaceLabelsOnNodes can take List of NodeToLabelsEntry, which contains String nodeId and ArrayList<String> labels, this will be simpler than maintaining two objects: NodeToLabelsName and NodeLabelsName to me. Sounds good? Sunil G / Vinod Kumar Vavilapalli ?
        Hide
        sunilg Sunil G added a comment -

        Hi Wangda Tan
        List of NodeToLabelsEntry will also have issues. By default queryParams can have primitive types. If we have objects as list, then these objects need to have constructor for string. In here, we need String and List<String> for ctor.

        Show
        sunilg Sunil G added a comment - Hi Wangda Tan List of NodeToLabelsEntry will also have issues. By default queryParams can have primitive types. If we have objects as list, then these objects need to have constructor for string. In here, we need String and List<String> for ctor.
        Hide
        sunilg Sunil G added a comment -

        Hi Wangda Tan Vinod Kumar Vavilapalli
        Uploading a newer version of patch. Addressed all the comments from Wangda except the NodeToLabelsName and NodeLabelsName..

        NodeToLabelsName now contains a List of NodeToLabelEntry, and I use this class as the parameter for replaceNodeLabels api.
        I tried using List of NodeToLabelEntry w/o the wrapper class called NodeToLabelsName ,but some how i was not able to test this from test case.

        Pls suggest you thoughts on using this outer wrapper class rather List of NodeToLabelEntry

        Show
        sunilg Sunil G added a comment - Hi Wangda Tan Vinod Kumar Vavilapalli Uploading a newer version of patch. Addressed all the comments from Wangda except the NodeToLabelsName and NodeLabelsName.. NodeToLabelsName now contains a List of NodeToLabelEntry, and I use this class as the parameter for replaceNodeLabels api. I tried using List of NodeToLabelEntry w/o the wrapper class called NodeToLabelsName ,but some how i was not able to test this from test case. Pls suggest you thoughts on using this outer wrapper class rather List of NodeToLabelEntry
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 47s The applied patch generated 17 new checkstyle issues (total was 61, now 66).
        -1 whitespace 0m 5s The patch has 18 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 53m 26s Tests passed in hadoop-yarn-server-resourcemanager.
            90m 6s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731449/0006-YARN-3521.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7b1ea9c
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7802/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7802/artifact/patchprocess/whitespace.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7802/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7802/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7802/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 47s The applied patch generated 17 new checkstyle issues (total was 61, now 66). -1 whitespace 0m 5s The patch has 18 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 53m 26s Tests passed in hadoop-yarn-server-resourcemanager.     90m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731449/0006-YARN-3521.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7b1ea9c checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7802/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7802/artifact/patchprocess/whitespace.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7802/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7802/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7802/console This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Sunil G,
        Patch generally looks good, I think it's fine if adding a wrapper class is unavoidable.

        One minor comment is, could you update NodeToLabelsName to NodeToLabelsEntryList?

        Thanks,

        Show
        leftnoteasy Wangda Tan added a comment - Sunil G , Patch generally looks good, I think it's fine if adding a wrapper class is unavoidable. One minor comment is, could you update NodeToLabelsName to NodeToLabelsEntryList ? Thanks,
        Hide
        sunilg Sunil G added a comment -

        Thank you Wangda Tan
        Uploading a new patch addressing the comments.

        Show
        sunilg Sunil G added a comment - Thank you Wangda Tan Uploading a new patch addressing the comments.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 49s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 43s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 50s The applied patch generated 5 new checkstyle issues (total was 61, now 54).
        -1 whitespace 0m 6s The patch has 22 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 52m 25s Tests passed in hadoop-yarn-server-resourcemanager.
            89m 15s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731679/0007-YARN-3521.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6471d18
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7844/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7844/artifact/patchprocess/whitespace.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7844/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7844/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7844/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 49s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 43s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 50s The applied patch generated 5 new checkstyle issues (total was 61, now 54). -1 whitespace 0m 6s The patch has 22 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 52m 25s Tests passed in hadoop-yarn-server-resourcemanager.     89m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731679/0007-YARN-3521.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6471d18 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7844/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7844/artifact/patchprocess/whitespace.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7844/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7844/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7844/console This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks for updating, Sunil G,
        Latest patch LGTM, +1.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks for updating, Sunil G , Latest patch LGTM, +1.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to branch-2/trunk, thanks Sunil G working on this and review from Vinod Kumar Vavilapalli.

        Show
        leftnoteasy Wangda Tan added a comment - Committed to branch-2/trunk, thanks Sunil G working on this and review from Vinod Kumar Vavilapalli .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7821 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7821/)
        YARN-3521. Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7821 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7821/ ) YARN-3521 . Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        Hide
        sunilg Sunil G added a comment -

        Thank you Tan, Wangda for committing the patch and thank you Vinod for the review.

        Show
        sunilg Sunil G added a comment - Thank you Tan, Wangda for committing the patch and thank you Vinod for the review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #927 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/927/)
        YARN-3521. Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #927 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/927/ ) YARN-3521 . Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #196 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/196/)
        YARN-3521. Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #196 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/196/ ) YARN-3521 . Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/195/)
        YARN-3521. Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/195/ ) YARN-3521 . Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2125 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2125/)
        YARN-3521. Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2125 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2125/ ) YARN-3521 . Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/185/)
        YARN-3521. Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/185/ ) YARN-3521 . Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2143 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2143/)
        YARN-3521. Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2143 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2143/ ) YARN-3521 . Support return structured NodeLabel objects in REST API (Sunil G via wangda) (wangda: rev 7f19e7a2549a098236d06b29b7076bb037533f05) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntryList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeLabelInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/NodeToLabelsEntry.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/LabelsToNodesInfo.java
        Hide
        leftnoteasy Wangda Tan added a comment -

        Reopen to change to correct resolution

        Show
        leftnoteasy Wangda Tan added a comment - Reopen to change to correct resolution

          People

          • Assignee:
            sunilg Sunil G
            Reporter:
            leftnoteasy Wangda Tan
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development