Description
We need to do some work on yarn top's shell code.
a) Just checking for TERM isn't good enough. We really need to check the return on tput, especially since the output will not be a number but an error string which will likely blow up the java code in horrible ways.
b) All the single bracket tests should be double brackets to force the bash built-in.
c) I'd think I'd rather see the shell portion in a function since it's rather large. This will allow for args, etc, to get local'ized and clean up the case statement.
Attachments
Attachments
Issue Links
- is related to
-
YARN-3348 Add a 'yarn top' tool to help understand cluster usage
-
- Resolved
-