Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3465

Use LinkedHashMap to preserve order of resource requests

        Details

        • Target Version/s:
        • Hadoop Flags:
          Reviewed

          Description

          use LinkedHashMap to keep the order of LocalResourceRequest in ContainerImpl

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            kasha Karthik Kambatla added a comment -

            The patch looks benign to me. +1, pending Jenkins.

            Show
            kasha Karthik Kambatla added a comment - The patch looks benign to me. +1, pending Jenkins.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12724015/YARN-3465.000.patch
            against trunk revision b1e0590.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

            Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7266//testReport/
            Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7266//console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724015/YARN-3465.000.patch against trunk revision b1e0590. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7266//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7266//console This message is automatically generated.
            Hide
            Permalink
            kasha Karthik Kambatla added a comment -

            Thanks Zhihai. Just committed this to trunk and branch-2.

            Show
            kasha Karthik Kambatla added a comment - Thanks Zhihai. Just committed this to trunk and branch-2.
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-trunk-Commit #7545 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7545/)
            YARN-3465. Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485)

            • hadoop-yarn-project/CHANGES.txt
            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7545 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7545/ ) YARN-3465 . Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/)
            YARN-3465. Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485)

            • hadoop-yarn-project/CHANGES.txt
            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/ ) YARN-3465 . Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/)
            YARN-3465. Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485)

            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/ ) YARN-3465 . Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/)
            YARN-3465. Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485)

            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/ ) YARN-3465 . Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/892/)
            YARN-3465. Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485)

            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/892/ ) YARN-3465 . Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/)
            YARN-3465. Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485)

            • hadoop-yarn-project/CHANGES.txt
            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/ ) YARN-3465 . Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/)
            YARN-3465. Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485)

            • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/ ) YARN-3465 . Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha) (kasha: rev 6495940eae09418a939882a8955845f9241a6485) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            kasha Karthik Kambatla added a comment -

            Committed this to branch-2.7 as well.

            Show
            kasha Karthik Kambatla added a comment - Committed this to branch-2.7 as well.
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-trunk-Commit #7688 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7688/)
            Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e)

            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7688 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7688/ ) Update CHANGES.txt - Pulled in YARN-3465 , YARN-3516 , and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk #2109 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2109/)
            Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e)

            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2109 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2109/ ) Update CHANGES.txt - Pulled in YARN-3465 , YARN-3516 , and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/168/)
            Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e)

            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/168/ ) Update CHANGES.txt - Pulled in YARN-3465 , YARN-3516 , and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #177 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/177/)
            Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e)

            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #177 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/177/ ) Update CHANGES.txt - Pulled in YARN-3465 , YARN-3516 , and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Yarn-trunk #911 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/911/)
            Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e)

            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #911 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/911/ ) Update CHANGES.txt - Pulled in YARN-3465 , YARN-3516 , and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #178 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/178/)
            Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e)

            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #178 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/178/ ) Update CHANGES.txt - Pulled in YARN-3465 , YARN-3516 , and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) hadoop-yarn-project/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2127/)
            Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e)

            • hadoop-yarn-project/CHANGES.txt
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2127/ ) Update CHANGES.txt - Pulled in YARN-3465 , YARN-3516 , and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) hadoop-yarn-project/CHANGES.txt

              People

              • Assignee:
                zxu zhihai xu
                Reporter:
                zxu zhihai xu
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development