Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3460

TestSecureRMRegistryOperations fails with IBM_JAVA

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0, 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Environment:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestSecureRMRegistryOperations failed with JBM IBM JAVA

      mvn test -X -Dtest=org.apache.hadoop.registry.secure.TestSecureRMRegistryOperations

      Module Total Failure Error Skipped
      -------------------------------------------------
      hadoop-yarn-registry 12 0 12 0
      -------------------------------------------------
      Total 12 0 12 0

      With
      javax.security.auth.login.LoginException: Bad JAAS configuration: unrecognized option: isInitiator

      and

      Bad JAAS configuration: unrecognized option: storeKey

      1. HADOOP-11810-1.patch
        9 kB
        pascal oliva
      2. YARN-3460.004.patch
        10 kB
        Chris Douglas
      3. YARN-3460.005.patch
        11 kB
        Chris Douglas
      4. YARN-3460.006.patch
        11 kB
        Chris Douglas
      5. YARN-3460-1.patch
        9 kB
        pascal oliva
      6. YARN-3460-2.patch
        9 kB
        pascal oliva
      7. YARN-3460-3.patch
        9 kB
        pascal oliva

        Issue Links

          Activity

          Hide
          poliva pascal oliva added a comment -

          Tested with SUCESS With IBM JAVA a Open JDK

          Show
          poliva pascal oliva added a comment - Tested with SUCESS With IBM JAVA a Open JDK
          Hide
          poliva pascal oliva added a comment -

          Patch with : git diff --no-prefix trunk > ../HADOOP-11810-1.patch
          tested with : mvn test -X -Dtest=org.apache.hadoop.registry.secure.TestSecureRMRegistryOperations

          Show
          poliva pascal oliva added a comment - Patch with : git diff --no-prefix trunk > ../ HADOOP-11810 -1.patch tested with : mvn test -X -Dtest=org.apache.hadoop.registry.secure.TestSecureRMRegistryOperations
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723668/HADOOP-11810-1.patch
          against trunk revision d27e924.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6070//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6070//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723668/HADOOP-11810-1.patch against trunk revision d27e924. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6070//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6070//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723668/HADOOP-11810-1.patch
          against trunk revision d27e924.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          -1 javac. The applied patch generated 1148 javac compiler warnings (more than the trunk's current 209 warnings).

          -1 javadoc. The javadoc tool appears to have generated 43 warning messages.
          See https://builds.apache.org/job/PreCommit-YARN-Build/7245//artifact/patchprocess/diffJavadocWarnings.txt for details.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7245//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7245//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Javac warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7245//artifact/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7245//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723668/HADOOP-11810-1.patch against trunk revision d27e924. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. -1 javac . The applied patch generated 1148 javac compiler warnings (more than the trunk's current 209 warnings). -1 javadoc . The javadoc tool appears to have generated 43 warning messages. See https://builds.apache.org/job/PreCommit-YARN-Build/7245//artifact/patchprocess/diffJavadocWarnings.txt for details. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7245//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7245//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Javac warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7245//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7245//console This message is automatically generated.
          Hide
          djp Junping Du added a comment -

          A quick comments: can we use "%n" instead of "/n"? The former one is independent of platforms but the later one works only on Linux.

          Show
          djp Junping Du added a comment - A quick comments: can we use "%n" instead of "/n"? The former one is independent of platforms but the later one works only on Linux.
          Hide
          poliva pascal oliva added a comment -

          I changed "\n" with "%" as you recommended - Here new patch : YARN-3460-1.patch - Test SUCCESS with openJDK and IBM JAVA

          Show
          poliva pascal oliva added a comment - I changed "\n" with "%" as you recommended - Here new patch : YARN-3460 -1.patch - Test SUCCESS with openJDK and IBM JAVA
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 32s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 22s The applied patch generated 18 new checkstyle issues (total was 100, now 117).
          -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 0m 57s Tests passed in hadoop-yarn-registry.
              36m 27s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731176/YARN-3460-1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8e991f4
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7760/artifact/patchprocess/diffcheckstylehadoop-yarn-registry.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7760/artifact/patchprocess/whitespace.txt
          hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-YARN-Build/7760/artifact/patchprocess/testrun_hadoop-yarn-registry.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7760/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7760/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 22s The applied patch generated 18 new checkstyle issues (total was 100, now 117). -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 0m 57s Tests passed in hadoop-yarn-registry.     36m 27s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731176/YARN-3460-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8e991f4 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7760/artifact/patchprocess/diffcheckstylehadoop-yarn-registry.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7760/artifact/patchprocess/whitespace.txt hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-YARN-Build/7760/artifact/patchprocess/testrun_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7760/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7760/console This message was automatically generated.
          Hide
          poliva pascal oliva added a comment -

          udpate indentation

          Show
          poliva pascal oliva added a comment - udpate indentation
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 42s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 34s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 23s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 0m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 1m 1s Tests passed in hadoop-yarn-registry.
              36m 29s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731216/YARN-3460-2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8e991f4
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7766/artifact/patchprocess/whitespace.txt
          hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-YARN-Build/7766/artifact/patchprocess/testrun_hadoop-yarn-registry.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7766/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7766/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 23s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 1m 1s Tests passed in hadoop-yarn-registry.     36m 29s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731216/YARN-3460-2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8e991f4 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7766/artifact/patchprocess/whitespace.txt hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-YARN-Build/7766/artifact/patchprocess/testrun_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7766/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7766/console This message was automatically generated.
          Hide
          poliva pascal oliva added a comment -

          update whitespaces

          Show
          poliva pascal oliva added a comment - update whitespaces
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 41s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 41s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 22s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 0m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 1m 1s Tests passed in hadoop-yarn-registry.
              36m 34s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731250/YARN-3460-3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ab5058d
          hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-YARN-Build/7774/artifact/patchprocess/testrun_hadoop-yarn-registry.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7774/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7774/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 41s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 22s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 1m 1s Tests passed in hadoop-yarn-registry.     36m 34s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731250/YARN-3460-3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ab5058d hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-YARN-Build/7774/artifact/patchprocess/testrun_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7774/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7774/console This message was automatically generated.
          Hide
          poliva pascal oliva added a comment -

          What about the integration of this issue in Hadoop ? In that version, the path should be integrated ?

          Show
          poliva pascal oliva added a comment - What about the integration of this issue in Hadoop ? In that version, the path should be integrated ?
          Hide
          aw Allen Wittenauer added a comment -
          +    Method methodInitialize =
          +	 kerb5LoginObject.getClass().getMethod("initialize", Subject.class, CallbackHandler.class, Map.class, Map.class);
          +    methodInitialize.invoke(kerb5LoginObject, subject, null, new HashMap<String, String>(), options );
          

          There's a tab here. Would you mind removing it?

          If no one else has any other comments, I'll be committing this by the end of the day.

          P.S.: downloading the IBM JDK is an exercise in frustration.

          Show
          aw Allen Wittenauer added a comment - + Method methodInitialize = + kerb5LoginObject.getClass().getMethod( "initialize" , Subject.class, CallbackHandler.class, Map.class, Map.class); + methodInitialize.invoke(kerb5LoginObject, subject, null , new HashMap< String , String >(), options ); There's a tab here. Would you mind removing it? If no one else has any other comments, I'll be committing this by the end of the day. P.S.: downloading the IBM JDK is an exercise in frustration.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 54s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 30s There were no new javac warning messages.
          +1 javadoc 10m 25s There were no new javadoc warning messages.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 24s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 24s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 1m 0s Tests passed in hadoop-yarn-registry.
              40m 25s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731250/YARN-3460-3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 5137b38
          hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-YARN-Build/8600/artifact/patchprocess/testrun_hadoop-yarn-registry.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8600/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8600/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 54s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 30s There were no new javac warning messages. +1 javadoc 10m 25s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 24s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 24s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 0s Tests passed in hadoop-yarn-registry.     40m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731250/YARN-3460-3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5137b38 hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-YARN-Build/8600/artifact/patchprocess/testrun_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8600/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8600/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          Actually, there's a lot more formatting problems. We should really clean these up.

          Show
          aw Allen Wittenauer added a comment - Actually, there's a lot more formatting problems. We should really clean these up.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          could the patch checker look for tabs as well as trailing whitespace?

          Show
          stevel@apache.org Steve Loughran added a comment - could the patch checker look for tabs as well as trailing whitespace?
          Hide
          djp Junping Du added a comment -

          +1. Checking tabs sounds necessary.

          Show
          djp Junping Du added a comment - +1. Checking tabs sounds necessary.
          Hide
          aw Allen Wittenauer added a comment -

          It's already there in HADOOP-12111.

          Show
          aw Allen Wittenauer added a comment - It's already there in HADOOP-12111 .
          Hide
          aw Allen Wittenauer added a comment -

          Ping pascal oliva. Just some minor cleanup....

          Show
          aw Allen Wittenauer added a comment - Ping pascal oliva . Just some minor cleanup....
          Hide
          chris.douglas Chris Douglas added a comment -

          This change invokes the "login" method, when "commit" is intended:

          -    boolean commitOk = krb5LoginModule.commit();
          +    Method methodCommit = kerb5LoginObject.getClass().getMethod("commit");
          +    boolean commitOk = (Boolean) methodLogin.invoke(kerb5LoginObject);
          

          Updated patch. Can someone test this on an IBM jdk?

          Show
          chris.douglas Chris Douglas added a comment - This change invokes the "login" method, when "commit" is intended: - boolean commitOk = krb5LoginModule.commit(); + Method methodCommit = kerb5LoginObject.getClass().getMethod("commit"); + boolean commitOk = (Boolean) methodLogin.invoke(kerb5LoginObject); Updated patch. Can someone test this on an IBM jdk?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 13s trunk passed
          +1 compile 0m 16s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 18s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 25s trunk passed
          +1 javadoc 0m 14s trunk passed
          +1 mvninstall 0m 14s the patch passed
          +1 compile 0m 14s the patch passed
          +1 javac 0m 14s the patch passed
          -0 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry: The patch generated 88 new + 101 unchanged - 4 fixed = 189 total (was 105)
          +1 mvnsite 0m 19s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 32s the patch passed
          +1 javadoc 0m 10s the patch passed
          +1 unit 0m 51s hadoop-yarn-registry in the patch passed.
          -1 asflicense 16m 24s The patch generated 4 ASF License warnings.
          30m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-3460
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835706/YARN-3460.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 23c68ab93784 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 57187fd
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13623/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-registry.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13623/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/13623/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13623/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 13s trunk passed +1 compile 0m 16s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 14s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed -0 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry: The patch generated 88 new + 101 unchanged - 4 fixed = 189 total (was 105) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 0m 51s hadoop-yarn-registry in the patch passed. -1 asflicense 16m 24s The patch generated 4 ASF License warnings. 30m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-3460 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835706/YARN-3460.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 23c68ab93784 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 57187fd Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13623/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13623/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/13623/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry Console output https://builds.apache.org/job/PreCommit-YARN-Build/13623/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          chris.douglas Chris Douglas added a comment -

          ASF license warnings are unrelated:

          Lines that start with ????? in the ASF License  report indicate files that do not have an Apache license header:
           !????? /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/js/jquery.dataTables.min.js
           !????? /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-1.8.2.min.js
           !????? /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-ui-1.9.1.custom.min.js
           !????? /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js
          

          Fixed some checkstyle warnings.

          Show
          chris.douglas Chris Douglas added a comment - ASF license warnings are unrelated: Lines that start with ????? in the ASF License report indicate files that do not have an Apache license header: !????? /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/js/jquery.dataTables.min.js !????? /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-1.8.2.min.js !????? /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/jquery-ui-1.9.1.custom.min.js !????? /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jt/jquery.jstree.js Fixed some checkstyle warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 46s trunk passed
          +1 compile 0m 15s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 18s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 24s trunk passed
          +1 javadoc 0m 13s trunk passed
          +1 mvninstall 0m 13s the patch passed
          +1 compile 0m 12s the patch passed
          +1 javac 0m 12s the patch passed
          -0 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry: The patch generated 21 new + 101 unchanged - 4 fixed = 122 total (was 105)
          +1 mvnsite 0m 15s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 28s the patch passed
          +1 javadoc 0m 11s the patch passed
          +1 unit 0m 47s hadoop-yarn-registry in the patch passed.
          -1 asflicense 15m 7s The patch generated 4 ASF License warnings.
          27m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-3460
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835754/YARN-3460.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 520d95f4ab2b 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8fa2195
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13627/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-registry.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13627/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/13627/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13627/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 46s trunk passed +1 compile 0m 15s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 13s the patch passed +1 compile 0m 12s the patch passed +1 javac 0m 12s the patch passed -0 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry: The patch generated 21 new + 101 unchanged - 4 fixed = 122 total (was 105) +1 mvnsite 0m 15s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 0m 47s hadoop-yarn-registry in the patch passed. -1 asflicense 15m 7s The patch generated 4 ASF License warnings. 27m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-3460 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835754/YARN-3460.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 520d95f4ab2b 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fa2195 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13627/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13627/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/13627/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry Console output https://builds.apache.org/job/PreCommit-YARN-Build/13627/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 17s trunk passed
          +1 compile 0m 16s trunk passed
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 21s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 15s trunk passed
          +1 mvninstall 0m 17s the patch passed
          +1 compile 0m 14s the patch passed
          +1 javac 0m 14s the patch passed
          +1 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry: The patch generated 0 new + 101 unchanged - 4 fixed = 101 total (was 105)
          +1 mvnsite 0m 18s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 38s the patch passed
          +1 javadoc 0m 12s the patch passed
          +1 unit 0m 53s hadoop-yarn-registry in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          14m 52s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-3460
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835850/YARN-3460.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 21e6bbf053ef 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1b79c41
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13640/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13640/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 17s trunk passed +1 compile 0m 16s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 15s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed +1 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry: The patch generated 0 new + 101 unchanged - 4 fixed = 101 total (was 105) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 0m 53s hadoop-yarn-registry in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 14m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-3460 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835850/YARN-3460.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 21e6bbf053ef 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1b79c41 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13640/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry Console output https://builds.apache.org/job/PreCommit-YARN-Build/13640/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          IMHO the patch looks safe to commit as 1) It doesn't affect existing JVMs and 2) the latest patch has got all clear from Yetus (thanks Chris Douglas!).

          Show
          subru Subru Krishnan added a comment - IMHO the patch looks safe to commit as 1) It doesn't affect existing JVMs and 2) the latest patch has got all clear from Yetus (thanks Chris Douglas !).
          Hide
          chris.douglas Chris Douglas added a comment -

          Agreed, thanks Subru Krishnan.

          I committed this. Thanks, Pascal

          Show
          chris.douglas Chris Douglas added a comment - Agreed, thanks Subru Krishnan . I committed this. Thanks, Pascal
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10725 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10725/)
          YARN-3460. TestSecureRMRegistryOperations fails with IBM_JAVA. (cdouglas: rev 76a10429809c001c8f75e94e39729987d8100d00)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/test/java/org/apache/hadoop/registry/secure/KerberosConfiguration.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/test/java/org/apache/hadoop/registry/secure/TestSecureLogins.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10725 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10725/ ) YARN-3460 . TestSecureRMRegistryOperations fails with IBM_JAVA. (cdouglas: rev 76a10429809c001c8f75e94e39729987d8100d00) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/test/java/org/apache/hadoop/registry/secure/KerberosConfiguration.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/test/java/org/apache/hadoop/registry/secure/TestSecureLogins.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java

            People

            • Assignee:
              poliva pascal oliva
              Reporter:
              poliva pascal oliva
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development