Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3459

Fix failiure of TestLog4jWarningErrorMetricsAppender

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestLog4jWarningErrorMetricsAppender fails with the following message:

      Running org.apache.hadoop.yarn.util.TestLog4jWarningErrorMetricsAppender
      Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.214 sec <<< FAILURE! - in org.apache.hadoop.yarn.util.TestLog4jWarningErrorMetricsAppender
      testPurge(org.apache.hadoop.yarn.util.TestLog4jWarningErrorMetricsAppender)  Time elapsed: 2.01 sec  <<< FAILURE!
      java.lang.AssertionError: expected:<0> but was:<1>
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.failNotEquals(Assert.java:743)
      	at org.junit.Assert.assertEquals(Assert.java:118)
      	at org.junit.Assert.assertEquals(Assert.java:555)
      	at org.junit.Assert.assertEquals(Assert.java:542)
      	at org.apache.hadoop.yarn.util.TestLog4jWarningErrorMetricsAppender.testPurge(TestLog4jWarningErrorMetricsAppender.java:89)
      

        Issue Links

          Activity

          Hide
          gtCarrera9 Li Lu added a comment -

          Reproduced this failure on my local machine as well as Jenkins run for YARN-3426. Seems like the test failure was introduced by YARN-2901. Tan, WangdaVarun Vasudev can anyone of you take a look at it? Thanks!

          Show
          gtCarrera9 Li Lu added a comment - Reproduced this failure on my local machine as well as Jenkins run for YARN-3426 . Seems like the test failure was introduced by YARN-2901 . Tan, Wangda Varun Vasudev can anyone of you take a look at it? Thanks!
          Hide
          leftnoteasy Wangda Tan added a comment -

          I can reproduce this locally as well, Varun Vasudev, do you have any ideas on this?

          Show
          leftnoteasy Wangda Tan added a comment - I can reproduce this locally as well, Varun Vasudev , do you have any ideas on this?
          Hide
          gtCarrera9 Li Lu added a comment -

          Varun Vasudev feel free to take it or directly patch it back to YARN-2901. Thanks!

          Show
          gtCarrera9 Li Lu added a comment - Varun Vasudev feel free to take it or directly patch it back to YARN-2901 . Thanks!
          Hide
          vvasudev Varun Vasudev added a comment -

          My apologies for the failing test. I suspect it's a timing issue since it passed the pre-commit builds and is passing on my machine. Can you try the attached patch and +1 if it works?

          Show
          vvasudev Varun Vasudev added a comment - My apologies for the failing test. I suspect it's a timing issue since it passed the pre-commit builds and is passing on my machine. Can you try the attached patch and +1 if it works?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723835/apache-yarn-3459.0.patch
          against trunk revision ab04ff9.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7251//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7251//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7251//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723835/apache-yarn-3459.0.patch against trunk revision ab04ff9. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7251//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7251//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7251//console This message is automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to trunk/branch-2, thanks Varun Vasudev!

          Show
          leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2, thanks Varun Vasudev !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7533 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7533/)
          YARN-3459. Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7533 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7533/ ) YARN-3459 . Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/)
          YARN-3459. Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/ ) YARN-3459 . Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/)
          YARN-3459. Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/ ) YARN-3459 . Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/)
          YARN-3459. Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/ ) YARN-3459 . Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/892/)
          YARN-3459. Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/892/ ) YARN-3459 . Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/)
          YARN-3459. Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/ ) YARN-3459 . Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/)
          YARN-3459. Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/ ) YARN-3459 . Fix failiure of TestLog4jWarningErrorMetricsAppender. (Varun Vasudev via wangda) (wangda: rev 7af086a515d573dc90ea4deec7f4e3f23622e0e8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestLog4jWarningErrorMetricsAppender.java hadoop-yarn-project/CHANGES.txt

            People

            • Assignee:
              vvasudev Varun Vasudev
              Reporter:
              gtCarrera9 Li Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development