Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The current implementation of getCpuUsagePercent() for WindowsBasedProcessTree is left as unavailable. Attached a proposal of how to do it. I reused the CpuTimeTracker using 1 jiffy=1ms.

      This was left open by YARN-3122.

      1. YARN-3458-1.patch
        2 kB
        Íñigo Goiri
      2. YARN-3458-2.patch
        2 kB
        Íñigo Goiri
      3. YARN-3458-3.patch
        2 kB
        Íñigo Goiri
      4. YARN-3458-4.patch
        2 kB
        Íñigo Goiri
      5. YARN-3458-5.patch
        6 kB
        Íñigo Goiri
      6. YARN-3458-6.patch
        6 kB
        Íñigo Goiri
      7. YARN-3458-7.patch
        7 kB
        Íñigo Goiri
      8. YARN-3458-8.patch
        7 kB
        Íñigo Goiri
      9. YARN-3458-9.patch
        7 kB
        Íñigo Goiri

        Issue Links

          Activity

          Hide
          elgoiri Íñigo Goiri added a comment -

          Not sure if the patch has been created properly as I'm in between a couple versions.
          I would created based on trunk if this doesn't work.

          Show
          elgoiri Íñigo Goiri added a comment - Not sure if the patch has been created properly as I'm in between a couple versions. I would created based on trunk if this doesn't work.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723671/YARN-3458-1.patch
          against trunk revision d27e924.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7243//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723671/YARN-3458-1.patch against trunk revision d27e924. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7243//console This message is automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Patch based on trunk. Let's see if Jenkins likes it.

          Show
          elgoiri Íñigo Goiri added a comment - Patch based on trunk. Let's see if Jenkins likes it.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723677/YARN-3458-2.patch
          against trunk revision d27e924.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7244//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723677/YARN-3458-2.patch against trunk revision d27e924. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7244//console This message is automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Git and I are getting through a rough relation, let's see if now...

          Show
          elgoiri Íñigo Goiri added a comment - Git and I are getting through a rough relation, let's see if now...
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723681/YARN-3458-3.patch
          against trunk revision d27e924.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7246//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7246//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7246//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723681/YARN-3458-3.patch against trunk revision d27e924. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7246//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7246//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7246//console This message is automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          For the tests, I checked the original TestWindowsBasedProcessTree and it didn't have related to actually testing the resource monitoring; I'm open to suggestions.

          Regarding the two warning, I'm not able to understand what this is complaining about; it says that I have fields not accessed but the ones I added are referenced. I think ti refers to Log but I'm not able to parse the error.

          Show
          elgoiri Íñigo Goiri added a comment - For the tests, I checked the original TestWindowsBasedProcessTree and it didn't have related to actually testing the resource monitoring; I'm open to suggestions. Regarding the two warning, I'm not able to understand what this is complaining about; it says that I have fields not accessed but the ones I added are referenced. I think ti refers to Log but I'm not able to parse the error.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Anybody has inputs on the findbugs issues?

          What about the unit test? Any proposal?

          Show
          elgoiri Íñigo Goiri added a comment - Anybody has inputs on the findbugs issues? What about the unit test? Any proposal?
          Hide
          elgoiri Íñigo Goiri added a comment -

          Removing white spaces from the end of the line.

          Show
          elgoiri Íñigo Goiri added a comment - Removing white spaces from the end of the line.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 47s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 46s There were no new javac warning messages.
          +1 javadoc 9m 44s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 24s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 24s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 1m 57s Tests passed in hadoop-yarn-common.
              43m 35s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727790/YARN-3458-4.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / bcf89dd
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7488/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7488/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7488/testReport/
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7488/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 24s The applied patch generated 1 additional checkstyle issues. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 24s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 1m 57s Tests passed in hadoop-yarn-common.     43m 35s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727790/YARN-3458-4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / bcf89dd checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7488/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7488/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7488/testReport/ Console output https://builds.apache.org/job/PreCommit-YARN-Build/7488/console This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Adding unit tests.

          Show
          elgoiri Íñigo Goiri added a comment - Adding unit tests.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 32s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 32s There were no new javac warning messages.
          +1 javadoc 9m 43s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 27s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 1m 29s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 2m 0s Tests passed in hadoop-yarn-common.
              43m 21s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728247/YARN-3458-5.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8b69c82
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7504/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7504/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7504/testReport/
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7504/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 43s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 27s The applied patch generated 1 additional checkstyle issues. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 29s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 2m 0s Tests passed in hadoop-yarn-common.     43m 21s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728247/YARN-3458-5.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8b69c82 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7504/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7504/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7504/testReport/ Console output https://builds.apache.org/job/PreCommit-YARN-Build/7504/console This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixing checkstyle errors. Personally, I think this is very strict but I just followed it.

          Show
          elgoiri Íñigo Goiri added a comment - Fixing checkstyle errors. Personally, I think this is very strict but I just followed it.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 36s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 5m 31s There were no new checkstyle issues.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 23s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 2m 6s Tests passed in hadoop-yarn-common.
              43m 17s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728291/YARN-3458-6.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1a2459b
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7507/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7507/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7507/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 5m 31s There were no new checkstyle issues. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 23s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 2m 6s Tests passed in hadoop-yarn-common.     43m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728291/YARN-3458-6.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1a2459b hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7507/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7507/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7507/console This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Merging to trunk with the newest resource monitoring structure

          Show
          elgoiri Íñigo Goiri added a comment - Merging to trunk with the newest resource monitoring structure
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 19s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 43s There were no new javac warning messages.
          +1 javadoc 9m 41s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 26s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 25s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 1m 56s Tests failed in hadoop-yarn-common.
              39m 3s  



          Reason Tests
          Failed unit tests hadoop.yarn.util.TestRackResolver



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750623/YARN-3458-7.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / dc7a061
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8847/artifact/patchprocess/whitespace.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8847/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8847/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8847/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 19s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 26s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 1m 56s Tests failed in hadoop-yarn-common.     39m 3s   Reason Tests Failed unit tests hadoop.yarn.util.TestRackResolver Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750623/YARN-3458-7.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / dc7a061 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8847/artifact/patchprocess/whitespace.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8847/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8847/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8847/console This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Rebase

          Show
          elgoiri Íñigo Goiri added a comment - Rebase
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 2s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 2s There were no new javac warning messages.
          +1 javadoc 10m 9s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 54s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          -1 findbugs 0m 20s Post-patch findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common compilation is broken.
          +1 findbugs 0m 20s The patch does not introduce any new Findbugs (version ) warnings.
          -1 yarn tests 0m 19s Tests failed in hadoop-yarn-common.
              39m 15s  



          Reason Tests
          Failed build hadoop-yarn-common



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752275/YARN-3458-8.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / eee0d45
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8906/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8906/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8906/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 2s There were no new javac warning messages. +1 javadoc 10m 9s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 54s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. -1 findbugs 0m 20s Post-patch findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common compilation is broken. +1 findbugs 0m 20s The patch does not introduce any new Findbugs (version ) warnings. -1 yarn tests 0m 19s Tests failed in hadoop-yarn-common.     39m 15s   Reason Tests Failed build hadoop-yarn-common Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752275/YARN-3458-8.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / eee0d45 hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8906/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8906/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8906/console This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Rebased to trunk.

          Show
          elgoiri Íñigo Goiri added a comment - Rebased to trunk.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for patch v9. I'll wait a few days before committing, since I see other watchers on the issue.

          Show
          cnauroth Chris Nauroth added a comment - +1 for patch v9. I'll wait a few days before committing, since I see other watchers on the issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 21s trunk passed
          +1 compile 0m 33s trunk passed with JDK v1.8.0_66
          +1 compile 0m 35s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 43s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 33s trunk passed
          +1 javadoc 0m 36s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 42s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 36s the patch passed
          +1 compile 0m 33s the patch passed with JDK v1.8.0_66
          +1 javac 0m 33s the patch passed
          +1 compile 0m 33s the patch passed with JDK v1.7.0_91
          +1 javac 0m 33s the patch passed
          +1 checkstyle 0m 16s the patch passed
          +1 mvnsite 0m 36s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 43s the patch passed
          +1 javadoc 0m 36s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 42s the patch passed with JDK v1.7.0_91
          +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 31s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 29s Patch does not generate ASF License warnings.
          26m 56s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775355/YARN-3458-9.patch
          JIRA Issue YARN-3458
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b7023ebed024 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3c0adac
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10013/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10013/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 21s trunk passed +1 compile 0m 33s trunk passed with JDK v1.8.0_66 +1 compile 0m 35s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 43s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 36s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 42s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 36s the patch passed +1 compile 0m 33s the patch passed with JDK v1.8.0_66 +1 javac 0m 33s the patch passed +1 compile 0m 33s the patch passed with JDK v1.7.0_91 +1 javac 0m 33s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 43s the patch passed +1 javadoc 0m 36s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 42s the patch passed with JDK v1.7.0_91 +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 2m 31s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 29s Patch does not generate ASF License warnings. 26m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775355/YARN-3458-9.patch JIRA Issue YARN-3458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b7023ebed024 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3c0adac findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10013/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10013/console This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          I have committed this to trunk, branch-2 and branch-2.8. Íñigo Goiri, thank you for the patch.

          Show
          cnauroth Chris Nauroth added a comment - I have committed this to trunk, branch-2 and branch-2.8. Íñigo Goiri , thank you for the patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9010 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9010/)
          YARN-3458. CPU resource monitoring in Windows. Contributed by Inigo (cnauroth: rev 114b59095540bb80db5153c816f9d285e4029031)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsBasedProcessTree.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestWindowsBasedProcessTree.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9010 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9010/ ) YARN-3458 . CPU resource monitoring in Windows. Contributed by Inigo (cnauroth: rev 114b59095540bb80db5153c816f9d285e4029031) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsBasedProcessTree.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestWindowsBasedProcessTree.java hadoop-yarn-project/CHANGES.txt
          Hide
          elgoiri Íñigo Goiri added a comment -

          Chris Nauroth, thank you very much for the review!

          Show
          elgoiri Íñigo Goiri added a comment - Chris Nauroth , thank you very much for the review!

            People

            • Assignee:
              elgoiri Íñigo Goiri
              Reporter:
              elgoiri Íñigo Goiri
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 168h
                168h
                Remaining:
                Remaining Estimate - 168h
                168h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development