Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: resourcemanager
    • Labels:
      None

      Description

      Failover should be filtered out from HAAdmin to be in sync with doc.
      Since "-failover" is not supported operation in doc it is not been mentioned, cli usage is misguiding (can be in sync with doc) .

        Activity

        Hide
        andreina J.Andreina added a comment -

        Observation:

        CLI:
        Rex@XXXXXXXXXXX:~/Hadoop_March18/hadoop-3.0.0-SNAPSHOT/bin> ./yarn rmadmin
        Usage: yarn rmadmin
           -refreshQueues
           -refreshNodes
           -refreshSuperUserGroupsConfiguration
           -refreshUserToGroupsMappings
           -refreshAdminAcls
           -refreshServiceAcl
           -getGroups [username]
           -addToClusterNodeLabels [label1,label2,label3] (label splitted by ",")
           -removeFromClusterNodeLabels [label1,label2,label3] (label splitted by ",")
           -replaceLabelsOnNode [node1[:port]=label1,label2 node2[:port]=label1,label2]
           -directlyAccessNodeLabelStore
           -transitionToActive [--forceactive] <serviceId>
           -transitionToStandby <serviceId>
           -failover [--forcefence] [--forceactive] <serviceId> <serviceId>
           -getServiceState <serviceId>
           -checkHealth <serviceId>
           -help [cmd]
        
        Doc:
        
        Runs ResourceManager admin client
        
          Usage: yarn rmadmin [-refreshQueues] [-refreshNodes] [-refreshUserToGroupsMapping] 
                              [-refreshSuperUserGroupsConfiguration] [-refreshAdminAcls] 
                              [-refreshServiceAcl] [-getGroups [username]] [-help [cmd]]
                              [-transitionToActive <serviceId>]
                              [-transitionToStandby <serviceId>]
                              [-getServiceState <serviceId>]
                              [-checkHealth <serviceId>]
        

        I would like to work on this issue . If this issue holds good can you please assign to me

        Show
        andreina J.Andreina added a comment - Observation: CLI: Rex@XXXXXXXXXXX:~/Hadoop_March18/hadoop-3.0.0-SNAPSHOT/bin> ./yarn rmadmin Usage: yarn rmadmin -refreshQueues -refreshNodes -refreshSuperUserGroupsConfiguration -refreshUserToGroupsMappings -refreshAdminAcls -refreshServiceAcl -getGroups [username] -addToClusterNodeLabels [label1,label2,label3] (label splitted by ",") -removeFromClusterNodeLabels [label1,label2,label3] (label splitted by ",") -replaceLabelsOnNode [node1[:port]=label1,label2 node2[:port]=label1,label2] -directlyAccessNodeLabelStore -transitionToActive [--forceactive] <serviceId> -transitionToStandby <serviceId> -failover [--forcefence] [--forceactive] <serviceId> <serviceId> -getServiceState <serviceId> -checkHealth <serviceId> -help [cmd] Doc: Runs ResourceManager admin client Usage: yarn rmadmin [-refreshQueues] [-refreshNodes] [-refreshUserToGroupsMapping] [-refreshSuperUserGroupsConfiguration] [-refreshAdminAcls] [-refreshServiceAcl] [-getGroups [username]] [-help [cmd]] [-transitionToActive <serviceId>] [-transitionToStandby <serviceId>] [-getServiceState <serviceId>] [-checkHealth <serviceId>] I would like to work on this issue . If this issue holds good can you please assign to me
        Hide
        andreina J.Andreina added a comment -

        Attached an initial patch . Please review.

        Show
        andreina J.Andreina added a comment - Attached an initial patch . Please review.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12707195/YARN-3397.1.patch
        against trunk revision e556198.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7100//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7100//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707195/YARN-3397.1.patch against trunk revision e556198. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7100//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7100//console This message is automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        +1

        Show
        kasha Karthik Kambatla added a comment - +1
        Hide
        kasha Karthik Kambatla added a comment - - edited

        Thanks for reporting and fixing this long-standing annoyance, J.Andreina. Just committed this to trunk and branch-2.

        Show
        kasha Karthik Kambatla added a comment - - edited Thanks for reporting and fixing this long-standing annoyance, J.Andreina . Just committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7432 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7432/)
        YARN-3397. yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7432 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7432/ ) YARN-3397 . yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/144/)
        YARN-3397. yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/144/ ) YARN-3397 . yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #878 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/878/)
        YARN-3397. yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #878 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/878/ ) YARN-3397 . yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/144/)
        YARN-3397. yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/144/ ) YARN-3397 . yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2094 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2094/)
        YARN-3397. yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2094 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2094/ ) YARN-3397 . yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2076 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2076/)
        YARN-3397. yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2076 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2076/ ) YARN-3397 . yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/135/)
        YARN-3397. yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/135/ ) YARN-3397 . yarn rmadmin should skip -failover. (J.Andreina via kasha) (kasha: rev c906a1de7280dabd9d9d8b6aeaa060898e6d17b6) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java

          People

          • Assignee:
            andreina J.Andreina
            Reporter:
            andreina J.Andreina
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development