Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3383

AdminService should use "warn" instead of "info" to log exception when operation fails

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: resourcemanager
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Now it uses info:

        private YarnException logAndWrapException(IOException ioe, String user,
            String argName, String msg) throws YarnException {
          LOG.info("Exception " + msg, ioe);
      

      But it should use warn instead.

        Activity

        Hide
        gtCarrera9 Li Lu added a comment -

        Agree. Upload a simple patch to quickly fix this problem.

        Show
        gtCarrera9 Li Lu added a comment - Agree. Upload a simple patch to quickly fix this problem.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Patch LGTM, will commit later.

        Show
        leftnoteasy Wangda Tan added a comment - Patch LGTM, will commit later.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706096/YARN-3383-032015.patch
        against trunk revision 7f1e2f9.

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7056//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706096/YARN-3383-032015.patch against trunk revision 7f1e2f9. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7056//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706096/YARN-3383-032015.patch
        against trunk revision 2bc097c.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7079//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706096/YARN-3383-032015.patch against trunk revision 2bc097c. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7079//console This message is automatically generated.
        Hide
        gtCarrera9 Li Lu added a comment -

        Rebase the patch with the latest trunk.

        Show
        gtCarrera9 Li Lu added a comment - Rebase the patch with the latest trunk.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706717/YARN-3383-032315.patch
        against trunk revision 972f1f1.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7080//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7080//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706717/YARN-3383-032315.patch against trunk revision 972f1f1. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7080//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7080//console This message is automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to trunk and branch-2, thanks Li Lu.

        Show
        leftnoteasy Wangda Tan added a comment - Committed to trunk and branch-2, thanks Li Lu .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7420 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7420/)
        YARN-3383. AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7420 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7420/ ) YARN-3383 . AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/CHANGES.txt
        Hide
        gtCarrera9 Li Lu added a comment -

        Thanks for the review and commit, Tan, Wangda!

        Show
        gtCarrera9 Li Lu added a comment - Thanks for the review and commit, Tan, Wangda !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #143 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/143/)
        YARN-3383. AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #143 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/143/ ) YARN-3383 . AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #877 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/877/)
        YARN-3383. AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #877 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/877/ ) YARN-3383 . AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2075 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2075/)
        YARN-3383. AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2075 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2075/ ) YARN-3383 . AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #134 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/134/)
        YARN-3383. AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #134 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/134/ ) YARN-3383 . AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #143 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/143/)
        YARN-3383. AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #143 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/143/ ) YARN-3383 . AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2093 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2093/)
        YARN-3383. AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2093 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2093/ ) YARN-3383 . AdminService should use warn instead of info to log exception when operation fails. (Li Lu via wangda) (wangda: rev 97a7277a2d696474b5c8e2d814c8291d4bde246e) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java

          People

          • Assignee:
            gtCarrera9 Li Lu
            Reporter:
            leftnoteasy Wangda Tan
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development