[YARN-3367] Replace starting a separate thread for post entity with event loop in TimelineClient

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: YARN-2928
• Fix Version/s: 2.9.0, 3.0.0-alpha1
• Component/s: timelineserver
• Labels: yarn-2928-1st-milestone
• Hadoop Flags: Reviewed
• Assignee: Naganarasimha G R
• Reporter: Junping Du
• Created: 18/Mar/15 21:37
• Updated: 25/Oct/19 20:27
• Resolved: 09/Feb/16 17:11

Description

Since YARN-3039, we add loop in TimelineClient to wait for collectorServiceAddress ready before posting any entity. In consumer of TimelineClient (like AM), we are starting a new thread for each call to get rid of potential deadlock in main thread. This way has at least 3 major defects:
1. The consumer need some additional code to wrap a thread before calling putEntities() in TimelineClient.
2. It cost many thread resources which is unnecessary.
3. The sequence of events could be out of order because each posting operation thread get out of waiting loop randomly.
We should have something like event loop in TimelineClient side, putEntities() only put related entities into a queue of entities and a separated thread handle to deliver entities in queue to collector via REST call.

Issue Links

• is depended upon by: YARN-4675 Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2