Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3341

Fix findbugs warning:BC_UNCONFIRMED_CAST at FSSchedulerNode.reserveResource

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Duplicate
    • None
    • None
    • None

    Description

      Fix findbugs warning:BC_UNCONFIRMED_CAST at FSSchedulerNode.reserveResource
      The warning message is

      Unchecked/unconfirmed cast from org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt to org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSSchedulerNode.reserveResource(SchedulerApplicationAttempt, Priority, RMContainer)
      

      The code which cause the warning is

          this.reservedAppSchedulable = (FSAppAttempt) application;
      

      Attachments

        1. YARN-3341.000.patch
          1 kB
          Zhihai Xu
        2. YARN-3341.001.patch
          4 kB
          Zhihai Xu

        Issue Links

          Activity

            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12704670/YARN-3341.000.patch
            against trunk revision bc9cb3e.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            -1 findbugs. The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

            Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6968//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6968//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
            Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6968//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704670/YARN-3341.000.patch against trunk revision bc9cb3e. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6968//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6968//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6968//console This message is automatically generated.
            zxu Zhihai Xu added a comment -

            Now the findbugs warning decrease from 5 to 4 with this patch.

            zxu Zhihai Xu added a comment - Now the findbugs warning decrease from 5 to 4 with this patch.
            rkanter Robert Kanter added a comment -

            That looks good to me. Can you look into the other 4 while you're at it? We should either fix them or exclude them as appropriate.

            rkanter Robert Kanter added a comment - That looks good to me. Can you look into the other 4 while you're at it? We should either fix them or exclude them as appropriate.
            zxu Zhihai Xu added a comment -

            Hi rkanter, thanks for the review. That is a good suggestion. I uploaded a new patch YARN-3341.001.patch which will fix 4 findbugs warning.
            The last findbugs warning looks like a real bug, I created a separate JIRA YARN-3355 for findbugs warning at FairScheduler.allocConf.

            zxu Zhihai Xu added a comment - Hi rkanter , thanks for the review. That is a good suggestion. I uploaded a new patch YARN-3341 .001.patch which will fix 4 findbugs warning. The last findbugs warning looks like a real bug, I created a separate JIRA YARN-3355 for findbugs warning at FairScheduler.allocConf.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12704913/YARN-3341.001.patch
            against trunk revision 2681ed9.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

            Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6985//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6985//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
            Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6985//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704913/YARN-3341.001.patch against trunk revision 2681ed9. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6985//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6985//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6985//console This message is automatically generated.
            rkanter Robert Kanter added a comment -

            +1 LGTM

            rkanter Robert Kanter added a comment - +1 LGTM

            It is dupe of YARN-3204,, can you please have look into YARN-3204..?

            brahmareddy Brahma Reddy Battula added a comment - It is dupe of YARN-3204 ,, can you please have look into YARN-3204 ..?
            zxu Zhihai Xu added a comment -

            Sorry, I missed YARN-3204, I resolved this issue as duplicate.
            I will review the patch at YARN-3204. brahmareddy, thanks to point this out.

            zxu Zhihai Xu added a comment - Sorry, I missed YARN-3204 , I resolved this issue as duplicate. I will review the patch at YARN-3204 . brahmareddy , thanks to point this out.

            People

              zxu Zhihai Xu
              zxu Zhihai Xu
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: