[YARN-3160] Non-atomic operation on nodeUpdateQueue in RMNodeImpl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.7.0
• Component/s: resourcemanager
• Hadoop Flags: Reviewed
• Assignee: Chengbing Liu
• Reporter: Chengbing Liu
• Created: 09/Feb/15 12:51
• Updated: 25/Oct/19 20:27
• Resolved: 11/Feb/15 11:35

Description

RMNodeImpl.java

while(nodeUpdateQueue.peek() != null){
  latestContainerInfoList.add(nodeUpdateQueue.poll());
}

The above code brings potential risk of adding null value to latestContainerInfoList. Since ConcurrentLinkedQueue implements a wait-free algorithm, we can directly poll the queue, before checking whether the value is null.