Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    1. YARN-3142.03.patch
      33 kB
      Varun Saxena
    2. YARN-3142.02.patch
      33 kB
      Varun Saxena
    3. YARN-3142.01.patch
      32 kB
      Varun Saxena

      Activity

      Hide
      rohithsharma Rohith Sharma K S added a comment -

      Wangda Tan Could you give some description about problem? In a high level, I assume myself that some thread safe data structure can be used instead of synchronizing all the methods.

      Varun Saxena I would like to work on this jira, would you mind if I take over this?

      Show
      rohithsharma Rohith Sharma K S added a comment - Wangda Tan Could you give some description about problem? In a high level, I assume myself that some thread safe data structure can be used instead of synchronizing all the methods. Varun Saxena I would like to work on this jira, would you mind if I take over this?
      Hide
      varun_saxena Varun Saxena added a comment -

      As per previous discussion, it is primarily about having a read/write lock instead of a synchronized method.
      We can use thread safe data structures as well, wherever possible and keep only critical sections inside a lock.
      Fine grained locking however, whether it can be handled as part of this JIRA, is open to discussion.
      Thanks for your interest but I would like to work on this. I already had a cursory glance at all the classes initially mentioned in the parent JIRA when that was raised.

      Show
      varun_saxena Varun Saxena added a comment - As per previous discussion, it is primarily about having a read/write lock instead of a synchronized method. We can use thread safe data structures as well, wherever possible and keep only critical sections inside a lock. Fine grained locking however, whether it can be handled as part of this JIRA, is open to discussion. Thanks for your interest but I would like to work on this. I already had a cursory glance at all the classes initially mentioned in the parent JIRA when that was raised.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Varun Saxena,

      Are you still working on this JIRA? If not, can I take over? Currently I want to finish all lock related changes shortly for YARN-5139.

      Thanks,

      Show
      leftnoteasy Wangda Tan added a comment - Varun Saxena , Are you still working on this JIRA? If not, can I take over? Currently I want to finish all lock related changes shortly for YARN-5139 . Thanks,
      Hide
      varun_saxena Varun Saxena added a comment -

      Sorry Wangda Tan, missed your comment as I was on leave.

      Let me see if I can get cycles to update the patch by tomorrow, otherwise you can take it up. Will let you know offline.
      If you already have a patch ready for it though, feel free to pick it up.

      Show
      varun_saxena Varun Saxena added a comment - Sorry Wangda Tan , missed your comment as I was on leave. Let me see if I can get cycles to update the patch by tomorrow, otherwise you can take it up. Will let you know offline. If you already have a patch ready for it though, feel free to pick it up.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Thanks Varun Saxena, I don't have a patch yet, it will be great, if you could have some cycle in the next one or two days to have the patch ready. I can help with reviews.

      Show
      leftnoteasy Wangda Tan added a comment - Thanks Varun Saxena , I don't have a patch yet, it will be great, if you could have some cycle in the next one or two days to have the patch ready. I can help with reviews.
      Hide
      varun_saxena Varun Saxena added a comment -

      Primarily converted synchronized methods to having code in methods inside RW locks. Bits of some methods can potentially be outside critical section but as I am not sure how much performance gain that would bring, I avoided adding multiple try-finally constructs in the same method, for the sake of simplicity.
      Haven't added any fine grained locking.

      Show
      varun_saxena Varun Saxena added a comment - Primarily converted synchronized methods to having code in methods inside RW locks. Bits of some methods can potentially be outside critical section but as I am not sure how much performance gain that would bring, I avoided adding multiple try-finally constructs in the same method, for the sake of simplicity. Haven't added any fine grained locking.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 12s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 7m 7s trunk passed
      +1 compile 0m 32s trunk passed
      +1 checkstyle 0m 21s trunk passed
      +1 mvnsite 0m 38s trunk passed
      +1 mvneclipse 0m 17s trunk passed
      +1 findbugs 1m 0s trunk passed
      +1 javadoc 0m 20s trunk passed
      +1 mvninstall 0m 30s the patch passed
      +1 compile 0m 30s the patch passed
      +1 javac 0m 30s the patch passed
      -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 4 unchanged - 1 fixed = 7 total (was 5)
      +1 mvnsite 0m 35s the patch passed
      +1 mvneclipse 0m 14s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 1m 3s the patch passed
      +1 javadoc 0m 17s the patch passed
      -1 unit 33m 9s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 18s The patch does not generate ASF License warnings.
      47m 57s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:9560f25
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829626/YARN-3142.01.patch
      JIRA Issue YARN-3142
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 76bdd2bfc94d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 964e546
      Default Java 1.8.0_101
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13178/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/13178/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13178/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13178/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/13178/console
      Powered by Apache Yetus 0.3.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 7s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 4 unchanged - 1 fixed = 7 total (was 5) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 17s the patch passed -1 unit 33m 9s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 47m 57s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829626/YARN-3142.01.patch JIRA Issue YARN-3142 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 76bdd2bfc94d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 964e546 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13178/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13178/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13178/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13178/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13178/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
      Hide
      sunilg Sunil G added a comment -

      Thanks Varun Saxena for the initial patch. I think generally we are trying to safeguard the internal data stored in AppSchedulingInfo and some criticial section code paths. I think we must look into a much fine grained version of locking targeting these areas. I think its a good step ahead to get the improvements eventhough its little.

      Show
      sunilg Sunil G added a comment - Thanks Varun Saxena for the initial patch. I think generally we are trying to safeguard the internal data stored in AppSchedulingInfo and some criticial section code paths. I think we must look into a much fine grained version of locking targeting these areas. I think its a good step ahead to get the improvements eventhough its little.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Thanks Varun Saxena,

      Yes I understand that this will not have any meaningful performance gain, but we can optimize it later like adding fine-grained locks. This is first step to us.

      Generally the patch looks very good, only a few comments:

      Lock is not requred:

        public Map<String, ResourceRequest> getResourceRequests(
            SchedulerRequestKey schedulerKey) {
            // ...
        }
      

      Lock is required:

        public Resource getResource(SchedulerRequestKey schedulerKey) {
          // ... 
        }
      

      (Imaging someone replace the request in another thread before returning)

      transferStateFromPreviousAppSchedulingInfo
      

      You may need to synchronize placesBlacklistedByApp and call placesBlacklistedByApp.addAll(appInfo.getBlackList()) to make it consistent to other blacklist-related operations.

      Show
      leftnoteasy Wangda Tan added a comment - Thanks Varun Saxena , Yes I understand that this will not have any meaningful performance gain, but we can optimize it later like adding fine-grained locks. This is first step to us. Generally the patch looks very good, only a few comments: Lock is not requred: public Map< String , ResourceRequest> getResourceRequests( SchedulerRequestKey schedulerKey) { // ... } Lock is required: public Resource getResource(SchedulerRequestKey schedulerKey) { // ... } (Imaging someone replace the request in another thread before returning) transferStateFromPreviousAppSchedulingInfo You may need to synchronize placesBlacklistedByApp and call placesBlacklistedByApp.addAll(appInfo.getBlackList()) to make it consistent to other blacklist-related operations.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Sunil G,

      Sorry I missed your comment.

      I agree that we can definitely do more than simply converting synchronized lock to R/W lock. However I think we can make this as the first step to unblock other JIRAs before doing more fine-grained locks. For example, I plan to rebase YARN-5139 on top of this patch. We can optimize more as separated patches.

      Thoughts?

      Show
      leftnoteasy Wangda Tan added a comment - Sunil G , Sorry I missed your comment. I agree that we can definitely do more than simply converting synchronized lock to R/W lock. However I think we can make this as the first step to unblock other JIRAs before doing more fine-grained locks. For example, I plan to rebase YARN-5139 on top of this patch. We can optimize more as separated patches. Thoughts?
      Hide
      sunilg Sunil G added a comment -

      Ok. That's fine for me.
      We may get a much clearer picture there.

      Show
      sunilg Sunil G added a comment - Ok. That's fine for me. We may get a much clearer picture there.
      Hide
      varun_saxena Varun Saxena added a comment - - edited

      Thanks Wangda Tan, Sunil G for reviews.

      Lock is not required

      Right. Will fix.

      You may need to synchronize placesBlacklistedByApp and call placesBlacklistedByApp.addAll(appInfo.getBlackList()) to make it consistent to other blacklist-related operations.

      But we wont be using this till we set current attempt in scheduler which is after this. Also, this is a reference assignment which is atomic. Thoughts ?

      (Imaging someone replace the request in another thread before returning)

      You mean remove the request from the resource request map ? Well the part about fetching from resource request map i.e. call to getResourceRequest is within locks. After that we just access ResourceRequest instance. And capability which we are returning here wont be changed even by another thread. However this is is not immutable field so we can probably guard it with a read lock just to be safe. Thoughts ?

      Show
      varun_saxena Varun Saxena added a comment - - edited Thanks Wangda Tan , Sunil G for reviews. Lock is not required Right. Will fix. You may need to synchronize placesBlacklistedByApp and call placesBlacklistedByApp.addAll(appInfo.getBlackList()) to make it consistent to other blacklist-related operations. But we wont be using this till we set current attempt in scheduler which is after this. Also, this is a reference assignment which is atomic. Thoughts ? (Imaging someone replace the request in another thread before returning) You mean remove the request from the resource request map ? Well the part about fetching from resource request map i.e. call to getResourceRequest is within locks. After that we just access ResourceRequest instance. And capability which we are returning here wont be changed even by another thread. However this is is not immutable field so we can probably guard it with a read lock just to be safe. Thoughts ?
      Hide
      leftnoteasy Wangda Tan added a comment -

      Varun Saxena,

      But we wont be using this till we set current attempt in scheduler which is after this. Also, this is a reference assignment which is atomic. Thoughts ?

      Yeah it should not required.

      You mean remove the request from the resource request map ? Well the part about fetching from resource request map i.e. call to getResourceRequest is within locks. After that we just access ResourceRequest instance. And capability which we are returning here wont be changed even by another thread. However this is is not immutable field so we can probably guard it with a read lock just to be safe. Thoughts ?

      Agree we can add a readlock here just to be safe.

      Show
      leftnoteasy Wangda Tan added a comment - Varun Saxena , But we wont be using this till we set current attempt in scheduler which is after this. Also, this is a reference assignment which is atomic. Thoughts ? Yeah it should not required. You mean remove the request from the resource request map ? Well the part about fetching from resource request map i.e. call to getResourceRequest is within locks. After that we just access ResourceRequest instance. And capability which we are returning here wont be changed even by another thread. However this is is not immutable field so we can probably guard it with a read lock just to be safe. Thoughts ? Agree we can add a readlock here just to be safe.
      Hide
      varun_saxena Varun Saxena added a comment -

      Updated the patch after fixing review comments and checkstyle issues.

      Show
      varun_saxena Varun Saxena added a comment - Updated the patch after fixing review comments and checkstyle issues.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 15s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 7m 57s trunk passed
      +1 compile 0m 37s trunk passed
      +1 checkstyle 0m 22s trunk passed
      +1 mvnsite 0m 41s trunk passed
      +1 mvneclipse 0m 20s trunk passed
      +1 findbugs 1m 7s trunk passed
      +1 javadoc 0m 22s trunk passed
      +1 mvninstall 0m 35s the patch passed
      +1 compile 0m 31s the patch passed
      +1 javac 0m 31s the patch passed
      -1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 4 unchanged - 1 fixed = 6 total (was 5)
      +1 mvnsite 0m 41s the patch passed
      +1 mvneclipse 0m 15s the patch passed
      +1 whitespace 0m 1s The patch has no whitespace issues.
      +1 findbugs 1m 15s the patch passed
      +1 javadoc 0m 19s the patch passed
      +1 unit 34m 2s hadoop-yarn-server-resourcemanager in the patch passed.
      +1 asflicense 0m 15s The patch does not generate ASF License warnings.
      50m 35s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:9560f25
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829932/YARN-3142.02.patch
      JIRA Issue YARN-3142
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux b478272df545 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 40acace
      Default Java 1.8.0_101
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13191/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13191/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/13191/console
      Powered by Apache Yetus 0.3.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 57s trunk passed +1 compile 0m 37s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 41s trunk passed +1 mvneclipse 0m 20s trunk passed +1 findbugs 1m 7s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 4 unchanged - 1 fixed = 6 total (was 5) +1 mvnsite 0m 41s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 34m 2s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 50m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829932/YARN-3142.02.patch JIRA Issue YARN-3142 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b478272df545 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 40acace Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13191/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13191/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13191/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
      Hide
      varun_saxena Varun Saxena added a comment -

      Fixed checkstyle issues

      Show
      varun_saxena Varun Saxena added a comment - Fixed checkstyle issues
      Hide
      leftnoteasy Wangda Tan added a comment -

      +1 to the latest patch, thanks Varun Saxena.

      Show
      leftnoteasy Wangda Tan added a comment - +1 to the latest patch, thanks Varun Saxena .
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 12m 33s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 7m 47s trunk passed
      +1 compile 0m 31s trunk passed
      +1 checkstyle 0m 23s trunk passed
      +1 mvnsite 0m 43s trunk passed
      +1 mvneclipse 0m 18s trunk passed
      +1 findbugs 1m 10s trunk passed
      +1 javadoc 0m 23s trunk passed
      +1 mvninstall 0m 35s the patch passed
      +1 compile 0m 34s the patch passed
      +1 javac 0m 34s the patch passed
      +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
      +1 mvnsite 0m 44s the patch passed
      +1 mvneclipse 0m 14s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 1m 15s the patch passed
      +1 javadoc 0m 21s the patch passed
      +1 unit 35m 45s hadoop-yarn-server-resourcemanager in the patch passed.
      +1 asflicense 0m 19s The patch does not generate ASF License warnings.
      64m 37s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:9560f25
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829997/YARN-3142.03.patch
      JIRA Issue YARN-3142
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux c27435022697 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 8e06d86
      Default Java 1.8.0_101
      findbugs v3.0.0
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13221/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/13221/console
      Powered by Apache Yetus 0.3.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 47s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 43s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 23s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5) +1 mvnsite 0m 44s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 21s the patch passed +1 unit 35m 45s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 64m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829997/YARN-3142.03.patch JIRA Issue YARN-3142 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c27435022697 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8e06d86 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13221/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13221/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Committed to trunk / brach-2, thanks Varun Saxena and thanks Sunil G for reviews!

      Show
      leftnoteasy Wangda Tan added a comment - Committed to trunk / brach-2, thanks Varun Saxena and thanks Sunil G for reviews!
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10500 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10500/)
      YARN-3142. Improve locks in AppSchedulingInfo. (Varun Saxena via wangda) (wangda: rev 1831be8e737fd423a9f3d590767b944147e85641)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10500 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10500/ ) YARN-3142 . Improve locks in AppSchedulingInfo. (Varun Saxena via wangda) (wangda: rev 1831be8e737fd423a9f3d590767b944147e85641) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
      Hide
      varun_saxena Varun Saxena added a comment -

      Thanks Wangda Tan for the review and commit.
      Thanks Sunil G for the reviews.

      Show
      varun_saxena Varun Saxena added a comment - Thanks Wangda Tan for the review and commit. Thanks Sunil G for the reviews.

        People

        • Assignee:
          varun_saxena Varun Saxena
          Reporter:
          leftnoteasy Wangda Tan
        • Votes:
          0 Vote for this issue
          Watchers:
          9 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development