Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3058

Fix error message of tokens' activation delay configuration

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.7.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      this.rollingInterval = conf.getLong(
               YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS,
              YarnConfiguration.DEFAULT_RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS) * 1000;
      ...
      this.activationDelay =
              (long) (conf.getLong(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
                  YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS) * 1.5);
      ...
      if (rollingInterval <= activationDelay * 2) {
            throw new IllegalArgumentException(
                YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
                    + " should be more than 2 X "
                    + YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS);
          }
      

      The error msg should be

      YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
                    + " should be more than 3 X "
                    + YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS);
      

      Also It's 3 X instead of 2 X, since it's multiplied by 1.5.
      There are few other places having same issue.

        Attachments

        1. YARN-3058.001.patch
          4 kB
          Yi Liu

          Issue Links

            Activity

              People

              • Assignee:
                hitliuyi Yi Liu
                Reporter:
                hitliuyi Yi Liu
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: