Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2906

CapacitySchedulerPage shows HTML tags for a queue's Active Users

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      On the capacity scheduler web page, expanding the details of a queue shows HTML tags among the details for the active users.

        Issue Links

          Activity

          Hide
          jlowe Jason Lowe added a comment - - edited

          This was broken by YARN-2503, as it changed _r to _ for the active users page and thus caused the HTML to be escaped rather than passed raw.

          Show
          jlowe Jason Lowe added a comment - - edited This was broken by YARN-2503 , as it changed _r to _ for the active users page and thus caused the HTML to be escaped rather than passed raw.
          Hide
          jlowe Jason Lowe added a comment -

          It looks like YARN-2503 (inadvertently?) moved the _r from active users to the labels. I don't see why we would want to pass labels as raw HTML, so I moved the _r from labels and back to active users.

          Wangda Tan could you take a look and verify label text should not be sent as raw HTML?

          Show
          jlowe Jason Lowe added a comment - It looks like YARN-2503 (inadvertently?) moved the _r from active users to the labels. I don't see why we would want to pass labels as raw HTML, so I moved the _r from labels and back to active users. Wangda Tan could you take a look and verify label text should not be sent as raw HTML?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Jason Lowe, you're correct, this is a bug caused by YARN-2503. Will create a cluster and try this patch, will get back to you once I have done.

          Thanks!

          Show
          leftnoteasy Wangda Tan added a comment - Jason Lowe , you're correct, this is a bug caused by YARN-2503 . Will create a cluster and try this patch, will get back to you once I have done. Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12683674/YARN-2906v1.patch
          against trunk revision 78f7cdb.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5937//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5937//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683674/YARN-2906v1.patch against trunk revision 78f7cdb. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5937//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5937//console This message is automatically generated.
          Hide
          jianhe Jian He added a comment -

          Sorry for missing this while reviewing the previous patch. build locally. looks good.
          thanks Jason for pointing this out !

          Show
          jianhe Jian He added a comment - Sorry for missing this while reviewing the previous patch. build locally. looks good. thanks Jason for pointing this out !
          Hide
          leftnoteasy Wangda Tan added a comment -

          Just tried this, without this JIRA, "Active users" has some abnormal characters, with this patch, "Active users" is expected.

          +1 for this fix, thanks!

          Show
          leftnoteasy Wangda Tan added a comment - Just tried this, without this JIRA, "Active users" has some abnormal characters, with this patch, "Active users" is expected. +1 for this fix, thanks!
          Hide
          jianhe Jian He added a comment -

          Committed to trunk and branch-2. thanks Jason !

          Show
          jianhe Jian He added a comment - Committed to trunk and branch-2. thanks Jason !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6606 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6606/)
          YARN-2906. CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6606 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6606/ ) YARN-2906 . CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #17 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/17/)
          YARN-2906. CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #17 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/17/ ) YARN-2906 . CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #755 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/755/)
          YARN-2906. CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #755 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/755/ ) YARN-2906 . CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1945 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1945/)
          YARN-2906. CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1945 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1945/ ) YARN-2906 . CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #17 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/17/)
          YARN-2906. CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #17 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/17/ ) YARN-2906 . CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1969 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1969/)
          YARN-2906. CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1969 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1969/ ) YARN-2906 . CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #17 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/17/)
          YARN-2906. CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #17 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/17/ ) YARN-2906 . CapacitySchedulerPage shows HTML tags for a queue's Active Users. Contributed by Jason Lowe (jianhe: rev 8a7ca13b13c0c3f008a6490cc96d4d48a051d1f7) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/CapacitySchedulerPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Pulled this into 2.6.1. Ran compilation before the push. Patch applied cleanly.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1. Ran compilation before the push. Patch applied cleanly.

            People

            • Assignee:
              jlowe Jason Lowe
              Reporter:
              jlowe Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development