Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha, 0.23.3
    • Fix Version/s: 2.0.3-alpha, 0.23.5
    • Component/s: None
    • Labels:

      Description

      test TestCompositeService fails when run with jdk7.

      It appears it expects test testCallSequence to be called first and the sequence numbers to start at 0. On jdk7 its not being called first and sequence number has already been incremented.

      1. YARN-28.patch
        0.9 kB
        Thomas Graves
      2. YARN-28.patch
        1 kB
        Thomas Graves

        Activity

        Hide
        Thomas Graves added a comment -

        make sure to reset the counter before calling init.

        This is ready for review.

        Show
        Thomas Graves added a comment - make sure to reset the counter before calling init. This is ready for review.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Verified that order is indeed the problem. How about resetting the seq numbers in a test setup method?

        Show
        Vinod Kumar Vavilapalli added a comment - Verified that order is indeed the problem. How about resetting the seq numbers in a test setup method?
        Hide
        Vinod Kumar Vavilapalli added a comment -

        How about resetting the seq numbers in a test setup method?

        Thomas, can you do this so that we can finish this? Tx.

        Show
        Vinod Kumar Vavilapalli added a comment - How about resetting the seq numbers in a test setup method? Thomas, can you do this so that we can finish this? Tx.
        Hide
        Thomas Graves added a comment -

        sorry for the delay on this, I somehow missed your comments.

        I assume by setup routine you mean @Before. Will upload a patch shortly.

        Show
        Thomas Graves added a comment - sorry for the delay on this, I somehow missed your comments. I assume by setup routine you mean @Before. Will upload a patch shortly.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12545476/YARN-28.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/42//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/42//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545476/YARN-28.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/42//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/42//console This message is automatically generated.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        +1, looks good. Verified again.

        Pushing this.

        Show
        Vinod Kumar Vavilapalli added a comment - +1, looks good. Verified again. Pushing this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2739 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2739/)
        YARN-28. Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2739 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2739/ ) YARN-28 . Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2802 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2802/)
        YARN-28. Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2802 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2802/ ) YARN-28 . Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2763 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2763/)
        YARN-28. Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907)

        Result = FAILURE
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2763 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2763/ ) YARN-28 . Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Just put this in trunk and branch-2. Thanks Thomas!

        Show
        Vinod Kumar Vavilapalli added a comment - Just put this in trunk and branch-2. Thanks Thomas!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1169/)
        YARN-28. Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1169/ ) YARN-28 . Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1200/)
        YARN-28. Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907)

        Result = SUCCESS
        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1200/ ) YARN-28 . Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1386907) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386907 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Hide
        Robert Joseph Evans added a comment -

        I just pulled this into branch-0.23

        Show
        Robert Joseph Evans added a comment - I just pulled this into branch-0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #392 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/392/)
        svn merge -c 1386907 FIXES: YARN-28. Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1392461)

        Result = UNSTABLE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1392461
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #392 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/392/ ) svn merge -c 1386907 FIXES: YARN-28 . Fixed TestCompositeService to not depend on test-order and thus made it pass on JDK7. Contributed by Thomas Graves. (Revision 1392461) Result = UNSTABLE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1392461 Files : /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java

          People

          • Assignee:
            Thomas Graves
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development