Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2492 (Clone of YARN-796) Allow for (admin) labels on nodes and resource-requests
  3. YARN-2740

Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: resourcemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      According to YARN-2495, when distributed node label configuration is enabled:

      • RMAdmin / REST API should reject change labels on node operations.
      • CommonNodeLabelsManager shouldn't persist labels on nodes when NM do heartbeat.
      1. YARN-2740.20150320-1.patch
        22 kB
        Naganarasimha G R
      2. YARN-2740.20150327-1.patch
        26 kB
        Naganarasimha G R
      3. YARN-2740.20150411-1.patch
        31 kB
        Naganarasimha G R
      4. YARN-2740.20150411-2.patch
        33 kB
        Naganarasimha G R
      5. YARN-2740.20150411-3.patch
        35 kB
        Naganarasimha G R
      6. YARN-2740.20150417-1.patch
        35 kB
        Naganarasimha G R
      7. YARN-2740.20150420-1.patch
        38 kB
        Naganarasimha G R
      8. YARN-2740.20150421-1.patch
        36 kB
        Naganarasimha G R
      9. YARN-2740.20150422-2.patch
        42 kB
        Naganarasimha G R
      10. YARN-2740.20150423-1.patch
        42 kB
        Naganarasimha G R
      11. YARN-2740.20150423-1-merged.patch
        43 kB
        Wangda Tan
      12. YARN-2740-20141024-1.patch
        8 kB
        Wangda Tan

        Issue Links

          Activity

          Hide
          leftnoteasy Wangda Tan added a comment -

          This issue depends on configuration option defined at YARN-2495.

          Show
          leftnoteasy Wangda Tan added a comment - This issue depends on configuration option defined at YARN-2495 .
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached a patch for this, read the distributed-configuration-enabled from conf is not implemented, will add that part after YARN-2495 committed.

          Show
          leftnoteasy Wangda Tan added a comment - Attached a patch for this, read the distributed-configuration-enabled from conf is not implemented, will add that part after YARN-2495 committed.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda,
          As per your comment in YARN-2495,

          when distributed node label configuration is set, any direct modify node to labels mapping from RMAdminCLI should be rejected (like -replaceNodeToLabels). This can be done in a separated JIRA.

          As there was jira already existing for it, taking over this jira and also it was requiring a similar check for RMWebServices flow so added a check and test case for the same

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , As per your comment in YARN-2495 , when distributed node label configuration is set, any direct modify node to labels mapping from RMAdminCLI should be rejected (like -replaceNodeToLabels). This can be done in a separated JIRA. As there was jira already existing for it, taking over this jira and also it was requiring a similar check for RMWebServices flow so added a check and test case for the same
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda,
          Have rebased the patch and updated the patch to handle the second scenario CommonNodeLabelsManager shouldn't persist labels on nodes when NM do heartbeat.

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , Have rebased the patch and updated the patch to handle the second scenario CommonNodeLabelsManager shouldn't persist labels on nodes when NM do heartbeat.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707571/YARN-2740.20150327-1.patch
          against trunk revision 1a495fb.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7158//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7158//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707571/YARN-2740.20150327-1.patch against trunk revision 1a495fb. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7158//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7158//console This message is automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda,
          Seems like TestFairScheduler.testContinuousScheduling is intermittently failing and not related to the fix in this jira.... so can you review this jira further ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , Seems like TestFairScheduler.testContinuousScheduling is intermittently failing and not related to the fix in this jira.... so can you review this jira further ?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Naganarasimha G R,
          Took a look, some comments:
          1) Beyond "CommonNodeLabelsManager shouldn't persist labels on nodes when NM do heartbeat.", it shouldn't recover labels on nodes when RM restart. This is because RM configured centralized config, add some labels to nodes and change config to distributed then restart.

          Need add tests to make sure RM restart will not recover labels on nodes when distributed configuration enabled.

          2) isDistributedConfiguration should be a part of CommonNodeLabelsManager so that you don't need to get from configuration it in RMAdminService/RMWebService

          Show
          leftnoteasy Wangda Tan added a comment - Naganarasimha G R , Took a look, some comments: 1) Beyond "CommonNodeLabelsManager shouldn't persist labels on nodes when NM do heartbeat.", it shouldn't recover labels on nodes when RM restart. This is because RM configured centralized config, add some labels to nodes and change config to distributed then restart. Need add tests to make sure RM restart will not recover labels on nodes when distributed configuration enabled. 2) isDistributedConfiguration should be a part of CommonNodeLabelsManager so that you don't need to get from configuration it in RMAdminService/RMWebService
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the review Tan, Wangda,

          Beyond "CommonNodeLabelsManager shouldn't persist labels on nodes when NM do heartbeat.", it shouldn't recover labels on nodes when RM restart. This is because RM configured centralized config, add some labels to nodes and change config to distributed then restart.

          Good catch !. This i can achieve in couple of ways

          • Modify NodeLabelsStore.recover() to accept a boolean parameter like boolean skipNodeToLabelsMappings and leave the responsibility to the store (FileSystemNodeLabelsStore need to take care of skipping)
          • Add a method in CommonNodeLabelsManager like recoverLabelsOnNode and let the store use this instead of replaceLabelsOnNode and we can handle the skipping in the new method i.e. CommonNodeLabelsManager.recoverLabelsOnNode. If needed to further ensure that NodeLabelsStore do not call replaceLabelsOnNode we can extract a interface for the methods used by the NodeLabelsStore and make CommonNodeLabelsManager implement it.

          Please provide your opinion on the suggested approaches and also if you have any other alternatives in mind.

          2nd point will handle in the next patch

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the review Tan, Wangda , Beyond "CommonNodeLabelsManager shouldn't persist labels on nodes when NM do heartbeat.", it shouldn't recover labels on nodes when RM restart. This is because RM configured centralized config, add some labels to nodes and change config to distributed then restart. Good catch !. This i can achieve in couple of ways Modify NodeLabelsStore.recover() to accept a boolean parameter like boolean skipNodeToLabelsMappings and leave the responsibility to the store (FileSystemNodeLabelsStore need to take care of skipping) Add a method in CommonNodeLabelsManager like recoverLabelsOnNode and let the store use this instead of replaceLabelsOnNode and we can handle the skipping in the new method i.e. CommonNodeLabelsManager.recoverLabelsOnNode . If needed to further ensure that NodeLabelsStore do not call replaceLabelsOnNode we can extract a interface for the methods used by the NodeLabelsStore and make CommonNodeLabelsManager implement it. Please provide your opinion on the suggested approaches and also if you have any other alternatives in mind. 2nd point will handle in the next patch
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda,
          Can you please provide your opinion on my previous comment ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , Can you please provide your opinion on my previous comment ?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Modify NodeLabelsStore.recover() to accept a boolean parameter like boolean skipNodeToLabelsMappings and leave the responsibility to the store (FileSystemNodeLabelsStore need to take care of skipping)

          This seems a easier/cleaner way to solve this problem. I prefer 1st .

          Show
          leftnoteasy Wangda Tan added a comment - Modify NodeLabelsStore.recover() to accept a boolean parameter like boolean skipNodeToLabelsMappings and leave the responsibility to the store (FileSystemNodeLabelsStore need to take care of skipping) This seems a easier/cleaner way to solve this problem. I prefer 1st .
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda,
          I have updated a patch with the above 2 comments can you please have a look ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , I have updated a patch with the above 2 comments can you please have a look ?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724618/YARN-2740.20150411-1.patch
          against trunk revision e516706.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7303//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724618/YARN-2740.20150411-1.patch against trunk revision e516706. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7303//console This message is automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          fixing the earlier patch

          Show
          Naganarasimha Naganarasimha G R added a comment - fixing the earlier patch
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724645/YARN-2740.20150411-2.patch
          against trunk revision 7660da9.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7305//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7305//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724645/YARN-2740.20150411-2.patch against trunk revision 7660da9. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7305//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7305//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724689/YARN-2740.20150411-3.patch
          against trunk revision 2cc9514.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7308//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7308//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724689/YARN-2740.20150411-3.patch against trunk revision 2cc9514. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7308//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7308//console This message is automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          1. CommonNodeLabelsManager:
          1.1) @VisibleForTesting for isDistributedNodeLabelConfiguration is not necessary?

          1.2) How to set isDistributedNodeLabelConfiguration:
          It's better to add a helper method in YarnConfiguration instead of doing following check:

              isDistributedNodeLabelConfiguration  =
                  YarnConfiguration.DISTRIBUTED_NODELABEL_CONFIGURATION_TYPE.equals(conf
                      .get(YarnConfiguration.NODELABEL_CONFIGURATION_TYPE,
                          YarnConfiguration.DEFAULT_NODELABEL_CONFIGURATION_TYPE));
          

          I noticed in ResourceTrackerService can leavage the helper method I suggest too:

              String nodeLabelConfigurationType =
                  conf.get(YarnConfiguration.NODELABEL_CONFIGURATION_TYPE,
                      YarnConfiguration.DEFAULT_NODELABEL_CONFIGURATION_TYPE);
          
              isDistributesNodeLabelsConf =
                  YarnConfiguration.DISTRIBUTED_NODELABEL_CONFIGURATION_TYPE
                      .equals(nodeLabelConfigurationType);
          

          1.3) Better to add a brief comment about why we don't send message to store

          2. FileSystemNodeLabelStore:
          Add a note about why ignoreNodeLabelsMapping is needed

          3. AdminService:
          Should we throw exception when distributedConfiguration enabled for removeClusterNodeLabels? remove will change labels on node, after removed, node heartbeat with the removed partition will be identified as error, it seems reasonable to me. Admin should be able to control "valid-partitions" in the cluster.

          Same as RMWebServices.

          Test looks good to me, but may need to change if you agree with 2/3.

          Show
          leftnoteasy Wangda Tan added a comment - 1. CommonNodeLabelsManager: 1.1) @VisibleForTesting for isDistributedNodeLabelConfiguration is not necessary? 1.2) How to set isDistributedNodeLabelConfiguration: It's better to add a helper method in YarnConfiguration instead of doing following check: isDistributedNodeLabelConfiguration = YarnConfiguration.DISTRIBUTED_NODELABEL_CONFIGURATION_TYPE.equals(conf .get(YarnConfiguration.NODELABEL_CONFIGURATION_TYPE, YarnConfiguration.DEFAULT_NODELABEL_CONFIGURATION_TYPE)); I noticed in ResourceTrackerService can leavage the helper method I suggest too: String nodeLabelConfigurationType = conf.get(YarnConfiguration.NODELABEL_CONFIGURATION_TYPE, YarnConfiguration.DEFAULT_NODELABEL_CONFIGURATION_TYPE); isDistributesNodeLabelsConf = YarnConfiguration.DISTRIBUTED_NODELABEL_CONFIGURATION_TYPE .equals(nodeLabelConfigurationType); 1.3) Better to add a brief comment about why we don't send message to store 2. FileSystemNodeLabelStore: Add a note about why ignoreNodeLabelsMapping is needed 3. AdminService: Should we throw exception when distributedConfiguration enabled for removeClusterNodeLabels? remove will change labels on node, after removed, node heartbeat with the removed partition will be identified as error, it seems reasonable to me. Admin should be able to control "valid-partitions" in the cluster. Same as RMWebServices. Test looks good to me, but may need to change if you agree with 2/3.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the review Tan, Wangda,

          Should we throw exception when distributedConfiguration enabled for removeClusterNodeLabels? remove will change labels on node, after removed, node heartbeat with the removed partition will be identified as error, it seems reasonable to me. Admin should be able to control "valid-partitions" in the cluster.

          Actually dint get completely your opinion about throw exception when distributedConfiguration enabled for removeClusterNodeLabels; Did you want to throw ? if you want to allow admin to remove ClusterNodeLabels then there is one case which i can see potential problem: Assume NM informs RM with a valid node label "x" through HB/Resgistration and then admin removes x from cluster node labels. But this is not communicated back to NM and NM will not send labels as part of HB unless there is change in labels in NM side. So NM is not aware of "x" being removed at all. I agree we need to allow Admin to control valid partitions but in that case we need to add some logic in RM to request NM to resubmit labels. Please provide ur views.
          Will correct other issues as part of next patch.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the review Tan, Wangda , Should we throw exception when distributedConfiguration enabled for removeClusterNodeLabels? remove will change labels on node, after removed, node heartbeat with the removed partition will be identified as error, it seems reasonable to me. Admin should be able to control "valid-partitions" in the cluster. Actually dint get completely your opinion about throw exception when distributedConfiguration enabled for removeClusterNodeLabels; Did you want to throw ? if you want to allow admin to remove ClusterNodeLabels then there is one case which i can see potential problem: Assume NM informs RM with a valid node label "x" through HB/Resgistration and then admin removes x from cluster node labels. But this is not communicated back to NM and NM will not send labels as part of HB unless there is change in labels in NM side . So NM is not aware of "x" being removed at all. I agree we need to allow Admin to control valid partitions but in that case we need to add some logic in RM to request NM to resubmit labels. Please provide ur views. Will correct other issues as part of next patch.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          updated the patch Tan, Wangda's review comments

          Show
          Naganarasimha Naganarasimha G R added a comment - updated the patch Tan, Wangda 's review comments
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks for your quick update Naganarasimha G R.

          Actually dint get completely your opinion about throw exception when distributedConfiguration enabled for removeClusterNodeLabels; Did you want to throw ?

          I think it's better now prevent admin remove clusterNodeLabel when distributed enabled.

          if you want to allow admin to remove ClusterNodeLabels then there is one case which i can see potential problem: Assume NM informs RM with a valid node label "x" through HB/Resgistration and then admin removes x from cluster node labels. But this is not communicated back to NM and NM will not send labels as part of HB unless there is change in labels in NM side. So NM is not aware of "x" being removed at all. I agree we need to allow Admin to control valid partitions but in that case we need to add some logic in RM to request NM to resubmit labels. Please provide ur views.

          I think it's not a big problem, NM doesn't need to know "x" being removed, the logic should be, NM reports label, and RM allocate according to label, NM should just move on if adding label failed as what we done in YARN-2495. My opinion here is not add extra RM->NM communicate.

          I will review patch again when we decided above one.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks for your quick update Naganarasimha G R . Actually dint get completely your opinion about throw exception when distributedConfiguration enabled for removeClusterNodeLabels; Did you want to throw ? I think it's better now prevent admin remove clusterNodeLabel when distributed enabled. if you want to allow admin to remove ClusterNodeLabels then there is one case which i can see potential problem: Assume NM informs RM with a valid node label "x" through HB/Resgistration and then admin removes x from cluster node labels. But this is not communicated back to NM and NM will not send labels as part of HB unless there is change in labels in NM side. So NM is not aware of "x" being removed at all. I agree we need to allow Admin to control valid partitions but in that case we need to add some logic in RM to request NM to resubmit labels. Please provide ur views. I think it's not a big problem, NM doesn't need to know "x" being removed, the logic should be, NM reports label, and RM allocate according to label, NM should just move on if adding label failed as what we done in YARN-2495 . My opinion here is not add extra RM->NM communicate. I will review patch again when we decided above one.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726016/YARN-2740.20150417-1.patch
          against trunk revision 4308910.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7369//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7369//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726016/YARN-2740.20150417-1.patch against trunk revision 4308910. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7369//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7369//console This message is automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the comments Tan, Wangda,

          I think it's not a big problem, NM doesn't need to know "x" being removed, the logic should be, NM reports label, and RM allocate according to label, NM should just move on if adding label failed

          Well IIUC, based on your reply to first point prevent admin remove clusterNodeLabel when distributed enabled we need worry about this second point right? as user will not be able to remove cluster node label

          as what we done in YARN-2495. My opinion here is not add extra RM->NM communicate.

          As per last discussion in YARN-2495 you had given a concluded as per this comment that

          • Show/log diagnostic in RM (nodes) page and NM page, saying label is invalid. (Need modify web UI, can be done in a separated task)
          • Make the node's labels to be empty, so that applications can continue use it.

          based on this i mentioned RM->NM communicate/notify would be required as labels are sent only on change in NM side and it will not be able show that there is error in reporting labels. In btw have raised new jira YARN-3506 for this error handling reported in YARN-2495
          Test failure is not related to this patch and will work on prevent admin remove clusterNodeLabel when distributed enabled. and resubmit the patch.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the comments Tan, Wangda , I think it's not a big problem, NM doesn't need to know "x" being removed, the logic should be, NM reports label, and RM allocate according to label, NM should just move on if adding label failed Well IIUC, based on your reply to first point prevent admin remove clusterNodeLabel when distributed enabled we need worry about this second point right? as user will not be able to remove cluster node label as what we done in YARN-2495 . My opinion here is not add extra RM->NM communicate. As per last discussion in YARN-2495 you had given a concluded as per this comment that Show/log diagnostic in RM (nodes) page and NM page, saying label is invalid. (Need modify web UI, can be done in a separated task) Make the node's labels to be empty, so that applications can continue use it. based on this i mentioned RM->NM communicate/notify would be required as labels are sent only on change in NM side and it will not be able show that there is error in reporting labels. In btw have raised new jira YARN-3506 for this error handling reported in YARN-2495 Test failure is not related to this patch and will work on prevent admin remove clusterNodeLabel when distributed enabled. and resubmit the patch.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda, i have updated the patch with the required modifications for prevent admin remove clusterNodeLabel when distributed enabled. Please review

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , i have updated the patch with the required modifications for prevent admin remove clusterNodeLabel when distributed enabled . Please review
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726618/YARN-2740.20150420-1.patch
          against trunk revision f967fd2.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.security.TestAMRMTokens
          org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
          org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerQueueACLs
          org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels
          org.apache.hadoop.yarn.server.resourcemanager.recovery.TestLeveldbRMStateStore
          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7401//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7401//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726618/YARN-2740.20150420-1.patch against trunk revision f967fd2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.security.TestAMRMTokens org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerQueueACLs org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels org.apache.hadoop.yarn.server.resourcemanager.recovery.TestLeveldbRMStateStore org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7401//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7401//console This message is automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Retriggered Jenkins.

          Show
          leftnoteasy Wangda Tan added a comment - Retriggered Jenkins.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Hi Naganarasimha G R,
          After reread our conversation, I felt I misled you cause a typo: I think it's better now prevent admin remove clusterNodeLabel when distributed enabled., now should be not. I suggest not to prevent removing clusterNodeLabel while distributed enabled. The reason is what I mentioned above.

          I think it's not a big problem, NM doesn't need to know "x" being removed, the logic should be, NM reports label, and RM allocate according to label, NM should just move on if adding label failed as what we done in YARN-2495. My opinion here is not add extra RM->NM communicate.

          Sorry for that.

          based on this i mentioned RM->NM communicate/notify would be required as labels are sent only on change in NM side and it will not be able show that there is error in reporting labels. In btw have raised new jira YARN-3506 for this error handling reported in YARN-2495

          This may not be a big issue, I suggest to keep it as-is temporarily since it needs change NM/RM interface. We can address other issues before come to the problem.

          Thoughts?

          Show
          leftnoteasy Wangda Tan added a comment - Hi Naganarasimha G R , After reread our conversation, I felt I misled you cause a typo: I think it's better now prevent admin remove clusterNodeLabel when distributed enabled. , now should be not . I suggest not to prevent removing clusterNodeLabel while distributed enabled. The reason is what I mentioned above. I think it's not a big problem, NM doesn't need to know "x" being removed, the logic should be, NM reports label, and RM allocate according to label, NM should just move on if adding label failed as what we done in YARN-2495 . My opinion here is not add extra RM->NM communicate. Sorry for that. based on this i mentioned RM->NM communicate/notify would be required as labels are sent only on change in NM side and it will not be able show that there is error in reporting labels. In btw have raised new jira YARN-3506 for this error handling reported in YARN-2495 This may not be a big issue, I suggest to keep it as-is temporarily since it needs change NM/RM interface. We can address other issues before come to the problem. Thoughts?
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726618/YARN-2740.20150420-1.patch
          against trunk revision d50e8f0.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7408//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7408//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726618/YARN-2740.20150420-1.patch against trunk revision d50e8f0. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7408//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7408//console This message is automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the review comments Tan, Wangda,
          I have updated the patch with changes not to prevent removing clusterNodeLabel while distributed enabled. Please review.

          This may not be a big issue, I suggest to keep it as-is temporarily since it needs change NM/RM interface. We can address other issues before come to the problem.

          Ok

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the review comments Tan, Wangda , I have updated the patch with changes not to prevent removing clusterNodeLabel while distributed enabled . Please review. This may not be a big issue, I suggest to keep it as-is temporarily since it needs change NM/RM interface. We can address other issues before come to the problem. Ok
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726731/YARN-2740.20150421-1.patch
          against trunk revision 44872b7.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched

          The following test timeouts occurred in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServiTestTests
          org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7411//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7411//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726731/YARN-2740.20150421-1.patch against trunk revision 44872b7. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 5 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched The following test timeouts occurred in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServiTestTests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7411//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7411//console This message is automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Tan, Wangda, Seems like most of the test cases are failing due to address bind exception which is not related to this patch

          Show
          Naganarasimha Naganarasimha G R added a comment - Tan, Wangda , Seems like most of the test cases are failing due to address bind exception which is not related to this patch
          Hide
          leftnoteasy Wangda Tan added a comment -

          General LGTM, some minor comments.

          1) Mark YarnConfiguration.isDistributedNodeLabelConfiguration to @Private
          2) It's better to cover remove label case since remove label = remove label in the cluster + remove label in nodes, add a test to make sure it works in distributed mode, same as TestRMAdminService/TestRMWebServicesNodeLabels
          3) RMWebServices.replaceLabelsOnNode(s) should be merged to avoid we need to maintain both.

          Show
          leftnoteasy Wangda Tan added a comment - General LGTM, some minor comments. 1) Mark YarnConfiguration.isDistributedNodeLabelConfiguration to @Private 2) It's better to cover remove label case since remove label = remove label in the cluster + remove label in nodes, add a test to make sure it works in distributed mode, same as TestRMAdminService/TestRMWebServicesNodeLabels 3) RMWebServices.replaceLabelsOnNode(s) should be merged to avoid we need to maintain both.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the comment Tan, Wangda

          2) It's better to cover remove label case since remove label = remove label in the cluster + remove label in nodes, add a test to make sure it works in distributed mode, same as TestRMAdminService/TestRMWebServicesNodeLabels.

          IIUC you want prevent removing clusterNodeLabel while distributed enabled and add test cases for it ?

          3) RMWebServices.replaceLabelsOnNode(s) should be merged to avoid we need to maintain both.

          I dont mind working on it here but 2 queries

          • Is it that we should still support existing 2 rest api's for replaceLabelsOnNode on a single node and other for multiple nodes and ensure the common part is extracted to a new method ?
          • I understand that it will make it easy for committer to limit number of checkins but Is it good in terms of maintainability to include code changes in the patch which is not related to this jira description ?
          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the comment Tan, Wangda 2) It's better to cover remove label case since remove label = remove label in the cluster + remove label in nodes, add a test to make sure it works in distributed mode, same as TestRMAdminService/TestRMWebServicesNodeLabels. IIUC you want prevent removing clusterNodeLabel while distributed enabled and add test cases for it ? 3) RMWebServices.replaceLabelsOnNode(s) should be merged to avoid we need to maintain both. I dont mind working on it here but 2 queries Is it that we should still support existing 2 rest api's for replaceLabelsOnNode on a single node and other for multiple nodes and ensure the common part is extracted to a new method ? I understand that it will make it easy for committer to limit number of checkins but Is it good in terms of maintainability to include code changes in the patch which is not related to this jira description ?
          Hide
          leftnoteasy Wangda Tan added a comment -

          IIUC you want prevent removing clusterNodeLabel while distributed enabled and add test cases for it ?

          No, we've decided to support remove node labels while distributed config enabled, I think it's better to add test to make sure it works in distributed mode. Since "remove label = remove label in the cluster + remove label in nodes, it's a defensive test case to avoid future code changes break this.

          Is it that we should still support existing 2 rest api's for replaceLabelsOnNode on a single node and other for multiple nodes and ensure the common part is extracted to a new method ?

          We can continue to support both of the 2, just extra common part should be enough.

          I understand that it will make it easy for committer to limit number of checkins but Is it good in terms of maintainability to include code changes in the patch which is not related to this jira description ?

          I think it's a very small refactoring, doesn't change any of functionalities, doing it with the JIRA should be fine.

          Show
          leftnoteasy Wangda Tan added a comment - IIUC you want prevent removing clusterNodeLabel while distributed enabled and add test cases for it ? No, we've decided to support remove node labels while distributed config enabled, I think it's better to add test to make sure it works in distributed mode. Since "remove label = remove label in the cluster + remove label in nodes, it's a defensive test case to avoid future code changes break this. Is it that we should still support existing 2 rest api's for replaceLabelsOnNode on a single node and other for multiple nodes and ensure the common part is extracted to a new method ? We can continue to support both of the 2, just extra common part should be enough. I understand that it will make it easy for committer to limit number of checkins but Is it good in terms of maintainability to include code changes in the patch which is not related to this jira description ? I think it's a very small refactoring, doesn't change any of functionalities, doing it with the JIRA should be fine.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          No, we've decided to support remove node labels while distributed config enabled, I think it's better to add test to make sure it works in distributed mode. Since "remove label = remove label in the cluster + remove label in nodes, it's a defensive test case to avoid future code changes break this.

          ok got it, had misread your comment earlier

          We can continue to support both of the 2, just extra common part should be enough.

          ok, Will extract the common part to a method .

          Show
          Naganarasimha Naganarasimha G R added a comment - No, we've decided to support remove node labels while distributed config enabled, I think it's better to add test to make sure it works in distributed mode. Since "remove label = remove label in the cluster + remove label in nodes, it's a defensive test case to avoid future code changes break this. ok got it, had misread your comment earlier We can continue to support both of the 2, just extra common part should be enough. ok, Will extract the common part to a method .
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda
          Please find the updated patch with review comments fixed

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda Please find the updated patch with review comments fixed
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 35s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 7 new or modified test files.
          -1 whitespace 0m 0s The patch has 10 line(s) that end in whitespace.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 31s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 22s The applied patch generated 5 additional checkstyle issues.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 4m 0s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 0s Tests passed in hadoop-yarn-common.
          -1 yarn tests 54m 14s Tests failed in hadoop-yarn-server-resourcemanager.
              100m 10s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727201/YARN-2740.20150422-2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / b08908a
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/whitespace.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7444/testReport/
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7444//console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 7 new or modified test files. -1 whitespace 0m 0s The patch has 10 line(s) that end in whitespace. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 31s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 22s The applied patch generated 5 additional checkstyle issues. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 4m 0s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 0s Tests passed in hadoop-yarn-common. -1 yarn tests 54m 14s Tests failed in hadoop-yarn-server-resourcemanager.     100m 10s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727201/YARN-2740.20150422-2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b08908a whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/whitespace.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7444/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7444/testReport/ Console output https://builds.apache.org/job/PreCommit-YARN-Build/7444//console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          unit test failure is not related to this patch and can fix white space issue but not clear about the check style output, will correct it once i get some confirmation from allen

          Show
          Naganarasimha Naganarasimha G R added a comment - unit test failure is not related to this patch and can fix white space issue but not clear about the check style output, will correct it once i get some confirmation from allen
          Hide
          leftnoteasy Wangda Tan added a comment -

          Latest patch LGTM, +1. checkstyle result lack of details and some minor formatting suggestions, will commit today.

          Show
          leftnoteasy Wangda Tan added a comment - Latest patch LGTM, +1. checkstyle result lack of details and some minor formatting suggestions, will commit today.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda,
          Patch failed to apply on top of yest checkins, hence rebased and also have corrected the trailing white space.

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , Patch failed to apply on top of yest checkins, hence rebased and also have corrected the trailing white space.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Naganarasimha G R, will commit once Jenkins get back.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Naganarasimha G R , will commit once Jenkins get back.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 42s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 7 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          -1 javac 7m 45s The applied patch generated 122 additional warning messages.
          -1 javadoc 9m 56s The applied patch generated 9 additional warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 30s The applied patch generated 3 additional checkstyle issues.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 3s Tests passed in hadoop-yarn-common.
          -1 yarn tests 19m 31s Tests failed in hadoop-yarn-server-resourcemanager.
              66m 32s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
            hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler
            hadoop.yarn.server.resourcemanager.TestApplicationACLs
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs
            hadoop.yarn.server.resourcemanager.TestApplicationCleanup
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSLeafQueue
            hadoop.yarn.server.resourcemanager.TestRM
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
            hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
            hadoop.yarn.server.resourcemanager.security.TestAMRMTokens
            hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerFairShare
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppAttempt
            hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior
            hadoop.yarn.server.resourcemanager.TestMoveApplication
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerEventLog
            hadoop.yarn.server.resourcemanager.TestApplicationMasterLauncher
            hadoop.yarn.server.resourcemanager.TestRMProxyUsersConf
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
            hadoop.yarn.server.resourcemanager.resourcetracker.TestNMReconnect
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesHttpStaticUserPermissions
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueMappings
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
            hadoop.yarn.server.resourcemanager.TestApplicationMasterService
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerQueueACLs
            hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy
            hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels
            hadoop.yarn.server.resourcemanager.scheduler.TestQueueMetrics
            hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerHealth
            hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerUtils
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication
            hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestWorkPreservingRMRestartForNodeLabel
            hadoop.yarn.server.resourcemanager.TestRMAdminService
            hadoop.yarn.server.resourcemanager.resourcetracker.TestRMNMRPCResponseId
            hadoop.yarn.server.resourcemanager.monitor.TestSchedulingMonitor
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
            hadoop.yarn.server.resourcemanager.TestRMEmbeddedElector
            hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.TestClientRMService
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727647/YARN-2740.20150423-1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 49f6e3d
          javac https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/diffJavacWarnings.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7476/testReport/
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7476/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 7 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. -1 javac 7m 45s The applied patch generated 122 additional warning messages. -1 javadoc 9m 56s The applied patch generated 9 additional warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 30s The applied patch generated 3 additional checkstyle issues. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 3s Tests passed in hadoop-yarn-common. -1 yarn tests 19m 31s Tests failed in hadoop-yarn-server-resourcemanager.     66m 32s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler   hadoop.yarn.server.resourcemanager.TestApplicationACLs   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs   hadoop.yarn.server.resourcemanager.TestApplicationCleanup   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSLeafQueue   hadoop.yarn.server.resourcemanager.TestRM   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes   hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.security.TestAMRMTokens   hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerFairShare   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppAttempt   hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior   hadoop.yarn.server.resourcemanager.TestMoveApplication   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerEventLog   hadoop.yarn.server.resourcemanager.TestApplicationMasterLauncher   hadoop.yarn.server.resourcemanager.TestRMProxyUsersConf   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.resourcetracker.TestNMReconnect   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesHttpStaticUserPermissions   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueMappings   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart   hadoop.yarn.server.resourcemanager.TestApplicationMasterService   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerQueueACLs   hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy   hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels   hadoop.yarn.server.resourcemanager.scheduler.TestQueueMetrics   hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerHealth   hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerUtils   hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication   hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestWorkPreservingRMRestartForNodeLabel   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.resourcetracker.TestRMNMRPCResponseId   hadoop.yarn.server.resourcemanager.monitor.TestSchedulingMonitor   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation   hadoop.yarn.server.resourcemanager.TestRMEmbeddedElector   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.TestClientRMService   hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727647/YARN-2740.20150423-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 49f6e3d javac https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/diffJavacWarnings.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7476/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7476/testReport/ Console output https://builds.apache.org/job/PreCommit-YARN-Build/7476/console This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Seems like env issue, re-kicked Jenkins.

          Show
          leftnoteasy Wangda Tan added a comment - Seems like env issue, re-kicked Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 44s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 7 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 34s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 25s The applied patch generated 3 additional checkstyle issues.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 4m 2s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 2s Tests passed in hadoop-yarn-common.
          +1 yarn tests 52m 24s Tests passed in hadoop-yarn-server-resourcemanager.
              98m 43s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727647/YARN-2740.20150423-1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3952054
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7479/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7479/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7479/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7479/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7479/testReport/
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7479/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 7 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 25s The applied patch generated 3 additional checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 4m 2s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 2s Tests passed in hadoop-yarn-common. +1 yarn tests 52m 24s Tests passed in hadoop-yarn-server-resourcemanager.     98m 43s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727647/YARN-2740.20150423-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3952054 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7479/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7479/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7479/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7479/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7479/testReport/ Console output https://builds.apache.org/job/PreCommit-YARN-Build/7479/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda, seems like jenkins results are fine can we get this in ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , seems like jenkins results are fine can we get this in ?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Rebased and merge conflicts with latest trunk to kick Jenkins.

          Show
          leftnoteasy Wangda Tan added a comment - Rebased and merge conflicts with latest trunk to kick Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 59s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 7 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 37s There were no new javac warning messages.
          -1 javadoc 10m 3s The applied patch generated 43 additional warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 4m 3s The applied patch generated 3 additional checkstyle issues.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 2s Tests passed in hadoop-yarn-common.
          -1 yarn tests 18m 49s Tests failed in hadoop-yarn-server-resourcemanager.
              64m 44s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.TestApplicationCleanup
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication
            hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
            hadoop.yarn.server.resourcemanager.resourcetracker.TestRMNMRPCResponseId
            hadoop.yarn.server.resourcemanager.TestMoveApplication
            hadoop.yarn.server.resourcemanager.TestApplicationMasterService
            hadoop.yarn.server.resourcemanager.rmcontainer.TestRMContainerImpl
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler
            hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCNodeUpdates
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesHttpStaticUserPermissions
            hadoop.yarn.server.resourcemanager.monitor.TestSchedulingMonitor
            hadoop.yarn.server.resourcemanager.TestRMAdminService
            hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication
            hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCResponseId
            hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched
            hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens
            hadoop.yarn.server.resourcemanager.TestApplicationACLs
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels
            hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate
            hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens
            hadoop.yarn.server.resourcemanager.TestClientRMService
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler
            hadoop.yarn.server.resourcemanager.resourcetracker.TestNMReconnect
            hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            hadoop.yarn.server.resourcemanager.TestResourceManager
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueMappings
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior
            hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter
            hadoop.yarn.server.resourcemanager.TestApplicationMasterLauncher
            hadoop.yarn.server.resourcemanager.TestRM
            hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy
            hadoop.yarn.server.resourcemanager.TestRMHA
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens
            hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
            hadoop.yarn.server.resourcemanager.rmapp.attempt.TestAMLivelinessMonitor
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
            hadoop.yarn.server.resourcemanager.TestContainerResourceUsage
            hadoop.yarn.server.resourcemanager.security.TestAMRMTokens



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728466/YARN-2740.20150423-1-merged.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 7f07c4d
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7513/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7513/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 7 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 37s There were no new javac warning messages. -1 javadoc 10m 3s The applied patch generated 43 additional warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 4m 3s The applied patch generated 3 additional checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 2s Tests passed in hadoop-yarn-common. -1 yarn tests 18m 49s Tests failed in hadoop-yarn-server-resourcemanager.     64m 44s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestApplicationCleanup   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication   hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.resourcetracker.TestRMNMRPCResponseId   hadoop.yarn.server.resourcemanager.TestMoveApplication   hadoop.yarn.server.resourcemanager.TestApplicationMasterService   hadoop.yarn.server.resourcemanager.rmcontainer.TestRMContainerImpl   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler   hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCNodeUpdates   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesHttpStaticUserPermissions   hadoop.yarn.server.resourcemanager.monitor.TestSchedulingMonitor   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication   hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCResponseId   hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched   hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens   hadoop.yarn.server.resourcemanager.TestApplicationACLs   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels   hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate   hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens   hadoop.yarn.server.resourcemanager.TestClientRMService   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler   hadoop.yarn.server.resourcemanager.resourcetracker.TestNMReconnect   hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   hadoop.yarn.server.resourcemanager.TestResourceManager   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueMappings   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior   hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter   hadoop.yarn.server.resourcemanager.TestApplicationMasterLauncher   hadoop.yarn.server.resourcemanager.TestRM   hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy   hadoop.yarn.server.resourcemanager.TestRMHA   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart   hadoop.yarn.server.resourcemanager.rmapp.attempt.TestAMLivelinessMonitor   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes   hadoop.yarn.server.resourcemanager.TestContainerResourceUsage   hadoop.yarn.server.resourcemanager.security.TestAMRMTokens Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728466/YARN-2740.20150423-1-merged.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7f07c4d javadoc https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7513/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7513/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7513/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 6s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 7 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 52s There were no new javac warning messages.
          +1 javadoc 9m 40s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 32s The applied patch generated 3 additional checkstyle issues.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 4m 10s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 0m 22s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 12s Tests passed in hadoop-yarn-common.
          -1 yarn tests 58m 10s Tests failed in hadoop-yarn-server-resourcemanager.
              105m 44s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.TestRM



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728466/YARN-2740.20150423-1-merged.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6bae596
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7515/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7515/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7515/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7515/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7515/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7515/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 6s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 7 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 52s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 32s The applied patch generated 3 additional checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 4m 10s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 0m 22s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 12s Tests passed in hadoop-yarn-common. -1 yarn tests 58m 10s Tests failed in hadoop-yarn-server-resourcemanager.     105m 44s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestRM Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728466/YARN-2740.20150423-1-merged.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6bae596 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7515/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/7515/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7515/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7515/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7515/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7515/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda, seems like the test failure is not related to the patch.

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , seems like the test failure is not related to the patch.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Have you checked it in your local environment?

          Show
          leftnoteasy Wangda Tan added a comment - Have you checked it in your local environment?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Just verified in local environment, TestRM can get passed. Committing...

          Show
          leftnoteasy Wangda Tan added a comment - Just verified in local environment, TestRM can get passed. Committing...
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to trunk/branch-2, thanks Naganarasimha G R!

          Show
          leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2, thanks Naganarasimha G R !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7690 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7690/)
          YARN-2740. Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7690 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7690/ ) YARN-2740 . Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Tan, Wangda, for reviewing and committing the patch. Saw your earlier message late, had verified.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Tan, Wangda , for reviewing and committing the patch. Saw your earlier message late, had verified.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2109 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2109/)
          YARN-2740. Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2109 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2109/ ) YARN-2740 . Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/168/)
          YARN-2740. Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/168/ ) YARN-2740 . Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #177 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/177/)
          YARN-2740. Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #177 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/177/ ) YARN-2740 . Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #911 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/911/)
          YARN-2740. Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #911 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/911/ ) YARN-2740 . Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #178 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/178/)
          YARN-2740. Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #178 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/178/ ) YARN-2740 . Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2127/)
          YARN-2740. Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2127/ ) YARN-2740 . Fix NodeLabelsManager to properly handle node label modifications when distributed node label configuration enabled. (Naganarasimha G R via wangda) (wangda: rev db1b674b50ddecf2774f4092d677c412722bdcb1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/NullRMNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAdminService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/DummyCommonNodeLabelsManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java

            People

            • Assignee:
              Naganarasimha Naganarasimha G R
              Reporter:
              leftnoteasy Wangda Tan
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development