Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2492 (Clone of YARN-796) Allow for (admin) labels on nodes and resource-requests
  3. YARN-2726

CapacityScheduler should explicitly log when an accessible label has no capacity

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.6.0
    • capacityscheduler
    • None

    Description

      Given:

      • Node label defined: test-label
      • Two queues defined: a, b
      • label accessibility and and capacity defined as follows (properties abbreviated for readability):

      root.a.accessible-node-labels = test-label
      root.a.accessible-node-labels.test-label.capacity = 100

      If you restart the RM or do a 'rmadmin -refreshQueues' you will get a stack trace with the following error buried within:

      "Illegal capacity of -1.0 for label=test-label in queue=root.b"

      This of course occurs because test-label is accessible to b due to inheritance from the root, and -1 is the UNDEFINED value. To my mind this might not be obvious to the admin, and the error message which results does not help guide someone to the source of the issue.

      I propose that this situation be updated so that when the capacity on an accessible label is undefined, it is explicitly called out instead of falling through to the illegal capacity check. Something like:

      if (capacity == UNDEFINED) {
          throw new IllegalArgumentException("Configuration issue: " + " label=" + label + " is accessible from queue=" + queue + " but has no capacity set.");
      }
      

      I'll leave it to better judgement than mine as to whether I'm throwing the appropriate exception there. I think this check should be added to both getNodeLabelCapacities and getMaximumNodeLabelCapacities in CapacitySchedulerConfiguration.java.

      Attachments

        1. YARN-2726-20141023-1.patch
          2 kB
          Wangda Tan
        2. YARN-2726-20141023-2.patch
          2 kB
          Wangda Tan

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            leftnoteasy Wangda Tan
            tweek Phil D'Amore
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment