Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2662

TestCgroupsLCEResourcesHandler leaks file descriptors.

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.6.0
    • test
    • None
    • Reviewed

    Description

      TestCgroupsLCEResourcesHandler includes tests that write and read values from the various cgroups files. After the tests read from a file, they do not close it.

      Attachments

        1. YARN-2662.1.patch
          1 kB
          Chris Nauroth

        Activity

          cnauroth Chris Nauroth added a comment -

          Here is a small patch with the fix. The bug had been causing test failures on Windows. With this patch, the test now passes on Windows.

          cnauroth Chris Nauroth added a comment - Here is a small patch with the fix. The bug had been causing test failures on Windows. With this patch, the test now passes on Windows.
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12673723/YARN-2662.1.patch
          against trunk revision 2217e2f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5335//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/5335//artifact/patchprocess/patchReleaseAuditProblems.txt
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5335//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12673723/YARN-2662.1.patch against trunk revision 2217e2f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5335//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/5335//artifact/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5335//console This message is automatically generated.
          cnauroth Chris Nauroth added a comment -

          The release audit warning is unrelated.

          cnauroth Chris Nauroth added a comment - The release audit warning is unrelated.
          szetszwo Tsz-wo Sze added a comment -

          +1 patch looks good.

          szetszwo Tsz-wo Sze added a comment - +1 patch looks good.
          cnauroth Chris Nauroth added a comment -

          I committed this to trunk, branch-2 and branch-2.6. Nicholas, thank you for the code review.

          cnauroth Chris Nauroth added a comment - I committed this to trunk, branch-2 and branch-2.6. Nicholas, thank you for the code review.
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6235 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6235/)
          YARN-2662. TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth. (cnauroth: rev d3afd730acfa380ab5032be5ee296c5d73744518)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/util/TestCgroupsLCEResourcesHandler.java
          • hadoop-yarn-project/CHANGES.txt
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6235 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6235/ ) YARN-2662 . TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth. (cnauroth: rev d3afd730acfa380ab5032be5ee296c5d73744518) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/util/TestCgroupsLCEResourcesHandler.java hadoop-yarn-project/CHANGES.txt
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #707 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/707/)
          YARN-2662. TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth. (cnauroth: rev d3afd730acfa380ab5032be5ee296c5d73744518)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/util/TestCgroupsLCEResourcesHandler.java
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #707 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/707/ ) YARN-2662 . TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth. (cnauroth: rev d3afd730acfa380ab5032be5ee296c5d73744518) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/util/TestCgroupsLCEResourcesHandler.java
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1897 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1897/)
          YARN-2662. TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth. (cnauroth: rev d3afd730acfa380ab5032be5ee296c5d73744518)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/util/TestCgroupsLCEResourcesHandler.java
          • hadoop-yarn-project/CHANGES.txt
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1897 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1897/ ) YARN-2662 . TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth. (cnauroth: rev d3afd730acfa380ab5032be5ee296c5d73744518) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/util/TestCgroupsLCEResourcesHandler.java hadoop-yarn-project/CHANGES.txt
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1922 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1922/)
          YARN-2662. TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth. (cnauroth: rev d3afd730acfa380ab5032be5ee296c5d73744518)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/util/TestCgroupsLCEResourcesHandler.java
          • hadoop-yarn-project/CHANGES.txt
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1922 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1922/ ) YARN-2662 . TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth. (cnauroth: rev d3afd730acfa380ab5032be5ee296c5d73744518) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/util/TestCgroupsLCEResourcesHandler.java hadoop-yarn-project/CHANGES.txt

          People

            cnauroth Chris Nauroth
            cnauroth Chris Nauroth
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: