[YARN-2534] FairScheduler: Potential integer overflow calculating totalMaxShare

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.6.0
• Component/s: scheduler
• Hadoop Flags: Reviewed
• Assignee: Zhihai Xu
• Reporter: Zhihai Xu
• Created: 11/Sep/14 03:38
• Updated: 01/Dec/14 03:10
• Resolved: 11/Sep/14 19:11

Description

FairScheduler: totalMaxShare is not calculated correctly in computeSharesInternal for some cases.
If the sum of MAX share of all Schedulables is more than Integer.MAX_VALUE ,but each individual MAX share is not equal to Integer.MAX_VALUE. then totalMaxShare will be a negative value, which will cause all fairShare are wrongly calculated.