[YARN-2484] FileSystemRMStateStore#readFile/writeFile should close FSData(In|Out)putStream in final block

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Hadoop Flags: Reviewed
• Assignee: Tsuyoshi Ozawa
• Reporter: Tsuyoshi Ozawa
• Created: 30/Aug/14 17:33
• Updated: 01/Dec/14 03:07
• Resolved: 12/Sep/14 14:15

Description

File descriptors can leak if exceptions are thrown in these methods.

 private byte[] readFile(Path inputPath, long len) throws Exception {
    FSDataInputStream fsIn = fs.open(inputPath);
    // state data will not be that "long"
    byte[] data = new byte[(int)len];
    fsIn.readFully(data);
    fsIn.close();
    return data;
  }

  private void writeFile(Path outputPath, byte[] data) throws Exception {
    Path tempPath =
        new Path(outputPath.getParent(), outputPath.getName() + ".tmp");
    FSDataOutputStream fsOut = null;
    // This file will be overwritten when app/attempt finishes for saving the
    // final status.
    fsOut = fs.create(tempPath, true);
    fsOut.write(data);
    fsOut.close();
    fs.rename(tempPath, outputPath);
  }