Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2453

TestProportionalCapacityPreemptionPolicy fails with FairScheduler

VotersStop watchingWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.6.0
    • None
    • None
    • Reviewed

    Description

      TestProportionalCapacityPreemptionPolicy is failed for FairScheduler.
      The following is error message:
      Running org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy
      Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.94 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy
      testPolicyInitializeAfterSchedulerInitialized(org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy) Time elapsed: 1.61 sec <<< FAILURE!
      java.lang.AssertionError: Failed to find SchedulingMonitor service, please check what happened
      at org.junit.Assert.fail(Assert.java:88)
      at org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.TestProportionalCapacityPreemptionPolicy.testPolicyInitializeAfterSchedulerInitialized(TestProportionalCapacityPreemptionPolicy.java:469)

      This test should only work for capacity scheduler because the following source code in ResourceManager.java prove it will only work for capacity scheduler.

      if (scheduler instanceof PreemptableResourceScheduler
                && conf.getBoolean(YarnConfiguration.RM_SCHEDULER_ENABLE_MONITORS,
                YarnConfiguration.DEFAULT_RM_SCHEDULER_ENABLE_MONITORS)) {
      

      Because CapacityScheduler is instance of PreemptableResourceScheduler and FairScheduler is not instance of PreemptableResourceScheduler.
      I will upload a patch to fix this issue.

      Attachments

        1. YARN-2453.002.patch
          2 kB
          Zhihai Xu
        2. YARN-2453.001.patch
          2 kB
          Zhihai Xu
        3. YARN-2453.000.patch
          2 kB
          Zhihai Xu

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            zxu Zhihai Xu
            zxu Zhihai Xu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment