Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:

      Description

      a) YARN_PROXYSERVER_OPTS and YARN_PROXYSERVER_HEAP are not documented

      b) Defaults should get moved to yarn-config.sh instead of being specifically set

      c) Remove references to things that are covered elsewhere, deprecated, etc.

      1. YARN-2438.patch
        3 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1898 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1898/)
          YARN-2438. yarn-env.sh cleanup (aw) (aw: rev 0c8aec43f0acd4f896df8cd605d97808f9a09887)

          • hadoop-yarn-project/hadoop-yarn/conf/yarn-env.sh
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1898 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1898/ ) YARN-2438 . yarn-env.sh cleanup (aw) (aw: rev 0c8aec43f0acd4f896df8cd605d97808f9a09887) hadoop-yarn-project/hadoop-yarn/conf/yarn-env.sh hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1873 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1873/)
          YARN-2438. yarn-env.sh cleanup (aw) (aw: rev 0c8aec43f0acd4f896df8cd605d97808f9a09887)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/conf/yarn-env.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1873 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1873/ ) YARN-2438 . yarn-env.sh cleanup (aw) (aw: rev 0c8aec43f0acd4f896df8cd605d97808f9a09887) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/conf/yarn-env.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #682 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/682/)
          YARN-2438. yarn-env.sh cleanup (aw) (aw: rev 0c8aec43f0acd4f896df8cd605d97808f9a09887)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/conf/yarn-env.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #682 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/682/ ) YARN-2438 . yarn-env.sh cleanup (aw) (aw: rev 0c8aec43f0acd4f896df8cd605d97808f9a09887) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/conf/yarn-env.sh
          Hide
          aw Allen Wittenauer added a comment -

          +1 self. committing to trunk.

          Show
          aw Allen Wittenauer added a comment - +1 self. committing to trunk.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12668821/YARN-2438.patch
          against trunk revision 43b0303.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4961//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4961//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668821/YARN-2438.patch against trunk revision 43b0303. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4961//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4961//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          If HADOOP-10950 goes in first, this patch needs to updated for it.

          Show
          aw Allen Wittenauer added a comment - If HADOOP-10950 goes in first, this patch needs to updated for it.
          Hide
          aw Allen Wittenauer added a comment -

          Ofc, HADOOP-10950 would make heap management much more obvious.

          Show
          aw Allen Wittenauer added a comment - Ofc, HADOOP-10950 would make heap management much more obvious.
          Hide
          aw Allen Wittenauer added a comment -

          I'm going to assume you are talking about the defaults that are listed in the yarn-env.sh file? The code sort of cheats. The actual default is set by HADOOP_HEAPSIZE. So really that default is a lie. Good catch!

          Looking at other stuff, I have a strong doubt that the yarn-policy file is actually used. I'll file a separate jira to deprecate that. The rest should get defined properly in the project init.

          Show
          aw Allen Wittenauer added a comment - I'm going to assume you are talking about the defaults that are listed in the yarn-env.sh file? The code sort of cheats. The actual default is set by HADOOP_HEAPSIZE. So really that default is a lie. Good catch! Looking at other stuff, I have a strong doubt that the yarn-policy file is actually used. I'll file a separate jira to deprecate that. The rest should get defined properly in the project init.
          Hide
          pocky John Smith added a comment -

          How do the yarn heap sizes get set?

          Show
          pocky John Smith added a comment - How do the yarn heap sizes get set?

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development