Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2336

Fair scheduler REST api returns a missing '[' bracket JSON for deep queue tree

    Details

    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Fix FairScheduler's REST api returns a missing '[' blacket JSON for childQueues.

      Description

      When we have sub queues in Fair Scheduler, REST api returns a missing '[' blacket JSON for childQueues.
      This issue found by Akira Ajisaka at YARN-1050.

      1. YARN-2336.005.patch
        16 kB
        Akira Ajisaka
      2. YARN-2336.007.patch
        21 kB
        Akira Ajisaka
      3. YARN-2336.008.patch
        21 kB
        Akira Ajisaka
      4. YARN-2336.009.patch
        25 kB
        Tsuyoshi Ozawa
      5. YARN-2336.009.patch
        25 kB
        Akira Ajisaka
      6. YARN-2336.patch
        10 kB
        Kenji Kikushima
      7. YARN-2336-2.patch
        9 kB
        Kenji Kikushima
      8. YARN-2336-3.patch
        10 kB
        Kenji Kikushima
      9. YARN-2336-4.patch
        9 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2155 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2155/)
          YARN-2336. Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2155 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2155/ ) YARN-2336 . Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #207 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/207/)
          YARN-2336. Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #207 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/207/ ) YARN-2336 . Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #197 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/197/)
          YARN-2336. Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #197 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/197/ ) YARN-2336 . Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2137 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2137/)
          YARN-2336. Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2137 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2137/ ) YARN-2336 . Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          Hide
          ajisakaa Akira Ajisaka added a comment -
          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Tsuyoshi Ozawa and Kenji Kikushima !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #939 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/939/)
          YARN-2336. Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #939 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/939/ ) YARN-2336 . Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #208 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/208/)
          YARN-2336. Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #208 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/208/ ) YARN-2336 . Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java hadoop-yarn-project/CHANGES.txt
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Committed this to trunk and branch-2. Thanks Kenji Kikushima and Akira Ajisaka for your contributions and reports!

          Show
          ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Kenji Kikushima and Akira Ajisaka for your contributions and reports!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7901 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7901/)
          YARN-2336. Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7901 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7901/ ) YARN-2336 . Fair scheduler's REST API returns a missing '[' bracket JSON for deep queue tree. Contributed by Kenji Kikushima and Akira Ajisaka. (ozawa: rev 9a3d617b6325d8918f2833c3e9ce329ecada9242) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfoList.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/FairSchedulerQueueInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          +1, committing this shortly.

          Show
          ozawa Tsuyoshi Ozawa added a comment - +1, committing this shortly.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 39s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 31s There were no new javac warning messages.
          +1 javadoc 9m 34s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 57s Site still builds.
          -1 checkstyle 0m 45s The applied patch generated 1 new checkstyle issues (total was 8, now 8).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 49m 57s Tests passed in hadoop-yarn-server-resourcemanager.
              92m 12s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12734018/YARN-2336.009.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / ce53c8e
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8020/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8020/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8020/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8020/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 31s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 2m 57s Site still builds. -1 checkstyle 0m 45s The applied patch generated 1 new checkstyle issues (total was 8, now 8). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 49m 57s Tests passed in hadoop-yarn-server-resourcemanager.     92m 12s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734018/YARN-2336.009.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / ce53c8e checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8020/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8020/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8020/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8020/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The test failure looks unrelated to the patch. Kicked https://builds.apache.org/job/PreCommit-YARN-Build/8020/

          Show
          ajisakaa Akira Ajisaka added a comment - The test failure looks unrelated to the patch. Kicked https://builds.apache.org/job/PreCommit-YARN-Build/8020/
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 59s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 47s There were no new javac warning messages.
          +1 javadoc 9m 58s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 0s Site still builds.
          +1 checkstyle 0m 47s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 49m 59s Tests failed in hadoop-yarn-server-resourcemanager.
              93m 19s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12734018/YARN-2336.009.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 7401e5b
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8013/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8013/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8013/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 0s Site still builds. +1 checkstyle 0m 47s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 49m 59s Tests failed in hadoop-yarn-server-resourcemanager.     93m 19s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734018/YARN-2336.009.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 7401e5b hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8013/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8013/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8013/console This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Submitting Akira's patch again sicne YARN-3677 is fixed now.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Submitting Akira's patch again sicne YARN-3677 is fixed now.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The test failure looks unrelated to the patch. The test passed locally.
          The findbugs warning is not related to the patch. See YARN-3677 for detail.

          Show
          ajisakaa Akira Ajisaka added a comment - The test failure looks unrelated to the patch. The test passed locally. The findbugs warning is not related to the patch. See YARN-3677 for detail.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 14s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 41s There were no new javac warning messages.
          +1 javadoc 9m 54s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 59s Site still builds.
          +1 checkstyle 0m 34s There were no new checkstyle issues.
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 1m 16s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 52m 5s Tests failed in hadoop-yarn-server-resourcemanager.
              95m 18s  



          Reason Tests
          FindBugs module:hadoop-yarn-server-resourcemanager
            Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java:[line 156]
          Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733572/YARN-2336.009.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / bcc1786
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7969/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7969/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7969/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7969/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 14s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 54s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. +1 checkstyle 0m 34s There were no new checkstyle issues. +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 1m 16s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. -1 yarn tests 52m 5s Tests failed in hadoop-yarn-server-resourcemanager.     95m 18s   Reason Tests FindBugs module:hadoop-yarn-server-resourcemanager   Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java: [line 156] Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733572/YARN-2336.009.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / bcc1786 Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7969/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7969/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7969/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7969/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Tsuyoshi Ozawa for comments! Updated the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Tsuyoshi Ozawa for comments! Updated the patch.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Akira Ajisaka thank you for updating. We're almost there.

          TestRMWebServicesFairScheduler#testClusterSchedulerWithSubQueues: Can we add a following test to verify non-existence of the field 'childQueues'? Also, could you add a same kind of test to TestRMWebServicesCapacitySched for the consistency of APIs between CapacityScheduler and FairScheduler?

              try {
                subQueueInfo.getJSONObject(1).getJSONObject("childQueues");
                Assert.fail("subQueue should omit field 'childQueues' when childQueue " +
                    "is empty.");
              } catch (JSONException je) {
                je.getMessage().contains("JSONObject[\"childQueues\"] not found.");
              }
          

          ResourceManagerRest.md: we should describe "childQueues is omitted if the queue doesn't have childQueue":

          | childQueues | array of queues(JSON)/queue objects(XML) | A collection of sub-queue information |
          

          We should fix CapacityScheduler's 'queues' field as same as FairScheduler's one:

          | queues | array of queues(JSON)/zero or more queue objects(XML) | A collection of queue resources |
          

          Minor nits: A following comment can be fixed as "return null to omit childQueues field when its size is zero.". Also we should add a reason to do this like "This is for consistency of return value of REST API between FairScheduler and CapacityScheduler - childQueues and ". What do you think?

          +    // return null for FairSchedulerLeafQueueInfo to avoid childQueues being
          +    // displayed in the response of REST API.
          
          Show
          ozawa Tsuyoshi Ozawa added a comment - Akira Ajisaka thank you for updating. We're almost there. TestRMWebServicesFairScheduler#testClusterSchedulerWithSubQueues: Can we add a following test to verify non-existence of the field 'childQueues'? Also, could you add a same kind of test to TestRMWebServicesCapacitySched for the consistency of APIs between CapacityScheduler and FairScheduler? try { subQueueInfo.getJSONObject(1).getJSONObject( "childQueues" ); Assert.fail( "subQueue should omit field 'childQueues' when childQueue " + "is empty." ); } catch (JSONException je) { je.getMessage().contains( "JSONObject[\" childQueues\ "] not found." ); } ResourceManagerRest.md: we should describe "childQueues is omitted if the queue doesn't have childQueue": | childQueues | array of queues(JSON)/queue objects(XML) | A collection of sub-queue information | We should fix CapacityScheduler's 'queues' field as same as FairScheduler's one: | queues | array of queues(JSON)/zero or more queue objects(XML) | A collection of queue resources | Minor nits: A following comment can be fixed as "return null to omit childQueues field when its size is zero.". Also we should add a reason to do this like "This is for consistency of return value of REST API between FairScheduler and CapacityScheduler - childQueues and ". What do you think? + // return null for FairSchedulerLeafQueueInfo to avoid childQueues being + // displayed in the response of REST API.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          OK, I'm checking it.

          Show
          ozawa Tsuyoshi Ozawa added a comment - OK, I'm checking it.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Tsuyoshi Ozawa, would you please review the latest patch?

          Show
          ajisakaa Akira Ajisaka added a comment - Tsuyoshi Ozawa , would you please review the latest patch?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The findbugs warning looks unrelated to the patch. The patch doesn't touch the class.

          Show
          ajisakaa Akira Ajisaka added a comment - The findbugs warning looks unrelated to the patch. The patch doesn't touch the class.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 34s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 29s There were no new javac warning messages.
          +1 javadoc 9m 38s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 57s Site still builds.
          +1 checkstyle 0m 47s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          -1 findbugs 1m 18s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 50m 3s Tests passed in hadoop-yarn-server-resourcemanager.
              92m 18s  



          Reason Tests
          FindBugs module:hadoop-yarn-server-resourcemanager
            Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java:[line 156]



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733037/YARN-2336.008.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 9a2a955
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7947/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7947/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7947/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7947/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 57s Site still builds. +1 checkstyle 0m 47s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. -1 findbugs 1m 18s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 yarn tests 50m 3s Tests passed in hadoop-yarn-server-resourcemanager.     92m 18s   Reason Tests FindBugs module:hadoop-yarn-server-resourcemanager   Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java: [line 156] Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733037/YARN-2336.008.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 9a2a955 Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/7947/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7947/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7947/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7947/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          v8 patch: Fixed checkstyle and whitespace issues.

          Show
          ajisakaa Akira Ajisaka added a comment - v8 patch: Fixed checkstyle and whitespace issues.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 45s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 37s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 57s Site still builds.
          -1 checkstyle 0m 46s The applied patch generated 2 new checkstyle issues (total was 8, now 9).
          -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 54m 52s Tests passed in hadoop-yarn-server-resourcemanager.
              97m 19s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732860/YARN-2336.007.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / def9136
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7934/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7934/artifact/patchprocess/whitespace.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7934/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7934/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7934/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 45s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 57s Site still builds. -1 checkstyle 0m 46s The applied patch generated 2 new checkstyle issues (total was 8, now 9). -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 54m 52s Tests passed in hadoop-yarn-server-resourcemanager.     97m 19s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732860/YARN-2336.007.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / def9136 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7934/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7934/artifact/patchprocess/whitespace.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7934/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7934/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7934/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          v7 patch:

          • Removed "childQueues" from output in FairSchedulerLeafQueueInfo.
          • Updated document for JSON and XML.
          Show
          ajisakaa Akira Ajisaka added a comment - v7 patch: Removed "childQueues" from output in FairSchedulerLeafQueueInfo. Updated document for JSON and XML.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          I'd like to review it. Please ping me after fixing the issue.

          Show
          ozawa Tsuyoshi Ozawa added a comment - I'd like to review it. Please ping me after fixing the issue.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Should we remove childQueue when childQueue is null for the consistency?

          Agree. I'll remove it from FairSchedulerLeafQueueInfo.

          Show
          ajisakaa Akira Ajisaka added a comment - Should we remove childQueue when childQueue is null for the consistency? Agree. I'll remove it from FairSchedulerLeafQueueInfo.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          I see. Should we remove childQueue when childQueue is null for the consistency? CapacityScheduler doesn't return childQueues if queue is null(empty).

          Show
          ozawa Tsuyoshi Ozawa added a comment - I see. Should we remove childQueue when childQueue is null for the consistency? CapacityScheduler doesn't return childQueues if queue is null(empty).
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I think childQueue should be array instead of map without key, "queue" since the key looks redundant. What do you think?

          I think the schema is redundant but CapacityScheduler has the same (redundant) schema.

          "queues": {
              "queue": [
                  {
          

          I'd like to keep the consistency.

          Show
          ajisakaa Akira Ajisaka added a comment - I think childQueue should be array instead of map without key, "queue" since the key looks redundant. What do you think? I think the schema is redundant but CapacityScheduler has the same (redundant) schema. "queues" : { "queue" : [ { I'd like to keep the consistency.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          I failed the markup :-P

          childQueues(array)
           |---- childQueues(array)
                    |---- childQueues(array)
           |---- childQueues(array)
          
          Show
          ozawa Tsuyoshi Ozawa added a comment - I failed the markup :-P childQueues(array) |---- childQueues(array) |---- childQueues(array) |---- childQueues(array)
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Akira Ajisaka thank you for clarification. It makes sense to me.

          I have a comment about return value. I think childQueue should be array instead of map without key, "queue" since the key looks redundant. What do you think?

          + "childQueues": {
          + "queue": [
          + {

          A following data structure looks more straight forward to me:

          childQueues(array)

          ---- childQueues(array)
          ---- childQueues
          ---- childQueues(array

          I meant that the test code should be as follows in this case, for example:

              JSONArray subQueueInfo = json.getJSONObject("scheduler")
                  .getJSONObject("schedulerInfo").getJSONObject("rootQueue")
                  .getJSONArray("childQueues").getJSONObject(1)
                  .getJSONArray("childQueues");
              // subQueueInfo is consist of subqueue1 and subqueue2 info
              assertEquals(2, subQueueInfo.length());
          
          Show
          ozawa Tsuyoshi Ozawa added a comment - Akira Ajisaka thank you for clarification. It makes sense to me. I have a comment about return value. I think childQueue should be array instead of map without key, "queue" since the key looks redundant. What do you think? + "childQueues": { + "queue": [ + { A following data structure looks more straight forward to me: childQueues(array) ---- childQueues(array) ---- childQueues ---- childQueues(array I meant that the test code should be as follows in this case, for example: JSONArray subQueueInfo = json.getJSONObject( "scheduler" ) .getJSONObject( "schedulerInfo" ).getJSONObject( "rootQueue" ) .getJSONArray( "childQueues" ).getJSONObject(1) .getJSONArray( "childQueues" ); // subQueueInfo is consist of subqueue1 and subqueue2 info assertEquals(2, subQueueInfo.length());
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Tsuyoshi Ozawa for reviewing the patch.

          We have an option to return empty hash, {}, or array, []. Currently, "users", another collection field which can be returned in RM's RESTful API, returns null. In the context, the behaviour of your patch looks consistent to me.

          Returning {} is a good choice, however, consistency is more important for me. Users may confuse if FairScheduler's REST API is different from other REST APIs.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Tsuyoshi Ozawa for reviewing the patch. We have an option to return empty hash, {}, or array, []. Currently, "users", another collection field which can be returned in RM's RESTful API, returns null. In the context, the behaviour of your patch looks consistent to me. Returning {} is a good choice, however, consistency is more important for me. Users may confuse if FairScheduler's REST API is different from other REST APIs.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Akira Ajisaka thank you for updating. Let me confirm one point. What do you think about the null value of "childQueues" when queue doesn't exist? We have an option to return empty hash, {}, or array, []. Currently, "users", another collection field which can be returned in RM's RESTful API, returns null. In the context, the behaviour of your patch looks consistent to me. This is just a confirmation.

          +                                "queue": [
          +                                    {
          +                                        "childQueues": null,
          
          Show
          ozawa Tsuyoshi Ozawa added a comment - Akira Ajisaka thank you for updating. Let me confirm one point. What do you think about the null value of "childQueues" when queue doesn't exist? We have an option to return empty hash, {}, or array, []. Currently, "users", another collection field which can be returned in RM's RESTful API, returns null. In the context, the behaviour of your patch looks consistent to me. This is just a confirmation. + "queue" : [ + { + "childQueues" : null ,
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Taking a look at the patch shortly.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Taking a look at the patch shortly.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 35s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 31s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 56s Site still builds.
          +1 checkstyle 0m 25s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 13s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          -1 yarn tests 62m 24s Tests failed in hadoop-yarn-server-resourcemanager.
              104m 13s  



          Reason Tests
          Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732190/YARN-2336.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / f24452d
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7905/artifact/patchprocess/whitespace.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7905/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7905/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7905/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 31s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 56s Site still builds. +1 checkstyle 0m 25s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 13s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 yarn tests 62m 24s Tests failed in hadoop-yarn-server-resourcemanager.     104m 13s   Reason Tests Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732190/YARN-2336.005.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / f24452d whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7905/artifact/patchprocess/whitespace.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7905/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7905/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7905/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 17s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 46s There were no new javac warning messages.
          +1 javadoc 9m 56s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 59s Site still builds.
          -1 checkstyle 0m 48s The applied patch generated 2 new checkstyle issues (total was 8, now 9).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 0m 15s The patch appears to cause Findbugs (version 2.0.3) to fail.
          +1 yarn tests 52m 33s Tests passed in hadoop-yarn-server-resourcemanager.
              95m 9s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732190/YARN-2336.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 360dff5
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7880/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7880/artifact/patchprocess/whitespace.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7880/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7880/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7880/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 17s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 9m 56s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. -1 checkstyle 0m 48s The applied patch generated 2 new checkstyle issues (total was 8, now 9). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 0m 15s The patch appears to cause Findbugs (version 2.0.3) to fail. +1 yarn tests 52m 33s Tests passed in hadoop-yarn-server-resourcemanager.     95m 9s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732190/YARN-2336.005.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 360dff5 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7880/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/7880/artifact/patchprocess/whitespace.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7880/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7880/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7880/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Marking this issue as incompatible change since this fix includes API change.

          Show
          ajisakaa Akira Ajisaka added a comment - Marking this issue as incompatible change since this fix includes API change.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          v5 patch

          • rebased for the latest trunk
          • updated the document
          Show
          ajisakaa Akira Ajisaka added a comment - v5 patch rebased for the latest trunk updated the document
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707684/YARN-2336-4.patch
          against trunk revision 47782cb.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.TestRMHA
          org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService
          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication
          org.apache.hadoop.yarn.server.resourcemanager.TestMoveApplication
          org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7119//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7119//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707684/YARN-2336-4.patch against trunk revision 47782cb. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.TestRMHA org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication org.apache.hadoop.yarn.server.resourcemanager.TestMoveApplication org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7119//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7119//console This message is automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Rebased for the latest trunk.

          Show
          ajisakaa Akira Ajisaka added a comment - Rebased for the latest trunk.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Kenji Kikushima, would you rebase the patch for trunk?

          Show
          ajisakaa Akira Ajisaka added a comment - Hi Kenji Kikushima , would you rebase the patch for trunk?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12657750/YARN-2336-3.patch
          against trunk revision af08425.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6564//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657750/YARN-2336-3.patch against trunk revision af08425. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6564//console This message is automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Kenji Kikushima for the update. +1 (non-binding).

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Kenji Kikushima for the update. +1 (non-binding).
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12657750/YARN-2336-3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4425//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4425//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657750/YARN-2336-3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4425//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4425//console This message is automatically generated.
          Hide
          kj-ki Kenji Kikushima added a comment -

          Thanks for review, Akira Ajisaka. Updated for comments.

          • Removed unused variables(leaf1/leaf2)
          • Adjusted under 80 characters
          • Removed unused import from FairSchedulerQueueInfo.java
          Show
          kj-ki Kenji Kikushima added a comment - Thanks for review, Akira Ajisaka . Updated for comments. Removed unused variables(leaf1/leaf2) Adjusted under 80 characters Removed unused import from FairSchedulerQueueInfo.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The patch looks mostly good. I built a pseudo-distributed cluster and verified the JSON response.
          Some minor comments:

              FSLeafQueue leaf1 = queueManager.getLeafQueue("root.q.subqueue1", true);
              FSLeafQueue leaf2 = queueManager.getLeafQueue("root.q.subqueue2", true);
          

          In the test, the above code is only to create LeafQueue and leaf1 and leaf2 are unused, so I think it's better to comment that as follows:

              // create LeafQueue
              queueManager.getLeafQueue("root.q.subqueue1", true);
              queueManager.getLeafQueue("root.q.subqueue2", true);
          
            public void testClusterSchedulerWithSubQueues() throws JSONException, Exception {
          

          Would you render the line within 80 characters?
          In addition, would you please remove unused import from FairSchedulerQueueInfo.java?

          Show
          ajisakaa Akira Ajisaka added a comment - The patch looks mostly good. I built a pseudo-distributed cluster and verified the JSON response. Some minor comments: FSLeafQueue leaf1 = queueManager.getLeafQueue( "root.q.subqueue1" , true ); FSLeafQueue leaf2 = queueManager.getLeafQueue( "root.q.subqueue2" , true ); In the test, the above code is only to create LeafQueue and leaf1 and leaf2 are unused, so I think it's better to comment that as follows: // create LeafQueue queueManager.getLeafQueue( "root.q.subqueue1" , true ); queueManager.getLeafQueue( "root.q.subqueue2" , true ); public void testClusterSchedulerWithSubQueues() throws JSONException, Exception { Would you render the line within 80 characters? In addition, would you please remove unused import from FairSchedulerQueueInfo.java?
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12657339/YARN-2336-2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4403//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4403//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657339/YARN-2336-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4403//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4403//console This message is automatically generated.
          Hide
          kj-ki Kenji Kikushima added a comment -

          Fixed test failure.

          Show
          kj-ki Kenji Kikushima added a comment - Fixed test failure.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12657259/YARN-2336.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4398//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4398//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657259/YARN-2336.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4398//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4398//console This message is automatically generated.
          Hide
          kj-ki Kenji Kikushima added a comment -

          Attached a patch.
          To notice childQueues as a collection to JSONJAXBContext, this patch introduces FairSchedulerQueueInfoList.
          I refered to MAPREDUCE-4020.

          Show
          kj-ki Kenji Kikushima added a comment - Attached a patch. To notice childQueues as a collection to JSONJAXBContext, this patch introduces FairSchedulerQueueInfoList. I refered to MAPREDUCE-4020 .

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              kj-ki Kenji Kikushima
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development