Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      While running yarn container -list <Application Attempt ID> command, some observations:

      1) the scheme (e.g. http/https ) before LOG-URL is missing
      2) the start-time is printed as milli seconds (e.g. 1405540544844). Better to print as time format.
      3) finish-time is 0 if container is not yet finished. May be "N/A"
      4) May have an option to run as yarn container -list <appId> OR yarn application -list-containers <appId> also.
      As attempt Id is not shown on console, this is easier for user to just copy the appId and run it, may also be useful for container-preserving AM restart.

      1. YARN-2301.01.patch
        9 kB
        Naganarasimha G R
      2. YARN-2303.patch
        9 kB
        Naganarasimha G R
      3. YARN-2301.03.patch
        10 kB
        Naganarasimha G R
      4. YARN-2301.20141120-1.patch
        16 kB
        Naganarasimha G R
      5. YARN-2301.20141203-1.patch
        16 kB
        Naganarasimha G R
      6. YARN-2301.20141204-1.patch
        16 kB
        Naganarasimha G R
      7. YARN-2301-branch-2.6.1.txt
        17 kB
        Vinod Kumar Vavilapalli

        Activity

        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Jian He
        Could i work on this issue ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Jian He Could i work on this issue ?
        Hide
        jianhe Jian He added a comment -

        Naganarasimha G R, sure, thanks for working it!

        Show
        jianhe Jian He added a comment - Naganarasimha G R , sure, thanks for working it!
        Hide
        zjshen Zhijie Shen added a comment -

        As attempt Id is not shown on console, this is easier for user to just copy the appId and run it, may also be useful for container-preserving AM restart.

        You can run yarn appattempt to get the attempt. Anyway it's arguable if it is user friendly or not. Given adding a function, I vote for yarn container -list <appId>

        One more comment. “yarn container” can source the container information either from RM or from timeline server. When making the changes, please make sure the both sides are changed consistently

        Show
        zjshen Zhijie Shen added a comment - As attempt Id is not shown on console, this is easier for user to just copy the appId and run it, may also be useful for container-preserving AM restart. You can run yarn appattempt to get the attempt. Anyway it's arguable if it is user friendly or not. Given adding a function, I vote for yarn container -list <appId> One more comment. “yarn container” can source the container information either from RM or from timeline server. When making the changes, please make sure the both sides are changed consistently
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Zhijie Shen for the comments,

        I feel it would be easy to hit a single command and i would like to add "yarn container -list <appId>"
        I will consider the changes for container information got from Timeline/History server also.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Zhijie Shen for the comments, I feel it would be easy to hit a single command and i would like to add "yarn container -list <appId>" I will consider the changes for container information got from Timeline/History server also.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Jian He and Zhijie Shen
        I have fixed the first 3 but while working for the 4th one with Zhijie Shen comments

        4) May have an option to run as yarn container -list <appId>

        i had to pick few alternatives so wanted opinion from you guys before i go forward

        1. Issue1 : As i understand this option should be in addition to yarn container -list <Application Attempt ID>, As its CLI we can't have polymorphic parameters,
          so i thought of providing command like yarn container -list-forAppId <Application ID>. Is this option fine ? And please note GetContainersRequestProto api will be changed
        2. Issue2 : As Zhijie Shen pointed out we need to take care for containers from Timeline server flow also. For this i would suggest few options
          • Option1: For the given AppID When application is still running (RM flow), Only show containers for the current running application attempt irrespective of the earlier failure attempts.
            When application is finished(Timeline server flow), Only show containers for the last attempt of the application (whether its failed or succeded)
          • Option2: Introduce new additional parameter like -all,-last.
            And let -last behave similar to option 1 and the default option and
            for -all in both flows (RM and Timeline server flow) we display containers for each attempt.
        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Jian He and Zhijie Shen I have fixed the first 3 but while working for the 4th one with Zhijie Shen comments 4) May have an option to run as yarn container -list <appId> i had to pick few alternatives so wanted opinion from you guys before i go forward Issue1 : As i understand this option should be in addition to yarn container -list <Application Attempt ID> , As its CLI we can't have polymorphic parameters, so i thought of providing command like yarn container -list-forAppId <Application ID> . Is this option fine ? And please note GetContainersRequestProto api will be changed Issue2 : As Zhijie Shen pointed out we need to take care for containers from Timeline server flow also. For this i would suggest few options Option1: For the given AppID When application is still running (RM flow), Only show containers for the current running application attempt irrespective of the earlier failure attempts. When application is finished(Timeline server flow), Only show containers for the last attempt of the application (whether its failed or succeded) Option2: Introduce new additional parameter like -all , -last . And let -last behave similar to option 1 and the default option and for -all in both flows (RM and Timeline server flow) we display containers for each attempt.
        Hide
        zjshen Zhijie Shen added a comment -

        Issue1 : As i understand this option should be in addition to yarn container -list <Application Attempt ID>, As its CLI we can't have polymorphic parameters,

        How about having -list only, and then parsing whether the given id is app id or app attempt id?

        Issue2 : As Zhijie Shen pointed out we need to take care for containers from Timeline server flow also. For this i would suggest few options

        Option 2 sounds more attractive to me if it doesn't introduce too much complexity.

        >Jian He, I don't tracking the recent scheduler changes. Is it able to show the containers of previous app attempt, or the finished containers of the current app attempt? Previously, the container is removed from the scheduler if it is finished.

        If so, -all can only work for the application in the timeline server but not the running app in RM.

        Show
        zjshen Zhijie Shen added a comment - Issue1 : As i understand this option should be in addition to yarn container -list <Application Attempt ID>, As its CLI we can't have polymorphic parameters, How about having -list only, and then parsing whether the given id is app id or app attempt id? Issue2 : As Zhijie Shen pointed out we need to take care for containers from Timeline server flow also. For this i would suggest few options Option 2 sounds more attractive to me if it doesn't introduce too much complexity. > Jian He , I don't tracking the recent scheduler changes. Is it able to show the containers of previous app attempt, or the finished containers of the current app attempt? Previously, the container is removed from the scheduler if it is finished. If so, -all can only work for the application in the timeline server but not the running app in RM.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        How about having -list only, and then parsing whether the given id is app id or app attempt id?

        Coding wise i dont see any troubles for this approach but CLI design wise not sure whether a command can take either one of the params Jian He can you please share your thoughts on this too.

        Show
        Naganarasimha Naganarasimha G R added a comment - How about having -list only, and then parsing whether the given id is app id or app attempt id? Coding wise i dont see any troubles for this approach but CLI design wise not sure whether a command can take either one of the params Jian He can you please share your thoughts on this too.
        Hide
        jianhe Jian He added a comment -

        How about having -list only, and then parsing whether the given id is app id or app attempt id?

        I think it's fine to just have -list only.

        is it able to show the containers of previous app attempt, or the finished containers of the current app attempt?

        finished containers are removed from schedulers. Naganarasimha G R, let's leave 4) separately as it involves more changes and discussion. could you post your patch which fixed the first 3 ? thanks!

        Show
        jianhe Jian He added a comment - How about having -list only, and then parsing whether the given id is app id or app attempt id? I think it's fine to just have -list only. is it able to show the containers of previous app attempt, or the finished containers of the current app attempt? finished containers are removed from schedulers. Naganarasimha G R , let's leave 4) separately as it involves more changes and discussion. could you post your patch which fixed the first 3 ? thanks!
        Hide
        devaraj.k Devaraj K added a comment -

        Here it is trying allocate this memory for heap size. And we need to leave the remaing memory for launching the Child container java process, native memory, etc.

        As Jian He mentioned, RM removes the completed containers or containers for completed attempts. I think there would not be much useful by providing completed appAttemptId for -list param and displaying some message or empty result.

        I would think of giving appId option for -list (i.e. -list <appId>) and print the containers running for current application attempt.

        Show
        devaraj.k Devaraj K added a comment - Here it is trying allocate this memory for heap size. And we need to leave the remaing memory for launching the Child container java process, native memory, etc. As Jian He mentioned, RM removes the completed containers or containers for completed attempts. I think there would not be much useful by providing completed appAttemptId for -list param and displaying some message or empty result. I would think of giving appId option for -list (i.e. -list <appId>) and print the containers running for current application attempt.
        Hide
        zjshen Zhijie Shen added a comment -

        I think there would not be much useful by providing completed appAttemptId for -list param and displaying some message or empty result.

        As I mentioned before, the command is going to be applied to both RM and timeline server. The latter is going to record the completed containers. -list <appId> is able to list all the containers from the side of the timeline server, and I hope it could work. So how about doing this for -list <appId|appAttemptId> <additional opts>?

        • appAttemptId: containers of a specific app attempt in RM/Timeline server (for the case of RM, it is likely to show empty container list, but it's fine and it is actually the current situation).
        • appId with no additional opt: containers of the last(current) app attempt in RM/Timeline server
        • appId with -last: containers of the last(current) app attempt in RM/Timeline server
          *appId with -all: containers of all app attempts in RM/Timeline server

        Does this make sense?

        Show
        zjshen Zhijie Shen added a comment - I think there would not be much useful by providing completed appAttemptId for -list param and displaying some message or empty result. As I mentioned before, the command is going to be applied to both RM and timeline server. The latter is going to record the completed containers. -list <appId> is able to list all the containers from the side of the timeline server, and I hope it could work. So how about doing this for -list <appId|appAttemptId> <additional opts>? appAttemptId: containers of a specific app attempt in RM/Timeline server (for the case of RM, it is likely to show empty container list, but it's fine and it is actually the current situation). appId with no additional opt: containers of the last(current) app attempt in RM/Timeline server appId with -last: containers of the last(current) app attempt in RM/Timeline server *appId with -all: containers of all app attempts in RM/Timeline server Does this make sense?
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Zhijie Shen for the clarification.

        +1 for the above approach.

        Show
        devaraj.k Devaraj K added a comment - Thanks Zhijie Shen for the clarification. +1 for the above approach.
        Hide
        sunilg Sunil G added a comment -

        This will be really useful enhancement.

        I have a concern here.

        yarn container -list <appId|appAttemptId> <additional opts>

        • list with <additional opts> comes after the variable input from user (appId|appAttemptId).
          And <additional opts> is only for one of the type named appId. May be it may confuse user also, like which sub option needs the <additional opts>.
          I feel may be we can have a new command itself for listing application container.
          A suggestion is:
          yarn container -list-appid <appId> <additional opts> 
          yarn container -list-appattemptid  <appAttemptId>
          

          OR

          yarn application -list-containers <appId>
          
        • I feel sequential checks with ConverterUtils.toApplicationID and ConverterUtils.toApplicationAttemptId has to be done to know whether input is appId|appAttemptId.
          So rediercting to my point 1, if seperate command is there, may be it can be handled in a better way from applicationCLI (rather than handling specific types of exceptions).
          Please share your thoughts
        Show
        sunilg Sunil G added a comment - This will be really useful enhancement. I have a concern here. yarn container -list <appId|appAttemptId> <additional opts> list with <additional opts> comes after the variable input from user (appId|appAttemptId). And <additional opts> is only for one of the type named appId . May be it may confuse user also, like which sub option needs the <additional opts>. I feel may be we can have a new command itself for listing application container. A suggestion is: yarn container -list-appid <appId> <additional opts> yarn container -list-appattemptid <appAttemptId> OR yarn application -list-containers <appId> I feel sequential checks with ConverterUtils.toApplicationID and ConverterUtils.toApplicationAttemptId has to be done to know whether input is appId|appAttemptId. So rediercting to my point 1, if seperate command is there, may be it can be handled in a better way from applicationCLI (rather than handling specific types of exceptions). Please share your thoughts
        Hide
        zjshen Zhijie Shen added a comment -

        Sunil G, thanks for your input. Here's my response.

        And <additional opts> is only for one of the type named appId. May be it may confuse user also, like which sub option needs the <additional opts>.

        I don't worry too much about it, because we can update the usage block to let users how to use the opts correctly. When users make the mistake, they will be redirect the usage output.

        I feel may be we can have a new command itself for listing application container.

        I incline not to change the command to keep backward compatibility.

        I feel sequential checks with ConverterUtils.toApplicationID and ConverterUtils.toApplicationAttemptId has to be done to know whether input is appId|appAttemptId.

        We can use ConverterUtils.APPLICATION_PREFIX and ConverterUtils.APPLICATION_ATTEMPT_PREFIX to check the prefix of the given id to determine whether it is the app id or the app attempt id. We don't need to handle the exception actually.

        Show
        zjshen Zhijie Shen added a comment - Sunil G , thanks for your input. Here's my response. And <additional opts> is only for one of the type named appId. May be it may confuse user also, like which sub option needs the <additional opts>. I don't worry too much about it, because we can update the usage block to let users how to use the opts correctly. When users make the mistake, they will be redirect the usage output. I feel may be we can have a new command itself for listing application container. I incline not to change the command to keep backward compatibility. I feel sequential checks with ConverterUtils.toApplicationID and ConverterUtils.toApplicationAttemptId has to be done to know whether input is appId|appAttemptId. We can use ConverterUtils.APPLICATION_PREFIX and ConverterUtils.APPLICATION_ATTEMPT_PREFIX to check the prefix of the given id to determine whether it is the app id or the app attempt id. We don't need to handle the exception actually.
        Hide
        sunilg Sunil G added a comment -

        we can update the usage block to let users how to use the opts correctly. When users make the mistake, they will be redirect the usage output

        +1. Yes. User can be redirected back correct usage.

        Show
        sunilg Sunil G added a comment - we can update the usage block to let users how to use the opts correctly. When users make the mistake, they will be redirect the usage output +1. Yes. User can be redirected back correct usage.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Zhijie Shen,Sunil G,Devaraj K & Jian He for the comments,
        I will start modifying as per Zhijie Shen's approach and try to provide the patch at the earliest.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Zhijie Shen , Sunil G , Devaraj K & Jian He for the comments, I will start modifying as per Zhijie Shen 's approach and try to provide the patch at the earliest.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi All,
        Sorry for the break, i was in transit away from my home location and hence was not able to put more effort on this issue.
        Based on the initial understanding of the interface and commands documentation, i thought the suggestions mentioned by Zhijie Shen is feasible, but while coding and testing i came to realise
        that this command (or existing command: yarn container -list <appAttemptID>) behaves differently when it hits RM and AHS.
        RM provides only live running containers and only when RM doesnt have the applicationid (or applicationAttemptId) it throws exception and only then AHS is contacted to retreive all the containers.
        There is already an issue raised for YARN-1794(Yarn CLI only shows running containers for Running Applications)
        so i would like to fix the first 3 points in this jira and open a new jira for the 4th point and make that dependent on YARN-1794. And once YARN-1794 is taken care then would like to finish the 4th point
        Zhijie Shen,Sunil G,Devaraj K & Jian He please provide your opinion

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi All, Sorry for the break, i was in transit away from my home location and hence was not able to put more effort on this issue. Based on the initial understanding of the interface and commands documentation, i thought the suggestions mentioned by Zhijie Shen is feasible, but while coding and testing i came to realise that this command (or existing command: yarn container -list <appAttemptID>) behaves differently when it hits RM and AHS. RM provides only live running containers and only when RM doesnt have the applicationid (or applicationAttemptId) it throws exception and only then AHS is contacted to retreive all the containers. There is already an issue raised for YARN-1794 (Yarn CLI only shows running containers for Running Applications) so i would like to fix the first 3 points in this jira and open a new jira for the 4th point and make that dependent on YARN-1794 . And once YARN-1794 is taken care then would like to finish the 4th point Zhijie Shen , Sunil G , Devaraj K & Jian He please provide your opinion
        Hide
        sunilg Sunil G added a comment -

        I didn't get ur mail. But this response wud suffice.

        Show
        sunilg Sunil G added a comment - I didn't get ur mail. But this response wud suffice.
        Hide
        sunilg Sunil G added a comment -

        Sorry. Please discard my earlier comment.

        Show
        sunilg Sunil G added a comment - Sorry. Please discard my earlier comment.
        Hide
        zjshen Zhijie Shen added a comment -

        Naganarasimha G R, do you mean you want to move

        appId with -all: containers of all app attempts in RM/Timeline server

        or

        May have an option to run as yarn container -list <appId> OR yarn application -list-containers <appId> also.

        later?

        Show
        zjshen Zhijie Shen added a comment - Naganarasimha G R , do you mean you want to move appId with -all: containers of all app attempts in RM/Timeline server or May have an option to run as yarn container -list <appId> OR yarn application -list-containers <appId> also. later?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Zhijie Shen,
        I believe the existing working of

        yarn container -list <appAttemptID>

        itself is not proper (wrt YARN-1794) and once all the data is taken from time line server it would make proper sense for the end user.
        End user should not bother its coming from AHS/Timeline/RM and result should be list of all containers for the given attempt or app ID.
        I have the code for the command
        bd.yarn container -list <appAttemptID/appID>
        but i feel it would not be complete until timeline integration is done and users of this command will again get confused if given with half feature
        So my pick would be to your second option as new jira i.e

        yarn container -list <appAttemptID/appID>

        but if you see timeline server intergration will be delayed then we can discuss what part of the command could be taken and the behavior of it.
        Also i would like to fix YARN-1794-show all containers when application is finished from AHS instead of no containers from RM
        (again here too . i would like to fix the bug after timeline integration, so that list of all containers for the given attempt or app ID irrespective of the app state )
        Please provide your opinion.

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Zhijie Shen , I believe the existing working of yarn container -list <appAttemptID> itself is not proper (wrt YARN-1794 ) and once all the data is taken from time line server it would make proper sense for the end user. End user should not bother its coming from AHS/Timeline/RM and result should be list of all containers for the given attempt or app ID. I have the code for the command bd.yarn container -list <appAttemptID/appID> but i feel it would not be complete until timeline integration is done and users of this command will again get confused if given with half feature So my pick would be to your second option as new jira i.e yarn container -list <appAttemptID/appID> but if you see timeline server intergration will be delayed then we can discuss what part of the command could be taken and the behavior of it. Also i would like to fix YARN-1794 - show all containers when application is finished from AHS instead of no containers from RM (again here too . i would like to fix the bug after timeline integration, so that list of all containers for the given attempt or app ID irrespective of the app state ) Please provide your opinion.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi All,
        I will be splitting this jira into 2 jira issue. First one containing the first 3 parts and new jira will have the 4th point
        Also uploading the patch for the first 3 points in this jira

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi All, I will be splitting this jira into 2 jira issue. First one containing the first 3 parts and new jira will have the 4th point Also uploading the patch for the first 3 points in this jira
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Patch for first 3 issues

        Show
        Naganarasimha Naganarasimha G R added a comment - Patch for first 3 issues
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12670885/YARN-2301.01.patch
        against trunk revision ef784a2.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

        org.apache.hadoop.yarn.client.cli.TestYarnCLI
        org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA
        org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
        org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService

        The following test timeouts occurred in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

        org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5093//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5093//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12670885/YARN-2301.01.patch against trunk revision ef784a2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.client.cli.TestYarnCLI org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService The following test timeouts occurred in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5093//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5093//console This message is automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Attaching patch with corrected test cases.

        Show
        Naganarasimha Naganarasimha G R added a comment - Attaching patch with corrected test cases.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Attaching patch for the unit test failures.

        Show
        Naganarasimha Naganarasimha G R added a comment - Attaching patch for the unit test failures.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12671912/YARN-2303.patch
        against trunk revision c88c6c5.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5175//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671912/YARN-2303.patch against trunk revision c88c6c5. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5175//console This message is automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Updated patch[YARN.2301.03.patch] . Have fixed compile issues and unit test case failures

        Show
        Naganarasimha Naganarasimha G R added a comment - Updated patch [YARN.2301.03.patch] . Have fixed compile issues and unit test case failures
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12673774/YARN-2301.03.patch
        against trunk revision a169051.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

        org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart

        The test build failed in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5338//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/5338//artifact/patchprocess/patchReleaseAuditProblems.txt
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5338//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12673774/YARN-2301.03.patch against trunk revision a169051. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart The test build failed in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5338//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/5338//artifact/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5338//console This message is automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi ,

        • Release audit warnings is related to improper checkin into git and already jira YARN-2665 is raised
        • Test failure (TestAMRestart.testShouldNotCountFailureToMaxAttemptRetry) is related to some other issue and jira (YARN-2365) has been raised for it
        • Also for my first patch there were some test failures (TestApplicationClientProtocolOnHA.testGetContainersOnHA()) not related to this jira/fix which i have corrected in the 3rd patch and it seems to be working.
        Show
        Naganarasimha Naganarasimha G R added a comment - Hi , Release audit warnings is related to improper checkin into git and already jira YARN-2665 is raised Test failure (TestAMRestart.testShouldNotCountFailureToMaxAttemptRetry) is related to some other issue and jira ( YARN-2365 ) has been raised for it Also for my first patch there were some test failures (TestApplicationClientProtocolOnHA.testGetContainersOnHA()) not related to this jira/fix which i have corrected in the 3rd patch and it seems to be working.
        Hide
        jianhe Jian He added a comment -

        thanks Naganarasimha G R, looked at the latest patch, some comments:

        • we can just use containerReport.getFinishTime(), as it internally is checking “>0” already.
                    (containerReport.getFinishTime() == 0 ? "N/A" : Times
                    .format(containerReport.getFinishTime())),   
          
        • the scheme could be https also, we should use WebAppUtils#getHttpSchemePrefix
          "http://"
                        + WebAppUtils.getRunningLogURL(container.getNodeHttpAddress(),
                            ConverterUtils.toString(containerId), user);
          
        Show
        jianhe Jian He added a comment - thanks Naganarasimha G R , looked at the latest patch, some comments: we can just use containerReport.getFinishTime(), as it internally is checking “>0” already. (containerReport.getFinishTime() == 0 ? "N/A" : Times .format(containerReport.getFinishTime())), the scheme could be https also, we should use WebAppUtils#getHttpSchemePrefix "http: //" + WebAppUtils.getRunningLogURL(container.getNodeHttpAddress(), ConverterUtils.toString(containerId), user);
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Jian He,
        Thanks for reviewing, but required more clarifications :

        we can just use containerReport.getFinishTime(), as it internally is checking “>0” already.

        This modification is to support for the 3 issue which you mentioned 3. finish-time is 0 if container is not yet finished. May be "N/A" and dint get where exactly ">0" is being checked internally as there are no checks in PBImpl. Can you please provide more precisely where this check is done internally?

        the scheme could be https also, we should use WebAppUtils#getHttpSchemePrefix

        Due to the following reasons i kept scheme hard coded to http
        1. We get the containers HTTP address only and to that we appending the scheme WebAppUtils.getRunningLogURL(container.getNodeHttpAddress(). so irrespective of what scheme we set, the port will be node's http port where this container ran. so it would not be ideal to set scheme as HTTPS and node's http port. And if we need to correct this then we need to enforce Container.newInstance to take https url also
        which will impact lot of places
        2. WebAppUtils#getHttpSchemePrefix requires configuration object, so as the reference is not available in RMContainerImpl, i need to create new YARNConfigurations RMContainerImpl constructor and keep it. may be trivial issue

        so kept the changes simple. Please provide your opinion for the same

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Jian He , Thanks for reviewing, but required more clarifications : we can just use containerReport.getFinishTime(), as it internally is checking “>0” already. This modification is to support for the 3 issue which you mentioned 3. finish-time is 0 if container is not yet finished. May be "N/A" and dint get where exactly ">0" is being checked internally as there are no checks in PBImpl. Can you please provide more precisely where this check is done internally? the scheme could be https also, we should use WebAppUtils#getHttpSchemePrefix Due to the following reasons i kept scheme hard coded to http 1. We get the containers HTTP address only and to that we appending the scheme WebAppUtils.getRunningLogURL(container.getNodeHttpAddress() . so irrespective of what scheme we set, the port will be node's http port where this container ran. so it would not be ideal to set scheme as HTTPS and node's http port. And if we need to correct this then we need to enforce Container.newInstance to take https url also which will impact lot of places 2. WebAppUtils#getHttpSchemePrefix requires configuration object, so as the reference is not available in RMContainerImpl, i need to create new YARNConfigurations RMContainerImpl constructor and keep it. may be trivial issue so kept the changes simple. Please provide your opinion for the same
        Hide
        zjshen Zhijie Shen added a comment -

        i need to create new YARNConfigurations RMContainerImpl constructor and keep it.

        We shouldn't construct a yarn config object. Instead, when constructing RMContainerImpl, we need to pass the existing config object in as we did for RMAppImpl and RMAppAttemptImpl

        Show
        zjshen Zhijie Shen added a comment - i need to create new YARNConfigurations RMContainerImpl constructor and keep it. We shouldn't construct a yarn config object. Instead, when constructing RMContainerImpl, we need to pass the existing config object in as we did for RMAppImpl and RMAppAttemptImpl
        Hide
        jianhe Jian He added a comment -

        he port will be node's http

        NM can setup SSL and so the port can also be https port.

        Can you please provide more precisely where this check is done internally?

        I meant Times.format is internally doing the check.

        pass the existing config object

        this will cause a series method signature changes. we may set the conf object in the rmContext and get it from context

        Show
        jianhe Jian He added a comment - he port will be node's http NM can setup SSL and so the port can also be https port. Can you please provide more precisely where this check is done internally? I meant Times.format is internally doing the check. pass the existing config object this will cause a series method signature changes. we may set the conf object in the rmContext and get it from context
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        NM can setup SSL and so the port can also be https port.

        Ok. crosschecked the code, http/https port is set in RMNode.httpport based on configuration. So there should not be any issues

        I meant Times.format is internally doing the check.

        Ok, corrected

        we may set the conf object in the rmContext and get it from context

        Ok, corrected

        Show
        Naganarasimha Naganarasimha G R added a comment - NM can setup SSL and so the port can also be https port. Ok. crosschecked the code, http/https port is set in RMNode.httpport based on configuration. So there should not be any issues I meant Times.format is internally doing the check. Ok, corrected we may set the conf object in the rmContext and get it from context Ok, corrected
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Jian He,
        Hope my last patch addressed the issues you mentioned, and for the 4th point i am waiting for some pending work on timeline server and once done will raise the issue and support it . So shall i change the status of this jira to patch available ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Jian He , Hope my last patch addressed the issues you mentioned, and for the 4th point i am waiting for some pending work on timeline server and once done will raise the issue and support it . So shall i change the status of this jira to patch available ?
        Hide
        jianhe Jian He added a comment -

        Naganarasimha G R, sorry, didn't notice new patch is uploaded. looks like it's not applying on trunk any more, would you mind updating ?

        Show
        jianhe Jian He added a comment - Naganarasimha G R , sorry, didn't notice new patch is uploaded. looks like it's not applying on trunk any more, would you mind updating ?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        rebasing and updating the patch

        Show
        Naganarasimha Naganarasimha G R added a comment - rebasing and updating the patch
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        updated the patch as per the review comments

        Show
        Naganarasimha Naganarasimha G R added a comment - updated the patch as per the review comments
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12684920/YARN-2301.20141203-1.patch
        against trunk revision 03ab24a.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

        org.apache.hadoop.yarn.client.TestResourceTrackerOnHA
        org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA
        org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
        org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5987//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5987//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684920/YARN-2301.20141203-1.patch against trunk revision 03ab24a. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.client.TestResourceTrackerOnHA org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5987//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5987//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12684920/YARN-2301.20141203-1.patch
        against trunk revision a31e016.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5989//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684920/YARN-2301.20141203-1.patch against trunk revision a31e016. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5989//console This message is automatically generated.
        Hide
        jianhe Jian He added a comment -

        looks good overall,

        • we do not need to expose the setter in RMContext interface
          public void setYarnConfiguration(Configuration yarnConfiguration);
        • changes in TestApplicationClientProtocolOnHA may be not needed.
        Show
        jianhe Jian He added a comment - looks good overall, we do not need to expose the setter in RMContext interface public void setYarnConfiguration(Configuration yarnConfiguration); changes in TestApplicationClientProtocolOnHA may be not needed.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Jian He,
        Corrected the review comments and also one test case failure(org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService) was related to the modifications hence corrected it but the following test case failures/errors are not related to my changes :

        1. org.apache.hadoop.yarn.client.TestResourceTrackerOnHA
        2. org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA
        3. org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart

        Also i am confused to whether to change status as patch available as you reverted it back to Open status twice earlier. Please check and inform if required will update the status as patch available.

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Jian He , Corrected the review comments and also one test case failure(org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService) was related to the modifications hence corrected it but the following test case failures/errors are not related to my changes : org.apache.hadoop.yarn.client.TestResourceTrackerOnHA org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA org.apache.hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart Also i am confused to whether to change status as patch available as you reverted it back to Open status twice earlier. Please check and inform if required will update the status as patch available.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12685097/YARN-2301.20141204-1.patch
        against trunk revision 1bbcc3d.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5994//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5994//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685097/YARN-2301.20141204-1.patch against trunk revision 1bbcc3d. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5994//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5994//console This message is automatically generated.
        Hide
        jianhe Jian He added a comment -

        Hi Naganarasimha G R,
        patch looks good. thanks for updating!

        reviewer sometimes cancel the patch for the patch to be updated. You can just re-submit the patch once upload a new patch.

        Show
        jianhe Jian He added a comment - Hi Naganarasimha G R , patch looks good. thanks for updating! reviewer sometimes cancel the patch for the patch to be updated. You can just re-submit the patch once upload a new patch.
        Hide
        jianhe Jian He added a comment -

        Committed to trunk and branch-2, thanks Naganarasimha G R !

        Show
        jianhe Jian He added a comment - Committed to trunk and branch-2, thanks Naganarasimha G R !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #6649 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6649/)
        YARN-2301. Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6649 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6649/ ) YARN-2301 . Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Jian He for reviewing and committing the patch will open a new jira for the forth issue and start working on it .

        reviewer sometimes cancel the patch for the patch to be updated. You can just re-submit the patch once upload a new patch.

        I was of the notion that if reviewer feels the patch is not completely as per expectation then then he cancel's the patch. In this case the comment was like patch seems good but still patch was cancelled hence was little confused ... ok next time will re-submit it.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Jian He for reviewing and committing the patch will open a new jira for the forth issue and start working on it . reviewer sometimes cancel the patch for the patch to be updated. You can just re-submit the patch once upload a new patch. I was of the notion that if reviewer feels the patch is not completely as per expectation then then he cancel's the patch. In this case the comment was like patch seems good but still patch was cancelled hence was little confused ... ok next time will re-submit it.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #765 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/765/)
        YARN-2301. Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #765 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/765/ ) YARN-2301 . Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/26/)
        YARN-2301. Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/26/ ) YARN-2301 . Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/26/)
        YARN-2301. Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/26/ ) YARN-2301 . Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1958 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1958/)
        YARN-2301. Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1958 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1958/ ) YARN-2301 . Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1980 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1980/)
        YARN-2301. Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1980 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1980/ ) YARN-2301 . Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/26/)
        YARN-2301. Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/26/ ) YARN-2301 . Improved yarn container command. Contributed by Naganarasimha G R (jianhe: rev 258623ff8bb1a1057ae3501d4f20982d5a59ea34) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContext.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/TestRMContainerImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Pulled this into 2.6.1 as a dependency for YARN-3978. The patch applied cleanly, had to make minor change to the TestYarnCLI to make it work correctly on 2.6.1.

        Ran compilation and TestYarnCLI, TestClientRMService, TestRMContainerImpl before the push.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1 as a dependency for YARN-3978 . The patch applied cleanly, had to make minor change to the TestYarnCLI to make it work correctly on 2.6.1. Ran compilation and TestYarnCLI, TestClientRMService, TestRMContainerImpl before the push.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Attaching patch that I committed to 2.6.1.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Attaching patch that I committed to 2.6.1.

          People

          • Assignee:
            Naganarasimha Naganarasimha G R
            Reporter:
            jianhe Jian He
          • Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development