Hadoop YARN
  1. Hadoop YARN
  2. YARN-225

Proxy Link in RM UI thows NPE in Secure mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha, 2.0.1-alpha, 2.0.3-alpha
    • Fix Version/s: 2.0.3-alpha, 0.23.6
    • Component/s: resourcemanager
    • Labels:
      None

      Description

      java.lang.NullPointerException
      	at org.apache.hadoop.yarn.server.webproxy.WebAppProxyServlet.doGet(WebAppProxyServlet.java:241)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
      	at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
      	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221)
      	at org.apache.hadoop.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:109)
      	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
      	at org.apache.hadoop.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:975)
      	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
      	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
      	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
      	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
      	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
      	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
      	at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
      	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
      	at org.mortbay.jetty.Server.handle(Server.java:326)
      	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
      	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
      	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
      	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
      	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
      	at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
      	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
      
      
      

        Activity

        Hide
        Devaraj K added a comment -

        Attaching patch to this issue.

        Show
        Devaraj K added a comment - Attaching patch to this issue.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12554308/YARN-225.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/172//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/172//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554308/YARN-225.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/172//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/172//console This message is automatically generated.
        Hide
        Zesheng Wu added a comment -

        I encountered the same problem, can anyone make sure that this is the right patch?

        Show
        Zesheng Wu added a comment - I encountered the same problem, can anyone make sure that this is the right patch?
        Hide
        Zesheng Wu added a comment -

        I applied this patch, and it really works.

        Show
        Zesheng Wu added a comment - I applied this patch, and it really works.
        Hide
        Devaraj K added a comment -

        Thanks Wuzesheng for verifying the patch.

        Show
        Devaraj K added a comment - Thanks Wuzesheng for verifying the patch.
        Hide
        Robert Joseph Evans added a comment -

        That does look to be the correct patch assuming that the stack trace was against 2.0.2 or before. Either way it is a fix that needs to go in, because I misread the HttpServletRequestJavadocs and missed "or null if the request has no cookies". The fix needs to go into branch-0.23 as well. I am +1 for the fix and will check it in.

        Show
        Robert Joseph Evans added a comment - That does look to be the correct patch assuming that the stack trace was against 2.0.2 or before. Either way it is a fix that needs to go in, because I misread the HttpServletRequestJavadocs and missed "or null if the request has no cookies". The fix needs to go into branch-0.23 as well. I am +1 for the fix and will check it in.
        Hide
        Robert Joseph Evans added a comment -

        Thanks Devaraj for the patch. Sorry it took so long to pull it in. I put it into trunk, branch-2, and branch-0.23.

        Show
        Robert Joseph Evans added a comment - Thanks Devaraj for the patch. Sorry it took so long to pull it in. I put it into trunk, branch-2, and branch-0.23.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #478 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/478/)
        svn merge -c 1426515 FIXES: YARN-225. Proxy Link in RM UI thows NPE in Secure mode (Devaraj K via bobby) (Revision 1426517)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1426517
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #478 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/478/ ) svn merge -c 1426515 FIXES: YARN-225 . Proxy Link in RM UI thows NPE in Secure mode (Devaraj K via bobby) (Revision 1426517) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1426517 Files : /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1269 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1269/)
        YARN-225. Proxy Link in RM UI thows NPE in Secure mode (Devaraj K via bobby) (Revision 1426515)

        Result = FAILURE
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1426515
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1269 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1269/ ) YARN-225 . Proxy Link in RM UI thows NPE in Secure mode (Devaraj K via bobby) (Revision 1426515) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1426515 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1299 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1299/)
        YARN-225. Proxy Link in RM UI thows NPE in Secure mode (Devaraj K via bobby) (Revision 1426515)

        Result = SUCCESS
        bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1426515
        Files :

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1299 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1299/ ) YARN-225 . Proxy Link in RM UI thows NPE in Secure mode (Devaraj K via bobby) (Revision 1426515) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1426515 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java

          People

          • Assignee:
            Devaraj K
            Reporter:
            Devaraj K
          • Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development