[YARN-2165] Timeline server should validate the numeric configuration values

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.7.0
• Component/s: timelineserver
• Hadoop Flags: Reviewed
• Assignee: Vasanth kumar RJ
• Reporter: Karam Singh
• Created: 16/Jun/14 19:30
• Updated: 24/Apr/15 23:17
• Resolved: 26/Nov/14 20:14

Description

Timelineserver should validate that yarn.timeline-service.ttl-ms is greater than zero

Currently if set yarn.timeline-service.ttl-ms=0
Or yarn.timeline-service.ttl-ms=-86400

Timeline server start successfully with complaining

2014-06-15 14:52:16,562 INFO  timeline.LeveldbTimelineStore (LeveldbTimelineStore.java:<init>(247)) - Starting deletion thread with ttl -604800000 and cycle interval 300000

At starting timelinserver should that yarn.timeline-service-ttl-ms > 0
otherwise specially for -ive value discard oldvalues timestamp will be set future value. Which may lead to inconsistancy in behavior

    public void run() {
      while (true) {
        long timestamp = System.currentTimeMillis() - ttl;
        try {
          discardOldEntities(timestamp);
          Thread.sleep(ttlInterval);

Issue Links

• duplicates: YARN-2166 Timelineserver should validate that yarn.timeline-service.leveldb-timeline-store.ttl-interval-ms is greater than zero when level db is for timeline store